Add better histograms to track the effects of making Unified Plan the default |
||
Issue descriptionWe need to track "using complex SDP but relying on default sdpSemantics" in order to evaluate the effects of making Unified Plan the default, as these use cases are particularly sensitive to switching the default. We should add a histogram for each step that track if usage is "safe" or "unsafe" in when considering the default switching: 1. createOffer() 2. setLocalDescription(offer) 3. setRemoteDescription(offer) 4. createAnswer() 5. setLocalDescription(answer) 6. setRemoteDescription(answer)
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb4db58c02ccf9d12b5f5be4c3000a0095ac0867 commit eb4db58c02ccf9d12b5f5be4c3000a0095ac0867 Author: Henrik Boström <hbos@chromium.org> Date: Tue Oct 30 22:33:31 2018 Add histograms for complex SDP usage relying on default sdpSemantics. The SDP negotiation operations - createOffer(), setLocalDescription(offer), setRemoteDescription(offer), createAnswer(), setLocalDescription(answer) and setRemoteDescription(answer) - can be used in a "safe" or "unsafe" way when thinking about the default of sdpSemantics changing from Plan B to Unified Plan. In particular, it is "unsafe" to use complex SDP without explicitly setting sdpSemantics, since this case results in SDP that is incompatible between Plan B and Unified Plan clients. This CL adds histograms for "safe", "unsafe" and "unknown" usage of SDP for each operation. Bug: 899747 Change-Id: I9a21e3190c3f35153e6e8f31fb63f775d2ea8d31 Reviewed-on: https://chromium-review.googlesource.com/c/1304558 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#604039} [modify] https://crrev.com/eb4db58c02ccf9d12b5f5be4c3000a0095ac0867/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc [modify] https://crrev.com/eb4db58c02ccf9d12b5f5be4c3000a0095ac0867/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.h [modify] https://crrev.com/eb4db58c02ccf9d12b5f5be4c3000a0095ac0867/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_test.cc [modify] https://crrev.com/eb4db58c02ccf9d12b5f5be4c3000a0095ac0867/tools/metrics/histograms/enums.xml [modify] https://crrev.com/eb4db58c02ccf9d12b5f5be4c3000a0095ac0867/tools/metrics/histograms/histograms.xml
,
Nov 1
|
||
►
Sign in to add a comment |
||
Comment 1 by hbos@chromium.org
, Oct 29