New issue
Advanced search Search tips

Issue 899724 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 1
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Uploading CLs from Windows does not work anymore

Project Member Reported by ahaas@chromium.org, Oct 29

Issue description

Parsing OWNER files causes a problem. I think it was introduced in https://crrev.com/c/1204917.

PS C:\src\v8> git cl upload
Running presubmit upload checks ...
Traceback (most recent call last):
  File "C:\src\depot_tools\metrics.py", line 255, in print_notice_and_exit
    yield
  File "C:\src\depot_tools\git_cl.py", line 5939, in <module>
    sys.exit(main(sys.argv[1:]))
  File "C:\src\depot_tools\git_cl.py", line 5921, in main
    return dispatcher.execute(OptionParser(), argv)
  File "C:\src\depot_tools\subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "C:\src\depot_tools\metrics.py", line 240, in _inner
    return self._collect_metrics(func, command_name, *args, **kwargs)
  File "C:\src\depot_tools\metrics.py", line 200, in _collect_metrics
    result = func(*args, **kwargs)
  File "C:\src\depot_tools\git_cl.py", line 4983, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "C:\src\depot_tools\git_cl.py", line 1641, in CMDUpload
    change=change, parallel=options.parallel)
  File "C:\src\depot_tools\git_cl.py", line 1583, in RunHook
    parallel=parallel)
  File "C:\src\depot_tools\presubmit_support.py", line 1547, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "C:\src\depot_tools\presubmit_support.py", line 1454, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 447, in CheckChangeOnUpload
  File "<string>", line 310, in _CommonChecks
  File "C:\src\depot_tools\presubmit_canned_checks.py", line 887, in CheckOwners
    override_files=input_api.change.OriginalOwnersFiles())
  File "C:\src\depot_tools\owners_finder.py", line 40, in __init__
    self.db.load_data_needed_for(files)
  File "C:\src\depot_tools\owners.py", line 219, in load_data_needed_for
    self._read_owners(self.os_path.join(dirpath, 'OWNERS'))
  File "C:\src\depot_tools\owners.py", line 304, in _read_owners
    lineno, '\n'.join(comment + line_comment))
  File "C:\src\depot_tools\owners.py", line 363, in _add_entry
    include_file = self._resolve_include(directive[5:], owners_path, lineno)
  File "C:\src\depot_tools\owners.py", line 399, in _resolve_include
    raise SyntaxErrorInOwnersFile(start, lineno, 'file: include must specify '
SyntaxErrorInOwnersFile: C:\src\v8\include\OWNERS:8 syntax error: file: include must specify a file named OWNERS or ending in _OWNERS
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/24bca4e741a98a0f6ed9bdeb64c07816243d2873

commit 24bca4e741a98a0f6ed9bdeb64c07816243d2873
Author: Daniel Cheng <dcheng@chromium.org>
Date: Thu Nov 01 04:11:41 2018

owners.py: Use os.path.split to handle file separators correctly

The script gets confused on Windows, because the path delimieter is \,
not /.

Bug:  899724 
Change-Id: Id907aceb4f7bb6fcc0460245890b9e4716054ff9
Reviewed-on: https://chromium-review.googlesource.com/c/1308897
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>

[modify] https://crrev.com/24bca4e741a98a0f6ed9bdeb64c07816243d2873/testing_support/filesystem_mock.py
[modify] https://crrev.com/24bca4e741a98a0f6ed9bdeb64c07816243d2873/owners.py

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2469282ca473a740fc36e4da4187cc19a1908dd

commit d2469282ca473a740fc36e4da4187cc19a1908dd
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Nov 01 05:32:49 2018

Roll src/third_party/depot_tools a870c9698af1..24bca4e741a9 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a870c9698af1..24bca4e741a9


git log a870c9698af1..24bca4e741a9 --date=short --no-merges --format='%ad %ae %s'
2018-11-01 dcheng@chromium.org owners.py: Use os.path.split to handle file separators correctly


Created with:
  gclient setdep -r src/third_party/depot_tools@24bca4e741a9

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:899724 
TBR=agable@chromium.org

Change-Id: Id3507c99e83e3f9484c5d0a3c1a6c53526c46087
Reviewed-on: https://chromium-review.googlesource.com/c/1312264
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604522}
[modify] https://crrev.com/d2469282ca473a740fc36e4da4187cc19a1908dd/DEPS

Status: Fixed (was: Started)
Thank you!

Sign in to add a comment