New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 899683 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-11-14
OS: Linux , Windows
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression:Selection blue ring doesn't match tile size on zooming NTP to 150% or beyond

Reported by vineetha...@etouch.net, Oct 29

Issue description

Chrome Version: 71.0.3578.27 (Official Build) Revision	d7850e07856a010c464bc7ea52e4ee10ca5965ce-refs/branch-heads/3578@{#361}(32/64-bit)
OS: Windows(7,8,8.1,10), Linux (14.04 LTS)

Pre-condition: Enable "Enable using the Google local NTP" ,"New Tab Page Background Selection" and "New Tab Page Custom Links" flags under chrome://flags.

What steps will reproduce the problem?
1. Launch chrome, open NTP, zoom in to 150% or beyond.
2. Now resize browser window from RHS to the maximum possible limit.
3. Click on the gear icon > click on 'Chrome backgrounds'(observe that tiles appear one in a row).
4. On 'Select a collection' overlay ,select any category to open another overlay listing the wallpapers.
5. Click on any wallpaper to select it and observe.

Actual Result  : Selection blue ring doesn't match tile size on zooming to 150% or beyond.
Expected Result: Selection blue ring should match tile size on zooming to 150% and beyond.

This is a regression issue broken in ‘M-71’ and below is the 'per-revision' bisect information:
Good Build : 71.0.3558.0 (Revision : 593043)
Bad Build  : 71.0.3559.0 (Revision : 593399)

You are probably looking for a change made after 593073 (known good), but no later than 593074 (first known bad).

CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.  

https://chromium.googlesource.com/chromium/src/+log/440f2144f9fc3f733d0bfefafeaeb11c780014d3..c95c6af2d0d93f7cd103fd0282795fdc60d01bb4

Suspect: https://chromium.googlesource.com/chromium/src/+/c95c6af2d0d93f7cd103fd0282795fdc60d01bb4

@sweilun : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer the attached screen-cast.

Note:
1.Issue is reproducible on current Dev build #72.0.3590.0 and latest Canary build #72.0.3595.0
2.Issue is not seen on Mac OS.

Thank you
 
ActualVideo.mp4
1.3 MB View Download
ExpectedVideo.mp4
975 KB View Download
Labels: -Pri-1 Pri-3
Owner: kmilka@chromium.org
Status: Unconfirmed (was: Assigned)
Kyle - can you triage this?
Status: Available (was: Unconfirmed)
Status: Assigned (was: Available)
Labels: zine-triaged
Labels: -M-71 -Target-71 KR-NTP-MD2-Polish small O-Polish-Birthday-Features
NextAction: 2018-11-14
The NextAction date has arrived: 2018-11-14
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5268987ffdb16bb59d24eb7bc2e30c4f9efa3ad6

commit 5268987ffdb16bb59d24eb7bc2e30c4f9efa3ad6
Author: Kyle Milka <kmilka@chromium.org>
Date: Wed Nov 14 22:51:15 2018

[NTP] Correct width and height of outline on selected tile

The width and height of the selected outline should be equal to
the dimensions of the parent subtract two times the pixel width
of the outline.

Bug:  899683 
Change-Id: I9c2c8fc669651fe713e1aa431438c3fe02881543
Reviewed-on: https://chromium-review.googlesource.com/c/1335780
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608150}
[modify] https://crrev.com/5268987ffdb16bb59d24eb7bc2e30c4f9efa3ad6/chrome/browser/resources/local_ntp/custom_backgrounds.css

Labels: AddToRemoteNTP
Status: Fixed (was: Started)
Labels: TE-Verified-M72 TE-Verified-72.0.3611.0
Update:

Rechecked the above issue on Windows(7,8,8.1,10), Linux (14.04 LTS) OS using latest Canary build #72.0.3611.0 and the issue is fixed. Kindly refer attached screen cast.
Canary_Behaviour.mp4
1.7 MB View Download

Sign in to add a comment