Issue metadata
Sign in to add a comment
|
IAcessible get_uniqueid() changes in an input control if aria-haspopup state changes |
||||||||||||||||||||||||
Issue descriptionChrome Version: Version 70.0.3538.77 (Official Build) (64-bit) OS: Windows 10 Open http://www.google.co.uk/ Use an accessibility tool to check the unique id of the main edit control. Start typing. The edit control in the accessibility tree gets destroyed and recreated with a different uniqueid as you type each character. Note that it's only the accessibility tree that this is happening in, the edit control remains static in the actual DOM tree. The uniqueid should remain the same. Supernova uses the uniqueid to determine if the focus is still on the same control. Chrome 69 does not have this problem, with the same URL. This only affects the google home page, other web sites so far do not have the problem. We don't know why.
,
Oct 29
This regressed in M-70, but setting target milestone to M-72 until we know what the fix will look like and whether it's worth merging. This change regressed it: https://chromium-review.googlesource.com/c/chromium/src/+/1196864/
,
Oct 29
,
Nov 5
Friendly ping to get an update on this issue as it is marked as RBS. Thanks..!
,
Nov 12
Gentle ping to get an update as it is marked as RB stable. Thanks..!
,
Nov 27
Gentle ping on the issue marked as Stable blocker.
,
Nov 27
,
Nov 29
Should be in tomorrow's Canary.
,
Nov 29
[Auto-generated comment by a script] We noticed that this issue is targeted for M-72; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-72 label, otherwise remove Merge-TBD label. Thanks.
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/823e2488aed4db59bf40b69cf5dc8457da927ffe commit 823e2488aed4db59bf40b69cf5dc8457da927ffe Author: Aaron Leventhal <aleventhal@chromium.org> Date: Tue Dec 04 19:01:21 2018 Do not trigger role change on textfield from size or aria-haspopup change Some screen readers watch for unique id changes as the user edits a textfield, so we need to be more conservative about invalidating editable objects when the role has not really changed. Bug: 899676 Change-Id: I835bc9d087048fb17524b916c95fd5aa2aa9062b Reviewed-on: https://chromium-review.googlesource.com/c/1352474 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#613620} [modify] https://crrev.com/823e2488aed4db59bf40b69cf5dc8457da927ffe/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc [modify] https://crrev.com/823e2488aed4db59bf40b69cf5dc8457da927ffe/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
,
Dec 5
Tried checking the issue on reported chrome version 70.0.3538.77 and on the latest canary 73.0.3631.0 using Windows 10 with the below mentioned steps. 1. Launched Chrome 2. Created an HTML file using code given in comment#1 3. Opened the file in a new tab 4. Using an accessibility tool(NVDA) clicked in input field and entered few characters. Observed similar behaviour in both the above mentioned versions. @Aaron Leventhal: Could you please let us know if we have missed anything in the process. As we are not very sure about how to check the unique id of the main edit control, Could you please clarify on it and help us in verifying the fix.
,
Dec 7
aleventhal@, does this require a merge to 72.0 branch?? If so please remove the merge-TBD label and apply the merge request label for 72
,
Dec 10
aleventhal@ friendly ping again if this needs a merge to 72
,
Dec 10
,
Dec 10
Vamshi, the easiest thing to do is to check with the reporter if it satisfied their requirements. I'll send them an email and ask for a comment. Thanks. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by mike.hil...@gmail.com
, Oct 29simplified sample web page - this just toggles aria-haspopup on every key press. <!DOCTYPE HTML> <HEAD> <TITLE>Input test</TITLE> <script type="text/javascript"> var temp = false; function keyfunc() { if(temp) document.getElementById('one').setAttribute("aria-haspopup","false"); else document.getElementById('one').setAttribute("aria-haspopup","true"); temp = !temp; } </script> </HEAD> <body> Title <input id="one" type="text" role="combobox" aria-label="Search" aria-haspopup="false" onkeypress="keyfunc()"></input> </body> </HTML>