Issue metadata
Sign in to add a comment
|
FilesAppBrowserTest tests flaky on MSan bots |
||||||||||||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of grunell@chromium.org single_process_mash_browser_tests failing on Chromium OS builders, for example chromium.chromiumos/linux-chromeos-dbg Builders failed on: - linux-chromeos-dbg: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg - chromium.memory/Linux Chromium OS ASan LSan Tests (1): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29
,
Oct 29
Likely this commit is the culprit: https://chromium.googlesource.com/chromium/src/+/cc54574deeccd4fa19012155093004b5e91ceac5
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e23b5cc1941dbd4ebd3a97f5697746015f89b06 commit 9e23b5cc1941dbd4ebd3a97f5697746015f89b06 Author: Henrik Grunell <grunell@chromium.org> Date: Mon Oct 29 10:10:39 2018 Revert "[Reland] Refactor DirectoryTree" This reverts commit cc54574deeccd4fa19012155093004b5e91ceac5. Reason for revert: Seems to be the reason for Chromium OS failures. BUG: 899664 Original change's description: > [Reland] Refactor DirectoryTree > > Fix flakiness by adding call to this.expanded=true in EntryListItem. > > Change updateSubDirectories: > - use arrow function and const; > - change error callback calling style to match the same style used by > success callback (without if). > - change check from isFakeEntry to check for presence of the method > that's used "createReader". > > Change the sorting to be an method, so it can be customized per > sub-class, later it will be used to sort My files to show Linux and Play > files at the bottom. > > Fix unittest that started failing because it metadataModel was null. > > No changes in behaviour for users, the small change in behaviour is > EntryListItem.updateSubDirectories now reads its children using FS API > which isn't synchronous. > > Change-Id: I1019247e776e266cdd980a4c8a8338bf2b516b87 > Reviewed-on: https://chromium-review.googlesource.com/c/1300993 > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603403} TBR=joelhockey@chromium.org,lucmult@chromium.org Change-Id: I9826f601fe469eb079b33e1415c3fddb324e0bb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1303731 Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#603446} [modify] https://crrev.com/9e23b5cc1941dbd4ebd3a97f5697746015f89b06/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js [modify] https://crrev.com/9e23b5cc1941dbd4ebd3a97f5697746015f89b06/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js
,
Oct 29
,
Oct 29
I'm having a look here, but I see the test flaking locally even after this revert. :-( I'll check further.
,
Oct 30
Right, it seems that the offending patch just exacerbated the existing flakiness.
The problem is in the initialization in setupAndWaitUntilReady, it add some entries, but sometimes the Files app has fully loaded before the entries were added and then the entries don't show up in the Downloads directory and the test gets stuck waiting for them.
With real files this isn't really a problem, because the file watcher will trigger the app to re-read the directory, since in the UI test it's all mocked out, this doesn't happen.
I've fixed that forcing a click on the refresh button after loading the new entries.:
assertTrue(test.fakeMouseClick('#refresh-button'), 'click refresh');
,
Oct 30
Uploaded the fix and put to run the linux-chromeos-dbg 10x, let's see how it goes. https://chromium-review.googlesource.com/c/chromium/src/+/1306953
,
Oct 30
I seem to be able to reliably replicate this error with command: testing/xvfb.py out/gnchromeos/browser_tests --test-launcher-bot-mode --enable-features=SingleProcessMash --gtest_filter=FileManagerUITest.UMA --gtest_repeat=50 The primary change is that EntryListItem.prototype.updateSubDirectories is changing from being a sync function, to being async via its reference to https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/common/js/files_app_entry_types.js?l=137&rcl=8ef190076d5f2d4f4b9ed626c7ab2b4a9dad2403. This function gets executed when FilesApp starts up and selects Downloads by default. https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js?l=576&rcl=e8414881fbb58c9734d4e351d8dcc33101879cfc Now that this function is async, it is possible that under race conditions, it will not complete and set Downloads to be selected before we run test.setupAndWaitUntilReady which checks whether Downloads is selected. https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/test/js/test_util.js?l=540&rcl=8ef190076d5f2d4f4b9ed626c7ab2b4a9dad2403 We then fail to refresh the Downloads directory. Fix is to either change updateSubDirectories back to sync (not such a great fix) or update test.setupAndWaitUntilReady to select Downloads when required and always refresh (much better fix). if (!downloadsIcon.parentElement.hasAttribute('selected')) { assertTrue(test.fakeMouseClick( '#directory-tree [volume-type-icon="downloads"]')); } assertTrue(test.fakeMouseClick('#refresh-button')); I have a CL coming soon.
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ac0ae644106fafc012ee44ad0f8a792682e1b53 commit 8ac0ae644106fafc012ee44ad0f8a792682e1b53 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue Oct 30 07:03:18 2018 CrOS FilesApp UI Tests: ensure downloads selected and refreshed in setup Bug: 899664 Change-Id: I779ebb94f52aabc9da58ad6a6c2c4ca1c206b69f Reviewed-on: https://chromium-review.googlesource.com/c/1307020 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#603814} [modify] https://crrev.com/8ac0ae644106fafc012ee44ad0f8a792682e1b53/ui/file_manager/file_manager/test/js/test_util.js
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7ecb7e9995d2ec1046eed8c3b9c4a561a8387b7 commit b7ecb7e9995d2ec1046eed8c3b9c4a561a8387b7 Author: Luciano Pacheco <lucmult@chromium.org> Date: Wed Oct 31 00:07:20 2018 [Reland attempt #2] Refactor DirectoryTree Fix flakiness by adding call to this.expanded=true in EntryListItem. Change updateSubDirectories: - use arrow function and const; - change error callback calling style to match the same style used by success callback (without if). - change check from isFakeEntry to check for presence of the method that's used "createReader". Change the sorting to be an method, so it can be customized per sub-class, later it will be used to sort My files to show Linux and Play files at the bottom. Fix unittest that started failing because it metadataModel was null. No changes in behaviour for users, the small change in behaviour is EntryListItem.updateSubDirectories now reads its children using FS API which isn't synchronous. CrOS FilesApp UI Tests: ensure downloads selected and refreshed in setup TBR: joelhockey@chromium.org Bug: 899664 Change-Id: I8a93616f74cf3bf2b99851dc2452249e1353d85e Reviewed-on: https://chromium-review.googlesource.com/c/1306963 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604069} [modify] https://crrev.com/b7ecb7e9995d2ec1046eed8c3b9c4a561a8387b7/ui/file_manager/file_manager/foreground/js/directory_model.js [modify] https://crrev.com/b7ecb7e9995d2ec1046eed8c3b9c4a561a8387b7/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js [modify] https://crrev.com/b7ecb7e9995d2ec1046eed8c3b9c4a561a8387b7/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f6e77343e7d23cca2b54c4123a8b3db016bb954 commit 2f6e77343e7d23cca2b54c4123a8b3db016bb954 Author: Luciano Pacheco <lucmult@chromium.org> Date: Wed Oct 31 04:23:46 2018 Disable flaky test This test is flaky/failing on MSAN, disabling until is fixed. TBR: joelhockey@chromium.org Bug: 899664 Change-Id: I89646e80d9bbb8735d0056c26c882b056b4c9e97 Reviewed-on: https://chromium-review.googlesource.com/c/1308239 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604147} [modify] https://crrev.com/2f6e77343e7d23cca2b54c4123a8b3db016bb954/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b162a3d9567a8a0a46291a52f891a64ea13cf7ae commit b162a3d9567a8a0a46291a52f891a64ea13cf7ae Author: Luciano Pacheco <lucmult@chromium.org> Date: Wed Oct 31 10:12:17 2018 Revert "[Reland attempt #2] Refactor DirectoryTree" This reverts commit b7ecb7e9995d2ec1046eed8c3b9c4a561a8387b7. Reason for revert: ChromiumOS MSAN got flaky/failing crbug.com/899664 Original change's description: > [Reland attempt #2] Refactor DirectoryTree > > Fix flakiness by adding call to this.expanded=true in EntryListItem. > > Change updateSubDirectories: > - use arrow function and const; > - change error callback calling style to match the same style used by > success callback (without if). > - change check from isFakeEntry to check for presence of the method > that's used "createReader". > > Change the sorting to be an method, so it can be customized per > sub-class, later it will be used to sort My files to show Linux and Play > files at the bottom. > > Fix unittest that started failing because it metadataModel was null. > > No changes in behaviour for users, the small change in behaviour is > EntryListItem.updateSubDirectories now reads its children using FS API > which isn't synchronous. > > CrOS FilesApp UI Tests: ensure downloads selected and refreshed in setup > > TBR: joelhockey@chromium.org > Bug: 899664 > Change-Id: I8a93616f74cf3bf2b99851dc2452249e1353d85e > Reviewed-on: https://chromium-review.googlesource.com/c/1306963 > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604069} TBR=joelhockey@chromium.org,lucmult@chromium.org Change-Id: Ic7903e70225a59e3eca7d581ea44202462b01dee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899664 Reviewed-on: https://chromium-review.googlesource.com/c/1309570 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604194} [modify] https://crrev.com/b162a3d9567a8a0a46291a52f891a64ea13cf7ae/ui/file_manager/file_manager/foreground/js/directory_model.js [modify] https://crrev.com/b162a3d9567a8a0a46291a52f891a64ea13cf7ae/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js [modify] https://crrev.com/b162a3d9567a8a0a46291a52f891a64ea13cf7ae/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js
,
Oct 31
Similar cases found for CreateNewFolder/FilesAppBrowserTest.Test/createFolderDownloads_GuestMode e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9358 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9360 Sample log: ==== [ RUN ] CreateNewFolder/FilesAppBrowserTest.Test/createFolderDownloads_GuestMode [14182:14182:1030/191909.806140:WARNING:easy_unlock_service_regular.cc(535)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false. [14182:14182:1030/191909.806276:INFO:easy_unlock_service_regular.cc(152)] DeviceSyncClient is not ready yet, delaying UseLoadedRemoteDevices(). [14182:14182:1030/191909.996532:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. [14182:14182:1030/191910.621293:INFO:secure_channel_service.cc(25)] SecureChannelService::OnStart() [14182:14182:1030/191910.621423:INFO:secure_channel_initializer.cc(64)] SecureChannelInitializer::SecureChannelInitializer(): Fetching Bluetooth adapter. All requests received before the adapter is fetched will be queued. [14182:14182:1030/191910.621727:INFO:secure_channel_service.cc(38)] SecureChannelService::OnBindInterface() for interface chromeos.secure_channel.mojom.SecureChannel. [14182:14182:1030/191910.622591:INFO:device_sync_service.cc(31)] DeviceSyncService::OnStart() [14182:14182:1030/191910.622852:INFO:device_sync_service.cc(48)] DeviceSyncService::OnBindInterface() from interface chromeos.device_sync.mojom.DeviceSync. [14182:14182:1030/191910.623775:INFO:multidevice_setup_service.cc(62)] MultiDeviceSetupService::OnStart() [14182:14182:1030/191910.624082:INFO:multidevice_setup_service.cc(75)] MultiDeviceSetupService::OnBindInterface() from interface chromeos.multidevice_setup.mojom.MultiDeviceSetup. [14182:14182:1030/191910.660516:INFO:secure_channel_initializer.cc(119)] SecureChannelInitializer::OnBluetoothAdapterReceived(): Bluetooth adapter has been fetched. Passing all queued requests to the service. [14182:14182:1030/191910.663231:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *) [14182:14318:1030/191911.934311:ERROR:service_manager_connection_impl.cc(318)] Can't create service multidevice_setup. No handler found. [14182:14182:1030/191913.197980:INFO:file_manager_browsertest_base.cc(1161)] FileManagerBrowserTest::StartTest createFolderDownloads_GuestMode [14182:14182:1030/191917.538551:INFO:file_manager_browsertest_base.cc(1225)] createFolderDownloads isInGuestMode: true [14182:14182:1030/191919.730913:ERROR:multi_user_window_manager_stub.cc(54)] Not implemented reached in virtual void MultiUserWindowManagerStub::AddObserver(MultiUserWindowManager::Observer *) [14182:14182:1030/191919.781599:ERROR:render_widget_host_view_aura.cc(1282)] Not implemented reached in virtual base::i18n::TextDirection content::RenderWidgetHostViewAura::GetTextDirection() const [14182:14182:1030/191919.963979:ERROR:layer_tree_host_impl.cc(3126)] Forcing zero-copy tile initialization as worker context is missing [14182:14182:1030/191919.999979:ERROR:remote_text_input_client.cc(115)] Not implemented reached in virtual ui::TextInputClient::FocusReason RemoteTextInputClient::GetFocusReason() const [14182:14182:1030/191920.000077:ERROR:remote_text_input_client.cc(200)] Not implemented reached in virtual bool RemoteTextInputClient::ShouldDoLearning() [14182:14182:1030/191920.000169:ERROR:remote_text_input_client.cc(176)] Not implemented reached in virtual void RemoteTextInputClient::EnsureCaretNotInRect(const gfx::Rect &) BrowserTestBase received signal: Terminated. Backtrace: #0 0x000000cdc4d1 in __interceptor_backtrace /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:4024:13 #1 0x0000169d0d0a in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:820:41 #2 0x0000187474b7 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:89:5 #3 0x000000d03f39 in SignalHandler(int) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:990:3 #4 0x7f9b52b17cb0 in killpg ??:? #5 0x7f9b52b17cb0 in ?? ??:0 #6 0x7f9b52bdf6d3 in epoll_wait ??:0:0 #7 0x000000cc5434 in __interceptor_epoll_wait /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:857:13 #8 0x00001a91c9c9 in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 #9 0x00001a90fbcb in event_base_loop ./../../base/third_party/libevent/event.c:512:9 #10 0x000016a27924 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 #11 0x0000167cb6f0 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 #12 0x000006817307 in GetNextMessage ./../../chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc:324:16 #13 0x000006817307 in file_manager::FileManagerBrowserTestBase::RunTestMessageLoop() ./../../chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc:1183:0 #14 0x000006816459 in file_manager::FileManagerBrowserTestBase::StartTest() ./../../chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc:1165:3 #15 0x000018743e5c in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:422:5 #16 0x000016ddf4e6 in Run ./../../base/callback.h:129:12 #17 0x000016ddf4e6 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1844:0 #18 0x000016ddab50 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1228:18 #19 0x000008276745 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:661:32 #20 0x00000d88be45 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:977:13 #21 0x00000f03dbcd in Run ./../../base/callback.h:129:12 #22 0x00000f03dbcd in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:0 #23 0x00000d88448b in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:911:25 #24 0x00000d898163 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:144:15 #25 0x00000d878793 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32 #26 0x0000152cc6eb in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:537:10 #27 0x0000152cc6eb in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:902:0 #28 0x000020c1914f in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:472:29 #29 0x0000152c37cf in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #30 0x000018742323 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:335:3 #31 0x000016c08ea7 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:283:20 #32 0x000009b55186 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #33 0x000009b55186 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2518:0 #34 0x000009b5921c in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2698:11 #35 0x000009b5ad0a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2816:28 #36 0x000009b93dc5 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5182:43 #37 0x000009b92698 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #38 0x000009b92698 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4791:0 #39 0x000016c81fa1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2333:46 #40 0x000016c81fa1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:294:0 #41 0x000016627ded in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:71:21 #42 0x0000187f79d6 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:647:31 #43 0x000016629536 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:182:10 #44 0x000016627ba1 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 #45 0x7f9b52b02f45 in __libc_start_main ??:0:0 #46 0x000000c9eaca in _start ??:0:0
,
Oct 31
KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDownloads_GuestMode looks flaky too for regular browser_tests
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/477fd905b7d3e2957badc3df57ebd0b5d82d3810 commit 477fd905b7d3e2957badc3df57ebd0b5d82d3810 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Wed Oct 31 18:13:08 2018 Disable a few more FilesAppBrowserTest on MSan Disable CreateNewFolder/FilesAppBrowserTest.Test/selectCreateFolderDownloads_GuestMode KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDownloads_GuestMode KeyboardOperations/FilesAppBrowserTest.Test/keyboardDeleteFolderDownloads_GuestMode due to flakiness under MSan. TBR=lucmult@chromium.org Bug: 899664 Change-Id: Ic39f71f6b07999ca39a6d58f6674d32ab002739c Reviewed-on: https://chromium-review.googlesource.com/c/1310502 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604332} [modify] https://crrev.com/477fd905b7d3e2957badc3df57ebd0b5d82d3810/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e29f20a6bd864465d2bbb3b9baf2ee34c798e16 commit 9e29f20a6bd864465d2bbb3b9baf2ee34c798e16 Author: Luciano Pacheco <lucmult@chromium.org> Date: Wed Oct 31 23:44:43 2018 Revert "Disable a few more FilesAppBrowserTest on MSan" This reverts commit 477fd905b7d3e2957badc3df57ebd0b5d82d3810. Reason for revert: I had already reverted that CLs that had caused flakiness to MSAN, it just takes a while for MSAN to pickup changes. It eventually picked up in this run: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9366 Bug: 899664 Original change's description: > Disable a few more FilesAppBrowserTest on MSan > > Disable > CreateNewFolder/FilesAppBrowserTest.Test/selectCreateFolderDownloads_GuestMode > KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDownloads_GuestMode > KeyboardOperations/FilesAppBrowserTest.Test/keyboardDeleteFolderDownloads_GuestMode > due to flakiness under MSan. > > TBR=lucmult@chromium.org > > Bug: 899664 > Change-Id: Ic39f71f6b07999ca39a6d58f6674d32ab002739c > Reviewed-on: https://chromium-review.googlesource.com/c/1310502 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604332} TBR=xiyuan@chromium.org,lucmult@chromium.org Change-Id: I1bb7400826d3143641d97d8eaaf44b69ccd4e6b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899664 Reviewed-on: https://chromium-review.googlesource.com/c/1312013 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604447} [modify] https://crrev.com/9e29f20a6bd864465d2bbb3b9baf2ee34c798e16/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Oct 31
Today I'll focus on reproducing this flakiness locally and fix this before trying to land that CL again. :-) I'll continue to watch this bot, because of the tests I just re-enabled in comment #17.
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38e83f2d147fddf9467a316a92e26f26a63458c8 commit 38e83f2d147fddf9467a316a92e26f26a63458c8 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Nov 01 23:06:16 2018 Wait until Files app is fully loaded Change setupAndWaitUntilReady function to wait until Files app is fully loaded. This intend to fix flaky tests where tests expect to have Files app loaded in Downloads folder, however EntryList |updateSubDirectories| method is being refactored to be asynchronous, which makes Downloads folder to delay its appearance. This change has had 4 successful runs in a row in crrev.com/c/1312185 (patchset 2 and 3). Re-enable test that was flaky on MSAN. Bug: 899664 Change-Id: Iedff85699c56f6cf8ac82d5ea27ef0ca54b7a641 Reviewed-on: https://chromium-review.googlesource.com/c/1313709 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604740} [modify] https://crrev.com/38e83f2d147fddf9467a316a92e26f26a63458c8/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/38e83f2d147fddf9467a316a92e26f26a63458c8/ui/file_manager/file_manager/foreground/js/directory_model.js [modify] https://crrev.com/38e83f2d147fddf9467a316a92e26f26a63458c8/ui/file_manager/integration_tests/file_manager/background.js
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/342faed0d2d2ba8237e033c0e386b4dfab7020bc commit 342faed0d2d2ba8237e033c0e386b4dfab7020bc Author: Luciano Pacheco <lucmult@chromium.org> Date: Fri Nov 02 00:46:46 2018 Refactor DirectoryTree part 2 of 2 This is part of a reverted CL crrev.com/c/1300993, this is the part that had caused flakiness on MSAN. Change EntryList |updateSubDirectories| method to read its content using FS API, which turns it into async. EntryList is used by MyFiles so Downloads folder appearance is delayed comparing to previous approach. Some tests expected Downloads to be readily available then they become flaky, crrev.com/c/1313709 fixes this for most tests. Fix unittest that started failing because it metadataModel was null. Bug: 899664 , 889511 Change-Id: If7cf4dea331938cb5919ef4a0ebaa73afaa2ec20 Reviewed-on: https://chromium-review.googlesource.com/c/1313711 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604779} [modify] https://crrev.com/342faed0d2d2ba8237e033c0e386b4dfab7020bc/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js [modify] https://crrev.com/342faed0d2d2ba8237e033c0e386b4dfab7020bc/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js
,
Nov 5
The change that made the tests flaky has been merged 2 days ago, I've just checked FilesApp tests on Flakiness dashboard [1] a few tests are still a bit flaky, but not as badly as before:
I'm disabling these 2 tests in MSAN and ASAN:
CreateNewFolder/FilesAppBrowserTest.Test/createFolderDownloads_GuestMode
CreateNewFolder/FilesAppBrowserTest.Test/selectCreateFolderDownloads_GuestMode
These 2 might be flaky, but not too badly yet, so I'm keeping them enabled for now:
KeyboardOperations/FilesAppBrowserTest.Test/keyboardDeleteFolderDownloads_GuestMode -> (ASAN only)
KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDownloads_GuestMode -> (ASAN only)
Metadata/FilesAppBrowserTest.Test/metadataDrive --- Improve test to account for the condition:
[29619:29619:1103/184130.896472:INFO:CONSOLE(0)] "[FAIL] [metadataDrive]: API Test Error in [metadataDrive]
Actual: 15
Expected: 14
Error
at extensions::test:243:18
at StepsRunner.<anonymous> (chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/file_manager/metadata.js:139:19)
at StepsRunner.<anonymous> (chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/file_manager/background.js:106:24)
at new Promise (<anonymous>)
at StepsRunner.<anonymous> (chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/file_manager/background.js:104:14)", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0)
OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatOneModeSingleFileDrive -- doesnt look related to MyFiles/Downloads changes
CopyBetweenWindows/FilesAppBrowserTest.Test/copyBetweenWindowsUsbToDrive_DriveFs -- just a infra failure
ShareAndManageDialog/FilesAppBrowserTest.Test/shareDirectoryDrive -- opens in Drive so shouldn't be related to MyFiles/Downloads changes.
[1] - https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=FilesAppBrowserTest
,
Nov 5
Ops, sent before finishing the edit: ... This test I will refactor it slightly to accept a range of values, because this isn't 100% precise measurement. Metadata/FilesAppBrowserTest.Test/metadataDrive --- Improve test to account for the condition. The following tests doesn't seem flaky due to my changes, so I'm not changing anyting on it: OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatOneModeSingleFileDrive -- doesnt look related to MyFiles/Downloads changes CopyBetweenWindows/FilesAppBrowserTest.Test/copyBetweenWindowsUsbToDrive_DriveFs -- just a infra failure ShareAndManageDialog/FilesAppBrowserTest.Test/shareDirectoryDrive -- opens in Drive so shouldn't be related to MyFiles/Downloads changes.
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/518057ec37deac71c0460211c73d86e052bf47d3 commit 518057ec37deac71c0460211c73d86e052bf47d3 Author: Luciano Pacheco <lucmult@chromium.org> Date: Mon Nov 05 03:43:39 2018 Disable tests on MSAN and ASAN These 2 tests are flaky on MSAN and ASAN, disabling it them until they get fixed. Bug: 899664 Change-Id: I0ee7b0fd58731f47b03637f21a55f27254ae576b Reviewed-on: https://chromium-review.googlesource.com/c/1317210 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#605238} [modify] https://crrev.com/518057ec37deac71c0460211c73d86e052bf47d3/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11d7305a72a5937c2659208c73fedbe876c69dd2 commit 11d7305a72a5937c2659208c73fedbe876c69dd2 Author: Luciano Pacheco <lucmult@chromium.org> Date: Mon Nov 05 22:58:04 2018 Fix equal1PercentageMargin function NOTE: This CL can introduce FLAKINESS, because the number of metadata call depends on multiple async calls. I'll watch the bots and update these tests accordingly. |equal1PercentageMargin| wasn't checking properly the 1% margin, because it was comparing to |desiredValue| instead of |value|, this was causing it to always return true. :-( Change this function to have ceil/floor so it accounts to at least 1 full unit for min and for max values. Changed it to log the values when it returns false which is helpful for debugging failing tests. Change |metadataLargeDrive| test to be more lenient for |fromCache| metadata calls, because calls to cached metadata are cheap we don't have to be too strict and running locally it flaked ranging from ~40 to < 70. Fix small typo. Bug: 899664 Change-Id: I6c6654684a5b341a3ac7378774cb6fe9b7affe4c Reviewed-on: https://chromium-review.googlesource.com/c/1317223 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#605505} [modify] https://crrev.com/11d7305a72a5937c2659208c73fedbe876c69dd2/ui/file_manager/integration_tests/file_manager/metadata.js
,
Nov 6
In guest mode ASAN, I see with logging [ RUN ] CreateNewFolder/FilesAppBrowserTest.Test/createFolderDownloads_GuestMode [68925:68925:1106/160758.532399:WARNING:user_policy_manager_factory_chromeos.cc(208)] No policy loaded for known non-enterprise user [68925:68925:1106/160758.646786:WARNING:easy_unlock_service_regular.cc(524)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false. [68925:68925:1106/160758.929082:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. [68925:68925:1106/160759.174991:WARNING:diagnosticsd_bridge.cc(90)] The diagnosticsd D-Bus service is unavailable [68925:68925:1106/160759.322287:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *) [68925:71249:1106/160759.767072:ERROR:service_manager_connection_impl.cc(315)] Can't create service multidevice_setup. No handler found. [68925:68925:1106/160800.486275:INFO:file_manager_browsertest_base.cc(1199)] FileManagerBrowserTest::StartTest createFolderDownloads_GuestMode [68925:68925:1106/160802.603223:INFO:file_manager_browsertest_base.cc(1263)] createFolderDownloads isInGuestMode: true [68925:68925:1106/160803.457926:INFO:CONSOLE(845)] "Cache database creating or upgrading.", source: chrome-extension://pmfjbimdmchhbnneeidfognadeopoehp/background_scripts.js (845) [68925:68925:1106/160803.966990:INFO:CONSOLE(5722)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5722) [68925:68925:1106/160804.039729:INFO:CONSOLE(5076)] "Waiting for the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5076) [68925:68925:1106/160804.096135:INFO:CONSOLE(5724)] "Volume list fetched with: 1 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5724) [68925:68925:1106/160804.096987:INFO:CONSOLE(5734)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5734) [68925:68925:1106/160804.097552:INFO:CONSOLE(6194)] "Requesting file system: downloads downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6194) [68925:68925:1106/160804.390360:INFO:CONSOLE(0)] "Uncaught (in promise) SecurityError: It was determined that certain files are unsafe for access within a Web application, or that too many calls are being made on file resources.", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0) [68925:68925:1106/160804.574947:INFO:CONSOLE(6244)] "File system obtained: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6244) [68925:68925:1106/160804.626198:INFO:CONSOLE(5738)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5738) [68925:68925:1106/160804.626739:INFO:CONSOLE(5742)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5742) [68925:68925:1106/160804.884121:INFO:CONSOLE(5073)] "Received the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5073) [68925:68925:1106/160804.885431:INFO:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source: (0) [68925:68925:1106/160805.015665:INFO:CONSOLE(0)] ":unresolved pseudo selector is deprecated and will be removed in M73, around March 2019. Please use :not(:defined) instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source: (0) [68925:68925:1106/160805.334461:INFO:CONSOLE(442)] "document.registerElement is deprecated and will be removed in M73, around March 2019. Please use window.customElements.define instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-micro-extracted.js (442) [68925:68925:1106/160809.637529:INFO:CONSOLE(2083)] "Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js (2083) [68925:68925:1106/160810.886465:INFO:CONSOLE(156)] "at /file_manager/background.js:379:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160815.148068:INFO:CONSOLE(156)] "at /file_manager/background.js:379:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160815.526065:INFO:CONSOLE(23992)] "changeDirectoryEntry: ", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js (23992) [68925:68925:1106/160816.445652:INFO:CONSOLE(43615)] "EntryListItem children loaded.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js (43615) [68925:68925:1106/160817.420365:INFO:CONSOLE(43615)] "EntryListItem children loaded.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js (43615) [68925:68925:1106/160817.775538:INFO:CONSOLE(43615)] "EntryListItem children loaded.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js (43615) [68925:68925:1106/160821.177738:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160824.075041:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160827.288132:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160830.148477:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160833.192953:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160836.277739:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160839.089241:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160842.136504:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160845.228018:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160848.131193:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160851.200415:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160854.240982:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160857.149587:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160900.272553:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160903.097883:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160906.291730:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160909.298111:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160912.288808:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160915.194784:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160918.098888:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160921.103505:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) [68925:68925:1106/160924.164732:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #directory-tree [entry-label="Downloads"] > .tree-children[expanded] is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156) BrowserTestBase received signal: Terminated. Backtrace: #38 0x5602725b86ea (/usr/local/google/home/noel/chrome/src/out/asan/browser_tests+0xa3b06e9) [71380:71380:1106/160926.251473:WARNING:x11_util.cc(1426)] X error received: serial 1299, error_code 9 (BadDrawable), request_code 62, minor_code 0 (Unknown) ... [1/1] CreateNewFolder/FilesAppBrowserTest.Test/createFolderDownloads_GuestMode (TIMED OUT)
,
Nov 6
The problem appear to be in the function expandRoot() https://cs.chromium.org/chromium/src/ui/file_manager/integration_tests/file_manager/create_new_folder.js?rcl=c03808e7d7d8d9e4c0b1350908c3352996f498d5&l=144 const expandIcon = selector + ' > .tree-row > .expand-icon'; Looks like the same problem folder_shortcuts.js had when expanding tree icons. See function expandTreeItem(appId, directory) therein and note its icon query const expandIcon = directory.treeItem + '> .tree-row[has-children=true] > .expand-icon'; https://cs.chromium.org/chromium/src/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js?rcl=c03808e7d7d8d9e4c0b1350908c3352996f498d5&l=82 Try that: the tree row must have children.
,
Nov 7
#50 was repro-ed with --gtest_repeat=50. Changing the directory tree selector to check for children when expanding the expand icon (see #26), and re-running with --gtest_repeat=50 => no more flake.
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e661fd779cae33bf2ddb1ceb8670950bcf7f4684 commit e661fd779cae33bf2ddb1ceb8670950bcf7f4684 Author: Noel Gordon <noel@chromium.org> Date: Wed Nov 07 01:03:38 2018 Wait for directory tree children before clicking the expand icon Similar to the issue 891197 fix, wait for the directory tree row attribute [has-children=true] before clicking the expand icon. Bug: 899664 Change-Id: I26d0f96feba85b6bd0cd9d03b76b438f1b1b7f0b Reviewed-on: https://chromium-review.googlesource.com/c/1321649 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#605903} [modify] https://crrev.com/e661fd779cae33bf2ddb1ceb8670950bcf7f4684/ui/file_manager/integration_tests/file_manager/create_new_folder.js
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1586d846c2a2081b3e47c7a51b989c5799b5502 commit a1586d846c2a2081b3e47c7a51b989c5799b5502 Author: Luciano Pacheco <lucmult@chromium.org> Date: Wed Nov 07 01:34:27 2018 Revert "Disable tests on MSAN and ASAN" This reverts commit 518057ec37deac71c0460211c73d86e052bf47d3. Reason for revert: crrev.com/c/1321649 should fix the flakiness, so let's re-enable these tests. Original change's description: > Disable tests on MSAN and ASAN > > These 2 tests are flaky on MSAN and ASAN, disabling it them until they > get fixed. > > Bug: 899664 > Change-Id: I0ee7b0fd58731f47b03637f21a55f27254ae576b > Reviewed-on: https://chromium-review.googlesource.com/c/1317210 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605238} TBR=noel@chromium.org,lucmult@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 899664 Change-Id: Iee08e4d5bf05c09aee00023717f1351b880585b6 Reviewed-on: https://chromium-review.googlesource.com/c/1322009 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#605920} [modify] https://crrev.com/a1586d846c2a2081b3e47c7a51b989c5799b5502/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/268a2cc7d528e44feee7eb8a14bd5cecf63bf7fd commit 268a2cc7d528e44feee7eb8a14bd5cecf63bf7fd Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Nov 08 02:03:54 2018 Files app: Remove debug logs These logs were added as part of debugging flakiness, which has been fixed, so removing the logs. Test: No change in behaviour. Bug: 899664 Change-Id: Ifb66c9beb6ab22bd1002dbda64dcbe461d5fb8e3 Reviewed-on: https://chromium-review.googlesource.com/c/1325269 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606285} [modify] https://crrev.com/268a2cc7d528e44feee7eb8a14bd5cecf63bf7fd/ui/file_manager/file_manager/foreground/js/directory_model.js [modify] https://crrev.com/268a2cc7d528e44feee7eb8a14bd5cecf63bf7fd/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
,
Nov 8
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by grunell@chromium.org
, Oct 29