New issue
Advanced search Search tips

Issue 899605 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 899586



Sign in to add a comment

Migrate video_JpegEncodeAccelerator to Tast

Project Member Reported by dstaessens@google.com, Oct 29

Issue description

The video_JpegEncodeAccelerator test is currently running on the autotest framework. This bug tracks migrating the test to the new Tast framework: go/tast.
 
Blocking: 899586
Cc: shenghao@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93c6800eb5f5333fbe2867f234ea3e6c75b9dc94

commit 93c6800eb5f5333fbe2867f234ea3e6c75b9dc94
Author: David Staessens <dstaessens@chromium.org>
Date: Wed Nov 14 23:53:01 2018

media/gpu: Improve jpeg HW encode tests, so they can be executed from Tast.

Fixed a bug that would prevent using absolute input file paths. This is required
by tast, since the test image data is uploaded to a custom directory.

Temporary files are generated, written to a temporary file, and read into memory
again. This unnecessary step has been removed. File operations introduce
additional points of failure, and it can be tricky to write to temporary files
when using the Tast framework. This also prevents files cluttering the temp
folder when not being cleaned up on crashes.

The encode output of generated images is now written to the current folder using
HxW_[black|white].jpg as output file name.

TEST=ran jpeg_encode_accelerator_unittest on eve

BUG= 899605 

Change-Id: Ie3f0e299ef85ce663586b4ba4c1177e84ec7a8ca
Reviewed-on: https://chromium-review.googlesource.com/c/1333011
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608176}
[modify] https://crrev.com/93c6800eb5f5333fbe2867f234ea3e6c75b9dc94/media/gpu/jpeg_encode_accelerator_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ced9d505b4ca32ab45cc680fe53d5cd795b18a72

commit ced9d505b4ca32ab45cc680fe53d5cd795b18a72
Author: David Staessens <dstaessens@chromium.org>
Date: Mon Nov 19 07:21:09 2018

tast-local-tests-cros: Add files used by the jpeg encode tests.

> File sizes:
bali_640x360_P420.yuv	345K

TEST=EncodeAccelJpeg on eve

BUG= chromium:899605 

Change-Id: I89db002026dd77101546aaf059127d65deeb0056
Reviewed-on: https://chromium-review.googlesource.com/1333100
Commit-Ready: David Staessens <dstaessens@chromium.org>
Tested-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/ced9d505b4ca32ab45cc680fe53d5cd795b18a72/chromeos-base/tast-local-tests-cros/tast-local-tests-cros-9999.ebuild
[modify] https://crrev.com/ced9d505b4ca32ab45cc680fe53d5cd795b18a72/chromeos-base/tast-local-tests-cros/Manifest
[modify] https://crrev.com/ced9d505b4ca32ab45cc680fe53d5cd795b18a72/chromeos-base/tast-local-tests-cros/files/external_data.conf

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/d3e4cd6fd8c64165ca5fc9b581e178779954bbc4

commit d3e4cd6fd8c64165ca5fc9b581e178779954bbc4
Author: David Staessens <dstaessens@chromium.org>
Date: Mon Nov 19 15:09:15 2018

video.EncodeAccelJPEG: Add JPEG HW encode accelerator tests to Tast.

TEST=EncodeAccelJPEG on eve

CQ-DEPEND=CL:1333100

BUG= chromium:899605 

Change-Id: I072abc4c77eecf2901f74c41331bcfd6738d94b3
Reviewed-on: https://chromium-review.googlesource.com/1333213
Commit-Ready: David Staessens <dstaessens@chromium.org>
Tested-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[add] https://crrev.com/d3e4cd6fd8c64165ca5fc9b581e178779954bbc4/src/chromiumos/tast/local/bundles/cros/video/encode_accel_jpeg.go

Components: OS>Kernel>Video
Status: Started (was: Assigned)
video.EncodeAccelJPEG is failing every time it runs; see e.g. http://stainless/browse/chromeos-autotest-results/260077853-chromeos-test/ .

sudo: /usr/local/libexec/chrome-binary-tests/jpeg_encode_accelerator_unittest: command not found

I think the problem is that http://cs/chromeos_public/src/third_party/chromiumos-overlay/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild doesn't install the test binary.

(Please consider setting up http://go/stainless-alert to get nightly notifications about failures in your tests.)
Thanks, derat@. We are aware of this issue.
The fix step is as follows.
1.) Build jpeg_encode_accelerator_unittest by chromeos-chrome for all boards
2.) Provide it by chrome-binary-test
3.) (For ARM boards) set autotest-capability

CQ+1 for 1.) CL. https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1344711
Thanks derat@! These issues should be fixed when crrev.com/c/1344711 and crrev.com/c/1347532 get submitted, but there still seem to be infrastructure issues.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d833c0e53dd46ac64015b3cc5b1dd586d620a26a

commit d833c0e53dd46ac64015b3cc5b1dd586d620a26a
Author: David Staessens <dstaessens@chromium.org>
Date: Tue Nov 27 23:19:54 2018

chromeos-chrome: Always build HW jpeg encode tests.

Currently the jpeg_encode_accelerator_unittest binary is only build for VAAPI
devices. As JPEG encode capability is currently being added to some V4l2
devices, this change makes sure the HW JPEG encode tests are build for all
devices.

TEST=EncodeAccelJPEG on eve and kevin

BUG= chromium:899605 

Change-Id: Ie9b58db82fdfe1da8adb6f99336e91d9943c088b
Reviewed-on: https://chromium-review.googlesource.com/1344711
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

[modify] https://crrev.com/d833c0e53dd46ac64015b3cc5b1dd586d620a26a/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/779468c6715abc0b257d28ecfbfb5f023e14367f

commit 779468c6715abc0b257d28ecfbfb5f023e14367f
Author: David Staessens <dstaessens@chromium.org>
Date: Thu Nov 29 20:11:19 2018

chromeos-chrome: Always deploy HW jpeg encode tests.

Currently the jpeg_encode_accelerator_unittest binary is only deployed on VAAPI
devices. As JPEG encode capability is currently being added to some V4l2
devices, this change makes sure the HW JPEG encode tests are deployed on all
devices.

TEST=EncodeAccelJPEG on nocturne and kevin

CQ-DEPEND=CL:1344711

BUG= chromium:899605 

Change-Id: I0d96c3b3647d06e6827bda1c82ac607d0482eca2
Reviewed-on: https://chromium-review.googlesource.com/1347532
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

[rename] https://crrev.com/779468c6715abc0b257d28ecfbfb5f023e14367f/chromeos-base/chrome-binary-tests/chrome-binary-tests-0.0.1-r3.ebuild
[modify] https://crrev.com/779468c6715abc0b257d28ecfbfb5f023e14367f/chromeos-base/chrome-binary-tests/chrome-binary-tests-0.0.1.ebuild

Status: Verified (was: Started)

Sign in to add a comment