Regression:Shadow of Export password Dialogue box is seen behind Exporting password Dialogue box.
Reported by
shruti.j...@etouch.net,
Oct 29
|
|||||
Issue descriptionChrome Version : 71.0.3578.27 (Official Build) d7850e07856a010c464bc7ea52e4ee10ca5965ce-refs/branch-heads/3578@{#361} 64 bit OS : MAC(10.13.1,10.13.6,10.14.1) Steps to reproduce: 1. Launch chrome and navigate to chrome://settings ,set font size to 'Very Large'. 2. Navigate to gmail.com ,Login with valid credentials and save passwords by clicking on key icon in omni box. 3. Navigate to chrome://settings/passwords and click on 'Export password' and export the password. 4. Observe Exporting password Dialogue box. Actual Result: Shadow of Export password Dialogue box is seen behind Exporting password Dialogue box. Expected Result :No such shadow should be seen of Export password Dialogue box is seen behind Exporting password Dialogue box. This is a regression issue broken in ‘M-69’ and will soon inform the bisect info: Good Build : 69.0.3447.0 Bad Build : 69.0.3448.0 Kindly refer the attached screen-cast. https://drive.google.com/open?id=1sSyotrNYMiOehuWUbA5TfvtNiHWh9_Fo Thank you..!
,
Oct 29
Update : bisect Info: You are probably looking for a change made after 563540 (known good), but no later than 563541 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/51cf2f38c2f2da519af711650c610fbecd9ea14c..681b16bff82f3512c953a2ef044f228bcf2770cb Suspect:https://chromium.googlesource.com/chromium/src/+/681b16bff82f3512c953a2ef044f228bcf2770cb @Esmael El-Moslimany:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Using per-revision script I got Esmael El-Moslimany as a suspect if scottchen is suspect kindly re-assign back . Thank you..!
,
Oct 31
,
Nov 7
Summarizing offline discussion. This is not really a regression. The two dialogs were always showing up stacked (one on top of each other). r563541 just made the bug more obvious since it caused the first dialog to not be fully occluded by the second dialog.
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bebcb3a6f6fa34969a69121f42c0347934de6294 commit bebcb3a6f6fa34969a69121f42c0347934de6294 Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu Nov 08 00:16:33 2018 Settings WebUI: password export dialog, remove other dialogs when opening new dialog Bug: 899602 Change-Id: I58371b62f9e810b25fa05e431db8e17b82ff0d10 Reviewed-on: https://chromium-review.googlesource.com/c/1308908 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#606238} [modify] https://crrev.com/bebcb3a6f6fa34969a69121f42c0347934de6294/chrome/browser/resources/settings/passwords_and_forms_page/password_manager_proxy.js [modify] https://crrev.com/bebcb3a6f6fa34969a69121f42c0347934de6294/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.html [modify] https://crrev.com/bebcb3a6f6fa34969a69121f42c0347934de6294/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.js [modify] https://crrev.com/bebcb3a6f6fa34969a69121f42c0347934de6294/chrome/test/data/webui/cr_elements/cr_dialog_test.js [modify] https://crrev.com/bebcb3a6f6fa34969a69121f42c0347934de6294/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js [modify] https://crrev.com/bebcb3a6f6fa34969a69121f42c0347934de6294/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
,
Nov 8
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by battre@google.com
, Oct 29Owner: scottchen@chromium.org