New issue
Advanced search Search tips

Issue 899601 link

Starred by 2 users
Status: Fixed
Owner:
pbos@chromium.org
Closed: Nov 1
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 899996



Sign in to add a comment

Regression: Focus does not stay on bubble and it gets closed unexpectedly.

Reported by sanyam.g...@etouch.net, Oct 29 
Chrome Version : 72.0.3594.0 (Official Build)  Revision	93915459c3f57ee27505ba35fcc13d784f89abf6-refs/branch-heads/3594@{#1} (64-bit)
OS : Windows(7, 8, 8.1 ,10), Mac(10.13.1, 10.13.6, 10.14.1), Linux (14.04 LTS)

Steps to reproduce:
1. Launch chrome, click on bookmark icon to open the bubble.
2. Press tab key to traverse the focus till it reaches last option on the bubble.
4. Again press tab once and observe.

Actual Result  : Focus does not stay on bubble and it gets closed unexpectedly.
Expected Result: Focus should stay on bubble.

This is a regression issue, broken in 'M-72', and will soon update bisect info:
Good Build: 72.0.3591.0 (Revision: 602532)
Bad Build : 72.0.3592.0 (Revision: 602946)

Note:
Issue is seen for all bubbles (like permission, bookmark, translate...etc. )
Actual_Result.mov
925 KB View Download
Expected_Result.mov
1.7 MB View Download

Comment 1 by sanyam.g...@etouch.net, Oct 29

Labels: hasbisect
Owner: pbos@chromium.org
Status: Assigned (was: Unconfirmed)
Upadte:

Note: 
1. For bookmark overlay, focus does not traverse to 'Turn on Sync' and gets closed before that.
2. Providing suspect through chromium bisect. 
3. Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect" error message, Tried on other machines but still getting the same error

You are probably looking for a change made after 602564 (known good), but no later than 602572 (first known bad).
CHANGE-LOG URL:

https://chromium.googlesource.com/chromium/src/+log/156cf965c7e1544ab17531b129953d9e99b6b80b..da2a0e0e0d588ef2ef20b00c6a7ccda01a3f79b8

Suspect: r602568 ?

@Peter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You..!!

Comment 2 by pbos@chromium.org, Oct 31

Blocking: 899996

Comment 3 by robliao@google.com, Nov 1

Labels: Hotlist-DesktopUIConsider
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/211cdf116338d89f59714f9e1d4104bc28ef809d

commit 211cdf116338d89f59714f9e1d4104bc28ef809d
Author: Peter Boström <pbos@chromium.org>
Date: Thu Nov 01 00:37:54 2018

Keep focus inside BubbleDialogDelegateView

Removes Widget::SetFocusTraversableParent* calls since we don't want
focus to escape bubble dialogs once they get here. There are several
bubbles that close once focus escapes.

We still set kAnchoredDialogKey of the anchor view to make sure that
focus can move into attached dialogs (this makes them keyboard
accessible).

Bug:  chromium:899601 ,  chromium:899996 
Change-Id: Idc5d60c2f41ae20a343324ae75b0fd304f273c94
Reviewed-on: https://chromium-review.googlesource.com/c/1311090
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604464}
[modify] https://crrev.com/211cdf116338d89f59714f9e1d4104bc28ef809d/ui/views/bubble/bubble_dialog_delegate_view.cc
[modify] https://crrev.com/211cdf116338d89f59714f9e1d4104bc28ef809d/ui/views/bubble/bubble_dialog_delegate_view.h
[modify] https://crrev.com/211cdf116338d89f59714f9e1d4104bc28ef809d/ui/views/focus/focus_manager_unittest.cc

Comment 5 by pbos@chromium.org, Nov 1

Status: Fixed (was: Assigned)
Focus should stay inside the bubble now, please verify. Thanks!
►

Sign in to add a comment