-canGoBack, -goBack -canGoForward, -goForward -usesDesktopUserAgent -reloadWithUserAgentType -loadFinished all these methods are of tab and used by BVC , inline inside BVC.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4bdb95bdc1bb947edde7b4b34085bd7992a8a62 commit a4bdb95bdc1bb947edde7b4b34085bd7992a8a62 Author: mrefaat <mrefaat@chromium.org> Date: Tue Dec 04 18:36:10 2018 Remove tab's loadFinished method and inline usages Bug: 899598 , 899785 Change-Id: I77c0eea061d38995f443e0d725548f9964ec9680 Reviewed-on: https://chromium-review.googlesource.com/c/1359481 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#613611} [modify] https://crrev.com/a4bdb95bdc1bb947edde7b4b34085bd7992a8a62/ios/chrome/browser/prerender/preload_controller.mm [modify] https://crrev.com/a4bdb95bdc1bb947edde7b4b34085bd7992a8a62/ios/chrome/browser/tabs/tab.h [modify] https://crrev.com/a4bdb95bdc1bb947edde7b4b34085bd7992a8a62/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/a4bdb95bdc1bb947edde7b4b34085bd7992a8a62/ios/chrome/browser/tabs/tab_model_selected_tab_observer.mm [modify] https://crrev.com/a4bdb95bdc1bb947edde7b4b34085bd7992a8a62/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66ba16bc726d06b27ec49f9e1689ded3e1dfa869 commit 66ba16bc726d06b27ec49f9e1689ded3e1dfa869 Author: mrefaat <mrefaat@chromium.org> Date: Wed Dec 05 22:57:11 2018 Inline usesDesktopUserAgent usage in BVC and remove it from Tab. Bug: 899598 Change-Id: Icab18774b1687c4b041704059dc0df84afea6fbd Reviewed-on: https://chromium-review.googlesource.com/c/1363969 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#614155} [modify] https://crrev.com/66ba16bc726d06b27ec49f9e1689ded3e1dfa869/ios/chrome/browser/tabs/tab.h [modify] https://crrev.com/66ba16bc726d06b27ec49f9e1689ded3e1dfa869/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/66ba16bc726d06b27ec49f9e1689ded3e1dfa869/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7213875a758847fb681742f9a8a1978b203e89fc commit 7213875a758847fb681742f9a8a1978b203e89fc Author: mrefaat <mrefaat@chromium.org> Date: Fri Dec 07 21:38:16 2018 Inline reloadWithUserAgentType usage in BVC and remove it from Tab Bug: 899598 Change-Id: I6bd615d066ed7d6401da2214590b4b35002ff869 Reviewed-on: https://chromium-review.googlesource.com/c/1364068 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#614821} [modify] https://crrev.com/7213875a758847fb681742f9a8a1978b203e89fc/ios/chrome/browser/tabs/tab.h [modify] https://crrev.com/7213875a758847fb681742f9a8a1978b203e89fc/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/7213875a758847fb681742f9a8a1978b203e89fc/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87a858ece115341231f5796c6ecf03352d282b00 commit 87a858ece115341231f5796c6ecf03352d282b00 Author: mrefaat <mrefaat@chromium.org> Date: Mon Dec 10 21:15:31 2018 Inline the usage of back/forward navigationManger methods in BVC methods: canGoForward, canGoBack, goForward, goBack can be directly used from NavigationManger which is accessible from the webstate Bug: 899598 Change-Id: Id9afd8b1d79e5f1c28d0423717c007cadddc4972 Reviewed-on: https://chromium-review.googlesource.com/c/1367873 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#615253} [modify] https://crrev.com/87a858ece115341231f5796c6ecf03352d282b00/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84fc8828939c77deb9a75710040438e84a58c8aa commit 84fc8828939c77deb9a75710040438e84a58c8aa Author: mrefaat <mrefaat@chromium.org> Date: Thu Dec 20 18:47:00 2018 Create web_navigation_util and use it for navigation logic that depend on the webState. Change SideSwipeController & BrowserViewController to use it instead of tab methods. Also Remove the existing tab_util and move the CreateWebLoadParams to the navigation utils. Bug: 899598 , 899423, 915955 Change-Id: I811e358fbd669c278855bf79f718274cc8cac712 Reviewed-on: https://chromium-review.googlesource.com/c/1380559 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#618279} [modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/app/BUILD.gn [modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/app/main_controller.mm [modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/tabs/BUILD.gn [delete] https://crrev.com/c33c286e565fc89faaa492178a3b4ba7cf666ae8/ios/chrome/browser/tabs/tab_util.h [delete] https://crrev.com/c33c286e565fc89faaa492178a3b4ba7cf666ae8/ios/chrome/browser/tabs/tab_util_unittest.mm [modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm [modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/web/BUILD.gn [add] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/web/web_navigation_util.h [rename] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/web/web_navigation_util.mm [add] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/web/web_navigation_util_unittest.mm [modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/web/public/test/fakes/test_navigation_manager.mm
I'm seeing timeouts with the test case ReloadWithUserAgentType. Can you PTAL? https://logs.chromium.org/logs/chrome/bb/internal.bling.main/ipad11-device-x64/9094/+/recipes/steps/ios_web_inttests__iPad_6th_Gen_iOS_11.4.1__on_iOS-11.4.1/0/stdout
the timeouts was discussed offline at the time of reporting, and it's not related to these changes.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cd609afcf8825991fadd04feeae2baaaa1fc9fb commit 4cd609afcf8825991fadd04feeae2baaaa1fc9fb Author: mrefaat <mrefaat@chromium.org> Date: Tue Jan 22 18:34:47 2019 Remove Tab's navigation methods Removes: goBack, canGoBack, goForward and canGoForward Bug: 661664, 899598 , 899423 Change-Id: Ia1b781d6827ffc50ca2fe18c513e67d7f4ac2b15 Reviewed-on: https://chromium-review.googlesource.com/c/1372174 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#624844} [modify] https://crrev.com/4cd609afcf8825991fadd04feeae2baaaa1fc9fb/ios/chrome/browser/tabs/tab.h [modify] https://crrev.com/4cd609afcf8825991fadd04feeae2baaaa1fc9fb/ios/chrome/browser/tabs/tab.mm
Comment 1 by mrefaat@chromium.org
, Oct 29