Issue metadata
Sign in to add a comment
|
No history swipe animations on macOS 10.12 |
||||||||||||||||||||||
Issue descriptionChrome Version: 71.0.3578.20 (current beta) OS: macOS 10.12.6 What steps will reproduce the problem? (1) Use a Mac with an external Magic Trackpad. Ensure System Prefs > Trackpad > More Gestures > Swipe between pages is ON (2) Open Chrome and navigate to wikipedia.org (3) Click on a link (4) Click on another link (5) Two-finger swipe on the trackpad to go backwards (6) Two-finger swipe on the trackpad to go forwards What is the expected result? When swiping back/forward in steps 5 and 6, a black half-circle with an arrow should be displayed over the page, indicating the swipe direction for the gesture navigation. What happens instead? No history swipe animation is seen. This is happening on the current beta (71.0.3578.20) on my iMac but not on my MacBook Pro at the same version. Bisect results: You are probably looking for a change made after 594143 (known good), but no later than 594163 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/e5087536adb709a5bbb63b1f619a2dc77cf95f30..df010d520f93016910d985021366519b1406d9c8 Guessing it's probably one of: 42e84a4 - [Mac] Delete ViewsCompositorSuperview. Shouldn't change behavior. dd7c59f - RemoteMacViews: Break views dependencies of DragDropClientMac GPU info: GPU0 VENDOR = 0x10de, DEVICE= 0x0fe0 *ACTIVE* GPU1 VENDOR = 0x8086, DEVICE= 0x0152 Optimus true AMD switchable false Driver vendor NVIDIA Driver version 10.17.5 Driver date GPU CUDA compute capability major version 0 Pixel shader version 4.10 Vertex shader version 4.10 Max. MSAA samples 8 Machine model name iMac Machine model version 13.2 GL_VENDOR NVIDIA Corporation GL_RENDERER NVIDIA GeForce GTX 660M OpenGL Engine GL_VERSION 4.1 NVIDIA-10.17.5 355.10.05.45f01
,
Oct 27
Yeah, when filing I was not sure if it was an issue with the trackpad or the GPU. But the gesture does cause a navigation to happen, just with no visual feedback, so it seems more likely to be the former. Attached is the about:gpu from the iMac.
,
Oct 29
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Oct 29
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Oct 29
Doesn't seem exclusively external trackpad-related. I attached a Magic Trackpad to my MacPro 5,1 and I do see the swipe animation. GPU info from that machine: GPU0 VENDOR = 0x1002 [ATI Technologies Inc.], DEVICE= 0x68b8 [ATI Radeon HD 5770 OpenGL Engine] *ACTIVE* Optimus false AMD switchable false Driver vendor ATI Driver version 1.68.20 Driver date GPU CUDA compute capability major version 0 Pixel shader version 4.10 Vertex shader version 4.10 Max. MSAA samples 8 Machine model name MacPro Machine model version 5.1 GL_VENDOR ATI Technologies Inc. GL_RENDERER ATI Radeon HD 5770 OpenGL Engine GL_VERSION 4.1 ATI-1.68.20
,
Oct 30
Robert and I have the same hardware at home, so I tested this also. I _do_ see history swipe animations. I’m running 10.13.6, while the original report is from 10.12.6. My specs: iMac (27-inch, Late 2012) - iMac13,2 NVIDIA GeForce GTX 680MX 2048 MBa macOS High Sierra 10.13.6 (17G65) Google Chrome 71.0.3578.20 (Official Build) beta (64-bit) From chrome://gpu GPU0 VENDOR = 0x10de, DEVICE= 0x11a3 *ACTIVE* GPU1 VENDOR = 0x8086, DEVICE= 0x0162 Optimus true AMD switchable false Driver vendor NVIDIA Driver version 10.32.0 Driver date GPU CUDA compute capability major version 0 Pixel shader version 4.10 Vertex shader version 4.10 Max. MSAA samples 8 Machine model name iMac Machine model version 13.2 GL_VENDOR NVIDIA Corporation GL_RENDERER NVIDIA GeForce GTX 680MX OpenGL Engine GL_VERSION 4.1 NVIDIA-10.32.0 355.11.10.10.40.102
,
Oct 31
The issue may be 10.12-specific. I tested on the litterbox trashcan on 10.12.6 (GPU info below) and didn't see history swipe animations either: GPU0 VENDOR = 0x1002, DEVICE= 0x679e *ACTIVE* GPU1 VENDOR = 0x1002, DEVICE= 0x679e Optimus false AMD switchable false Driver vendor ATI Driver version 1.51.8 Driver date GPU CUDA compute capability major version 0 Pixel shader version 4.10 Vertex shader version 4.10 Max. MSAA samples 8 Machine model name MacPro Machine model version 6.1 GL_VENDOR ATI Technologies Inc. GL_RENDERER AMD Radeon HD - FirePro D500 OpenGL Engine GL_VERSION 4.1 ATI-1.51.8
,
Nov 1
I upgraded my iMac to 10.14.1 and I now see the history swipe animations, so this does seem to be 10.12 specific.
,
Nov 2
Friendly ping! Could you please provide any update on this issue as it has been marked as a stable blocker. Thank You!
,
Nov 5
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Nov 8
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Nov 13
Friendly ping to look into this issue and to provide further update on this issue as it has been marked as a stable blocker. Thanks!
,
Nov 13
Reminder M71 Stable is approaching VERY soon. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure any planned work will be tested in Beta and verified before the Stable date. Thank you. Requesting to take a look at M71 blockers ASAP due to upcoming Thanksgiving holidays next week.
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ab144369afb2e7090803bdcec097d216fec4948 commit 8ab144369afb2e7090803bdcec097d216fec4948 Author: Sidney San Martín <sdy@chromium.org> Date: Wed Nov 14 22:07:16 2018 [Mac] Fix hidden NSViews by bringing back a dedicated compositor view. Until macOS 10.13, the relative ordering of a view's subviews' layers and unassociated sublayers is undefined, so view layers can end up hidden behind the compositor layer. See: https://developer.apple.com/library/archive/releasenotes/AppKit/RN-AppKit/index.html#10_13Layer-backed%20Views This change re-adds a dedicated compositor view, but with less plumbing than what was removed in r594160. Bug: 865901 , 899499 Change-Id: Ibbec83da2e8785e06522008dfc2d9eab7ca43bf9 Reviewed-on: https://chromium-review.googlesource.com/c/1334290 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#608139} [modify] https://crrev.com/8ab144369afb2e7090803bdcec097d216fec4948/ui/views/widget/native_widget_mac_unittest.mm [modify] https://crrev.com/8ab144369afb2e7090803bdcec097d216fec4948/ui/views_bridge_mac/bridged_native_widget_impl.mm
,
Nov 14
,
Nov 15
Reminder M71 Stable is approaching VERY soon. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure any planned work will be tested in Beta and verified before the Stable date. Thank you. Requesting to take a look at M71 blockers ASAP due to upcoming Thanksgiving holidays next week.
,
Nov 15
This should be fixed. rsesek@, could you verify when you have a chance? I may also verify on a litterbox machine.
,
Nov 15
I verified this fix in Canary on a MacBook Pro running 10.12.
,
Nov 15
Approving merge to M71 branch 3578 based on comment #18. Please merge ASAP. Thank you.
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/549a8efa2657a419495c00d285c974b2e27adca8 commit 549a8efa2657a419495c00d285c974b2e27adca8 Author: Sidney San Martín <sdy@chromium.org> Date: Thu Nov 15 21:46:37 2018 [Mac] Fix hidden NSViews by bringing back a dedicated compositor view. Until macOS 10.13, the relative ordering of a view's subviews' layers and unassociated sublayers is undefined, so view layers can end up hidden behind the compositor layer. See: https://developer.apple.com/library/archive/releasenotes/AppKit/RN-AppKit/index.html#10_13Layer-backed%20Views This change re-adds a dedicated compositor view, but with less plumbing than what was removed in r594160. (cherry picked from commit 8ab144369afb2e7090803bdcec097d216fec4948) Bug: 865901 , 899499 Change-Id: Ibbec83da2e8785e06522008dfc2d9eab7ca43bf9 Reviewed-on: https://chromium-review.googlesource.com/c/1334290 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#608139} Reviewed-on: https://chromium-review.googlesource.com/c/1338460 Reviewed-by: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#705} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/549a8efa2657a419495c00d285c974b2e27adca8/ui/views/widget/native_widget_mac_unittest.mm [modify] https://crrev.com/549a8efa2657a419495c00d285c974b2e27adca8/ui/views_bridge_mac/bridged_native_widget_impl.mm
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/549a8efa2657a419495c00d285c974b2e27adca8 Commit: 549a8efa2657a419495c00d285c974b2e27adca8 Author: sdy@chromium.org Commiter: sdy@chromium.org Date: 2018-11-15 21:46:37 +0000 UTC [Mac] Fix hidden NSViews by bringing back a dedicated compositor view. Until macOS 10.13, the relative ordering of a view's subviews' layers and unassociated sublayers is undefined, so view layers can end up hidden behind the compositor layer. See: https://developer.apple.com/library/archive/releasenotes/AppKit/RN-AppKit/index.html#10_13Layer-backed%20Views This change re-adds a dedicated compositor view, but with less plumbing than what was removed in r594160. (cherry picked from commit 8ab144369afb2e7090803bdcec097d216fec4948) Bug: 865901 , 899499 Change-Id: Ibbec83da2e8785e06522008dfc2d9eab7ca43bf9 Reviewed-on: https://chromium-review.googlesource.com/c/1334290 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#608139} Reviewed-on: https://chromium-review.googlesource.com/c/1338460 Reviewed-by: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#705} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 16
Issue 905377 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ccameron@chromium.org
, Oct 27