Issue metadata
Sign in to add a comment
|
New tab button looks and works incorrectly when top-chrome-md flag is set to Normal or Hybrid
Reported by
alvinhoc...@gmail.com,
Oct 27
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.20 Safari/537.36 Steps to reproduce the problem: 1. Visit chrome://flags 2. Set #top-chrome-md (UI Layout for the browser's top chrome) to Normal or Hybrid 3. Restart Chrome What is the expected behavior? New tab button looks and works normal What went wrong? New tab button is a mess Did this work before? Yes Some Chrome 70 beta versions Chrome version: 71.0.3578.20 Channel: beta OS Version: 10.0 Flash Version:
,
Oct 29
Thanks for filling the issue... As per comment #0, the issue seems to be related to Issue 888304 , Hence CC'ing Dev (pkasting@chromium.org) for further inputs on it. Thanks..!
,
Oct 29
Yes, I need to merge the rest of the pre-refresh removal to the 71 branch so we're not in this half-removed state.
,
Oct 30
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone. All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 30
,
Nov 1
,
Nov 1
,
Nov 1
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 1
,
Nov 1
,
Nov 1
Pls provide CL to merge and comment on merge safety. Thank you.
,
Nov 1
I think we should merge this change: https://chromium-review.googlesource.com/c/chromium/src/+/1285082 This basically removes access to the old modes. We could also merge these two to actually remove the functionality behind those modes: https://chromium-review.googlesource.com/c/chromium/src/+/1278472 https://chromium-review.googlesource.com/c/chromium/src/+/1287929 However, I think if users can't trigger the modes, then it doesn't matter whether they work in code. So I think there's no practical value to merging these. And we could merge these changes to kill #top-chrome-md altogether: https://chromium-review.googlesource.com/c/chromium/src/+/1297582 https://chromium-review.googlesource.com/c/chromium/src/+/1300109 https://chromium-review.googlesource.com/c/chromium/src/+/1298498 This might make users less confused/frustrated. However, I suspect we also have to take a number of dependencies if we want these to merge cleanly, and the risk is too high. So I would just merge the first change.
,
Nov 1
Thank you pkasting@. Approving merge to M71 branch 3578 for first change (https://chromium-review.googlesource.com/c/chromium/src/+/1285082) based on comment #12.
,
Nov 2
,
Nov 5
This was hopefully merged in https://chromium-review.googlesource.com/c/chromium/src/+/1316097 . Can someone retest? If not I can do it on Wednesday.
,
Nov 5
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 6
Pls merge your change to M71 branch 3578 ASAP so we can pick it up for this week beta release. Thank you.
,
Nov 8
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Nov 8
"UI Layout for the browser's top chrome" flag isn't present on Chrome Canary 72.0.3605.0 which can be considered as Verified. The Cl from comment#16 was made into M71 branch as per https://storage.googleapis.com/chromium-find-releases-static/06b.html#06b383969bc77710e075aa443a0fe263ef6e2010. But later got reverted due to through "https://chromium.googlesource.com/chromium/src/+/1a00072b7f6b9f86f802412f4823333305bad399" since it was "Breaking official bots. And also no bug number on the CL"(Thank you Robert for pointing to the CL)
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac4b45b06f269de4da00911995abb98202512b93 commit ac4b45b06f269de4da00911995abb98202512b93 Author: Peter Kasting <pkasting@chromium.org> Date: Thu Nov 08 19:04:56 2018 Remove pre-refresh code from c/b/ui/views/location_bar/. To eliminate BackgroundWith1PxBorder and ensure the rounded omnibox frame's cutout stays in sync with the actual location bar shape, the rounded frame now uses the location bar's Background creator directly. This required adding blend mode support to the solid round rect painter. While investigating AA artifacts going this route, I discovered that the current code has a (very hard to see) bug where AA artifacts show through in incognito mode. This patch fixes those artifacts by disabling AA in kSrc mode, where it doesn't make sense anyway. Bug: 899483 , 901788 Change-Id: Ifa46120490c7a6212308bf78c46fc9df052551fc Reviewed-on: https://chromium-review.googlesource.com/c/1278472 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600232}(cherry picked from commit ef3f2030133c44296e22ac89b7e8952c4533e97a) Reviewed-on: https://chromium-review.googlesource.com/c/1327410 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#581} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/3fceb095e0dc78212cf2eef38c8eb79c34da8caa/chrome/browser/ui/views/chrome_platform_style.cc [delete] https://crrev.com/3fceb095e0dc78212cf2eef38c8eb79c34da8caa/chrome/browser/ui/views/chrome_platform_style.h [delete] https://crrev.com/3fceb095e0dc78212cf2eef38c8eb79c34da8caa/chrome/browser/ui/views/chrome_platform_style_mac.mm [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/find_bar_host.cc [delete] https://crrev.com/3fceb095e0dc78212cf2eef38c8eb79c34da8caa/chrome/browser/ui/views/location_bar/background_with_1_px_border.cc [delete] https://crrev.com/3fceb095e0dc78212cf2eef38c8eb79c34da8caa/chrome/browser/ui/views/location_bar/background_with_1_px_border.h [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/location_bar/keyword_hint_view.cc [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/location_bar/location_icon_view.cc [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/location_bar/selected_keyword_view.cc [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/omnibox/omnibox_tab_switch_button.cc [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.h [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/page_action/page_action_icon_view.cc [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/chrome/browser/ui/views/toolbar/toolbar_view.h [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/ui/views/painter.cc [modify] https://crrev.com/ac4b45b06f269de4da00911995abb98202512b93/ui/views/painter.h
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac4b45b06f269de4da00911995abb98202512b93 Commit: ac4b45b06f269de4da00911995abb98202512b93 Author: pkasting@chromium.org Commiter: pkasting@chromium.org Date: 2018-11-08 19:04:56 +0000 UTC Remove pre-refresh code from c/b/ui/views/location_bar/. To eliminate BackgroundWith1PxBorder and ensure the rounded omnibox frame's cutout stays in sync with the actual location bar shape, the rounded frame now uses the location bar's Background creator directly. This required adding blend mode support to the solid round rect painter. While investigating AA artifacts going this route, I discovered that the current code has a (very hard to see) bug where AA artifacts show through in incognito mode. This patch fixes those artifacts by disabling AA in kSrc mode, where it doesn't make sense anyway. Bug: 899483 , 901788 Change-Id: Ifa46120490c7a6212308bf78c46fc9df052551fc Reviewed-on: https://chromium-review.googlesource.com/c/1278472 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600232}(cherry picked from commit ef3f2030133c44296e22ac89b7e8952c4533e97a) Reviewed-on: https://chromium-review.googlesource.com/c/1327410 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#581} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/029a95cf3bdbb35d570b6c73ccf56044f5139c2d commit 029a95cf3bdbb35d570b6c73ccf56044f5139c2d Author: Peter Kasting <pkasting@chromium.org> Date: Thu Nov 08 19:39:41 2018 Add A Suite of Tests to MaterialDesignController This provides more API coverage to the MaterialDesignController. BUG= 899483 , 901788 TBR=robliao@chromium.org, sky@chromium.org base/test MaterialDesignController test changes. (cherry picked from commit dee80a65ef2abe363c5cf67e026b09cce089cc0f) Change-Id: I3898ceb03e3aa7a4096d22aa059720b3ae368858 Reviewed-on: https://chromium-review.googlesource.com/c/1289991 Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601241} Reviewed-on: https://chromium-review.googlesource.com/c/1327207 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#585} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/029a95cf3bdbb35d570b6c73ccf56044f5139c2d/ui/base/material_design/material_design_controller_unittest.cc [modify] https://crrev.com/029a95cf3bdbb35d570b6c73ccf56044f5139c2d/ui/base/test/material_design_controller_test_api.cc [modify] https://crrev.com/029a95cf3bdbb35d570b6c73ccf56044f5139c2d/ui/base/test/material_design_controller_test_api.h
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/029a95cf3bdbb35d570b6c73ccf56044f5139c2d Commit: 029a95cf3bdbb35d570b6c73ccf56044f5139c2d Author: pkasting@chromium.org Commiter: pkasting@chromium.org Date: 2018-11-08 19:39:41 +0000 UTC Add A Suite of Tests to MaterialDesignController This provides more API coverage to the MaterialDesignController. BUG= 899483 , 901788 TBR=robliao@chromium.org, sky@chromium.org base/test MaterialDesignController test changes. (cherry picked from commit dee80a65ef2abe363c5cf67e026b09cce089cc0f) Change-Id: I3898ceb03e3aa7a4096d22aa059720b3ae368858 Reviewed-on: https://chromium-review.googlesource.com/c/1289991 Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601241} Reviewed-on: https://chromium-review.googlesource.com/c/1327207 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#585} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95400986f35c836a45608648c94070872b759a69 commit 95400986f35c836a45608648c94070872b759a69 Author: Peter Kasting <pkasting@chromium.org> Date: Thu Nov 08 20:29:28 2018 Remove most remaining pre-refresh code. At this point, normal/hybrid should behave identically to refresh, and touchable identically to touchable refresh. TBR=pkasting@chromium.org (cherry picked from commit 788d3d6f0076dc38304b5ca6b9ad99c8fdaefc78) Bug: 899483 , 901788 Change-Id: I616e35e50a95d467c361bc40eacbb738a3368665 TBR: nektar Reviewed-on: https://chromium-review.googlesource.com/c/1287929 Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601401} Reviewed-on: https://chromium-review.googlesource.com/c/1327209 Cr-Commit-Position: refs/branch-heads/3578@{#586} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/themes/theme_properties.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/themes/theme_properties.h [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/themes/theme_service.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/themes/theme_service_browsertest.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/themes/theme_service_unittest.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/layout_constants.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/layout_constants.h [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/views/chrome_layout_provider.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/views/location_bar/location_bar_layout.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/views/location_bar/location_bar_layout.h [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/views/page_action/page_action_icon_view.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/views/profiles/profile_chooser_view.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/views/tabs/tab_strip.h [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/views/tabs/tab_strip_unittest.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/views/toolbar/browser_actions_container.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/ui/base/material_design/material_design_controller.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/ui/base/material_design/material_design_controller.h [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/ui/base/material_design/material_design_controller_unittest.cc [modify] https://crrev.com/95400986f35c836a45608648c94070872b759a69/ui/views/controls/button/md_text_button.cc
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95400986f35c836a45608648c94070872b759a69 Commit: 95400986f35c836a45608648c94070872b759a69 Author: pkasting@chromium.org Commiter: pkasting@chromium.org Date: 2018-11-08 20:29:28 +0000 UTC Remove most remaining pre-refresh code. At this point, normal/hybrid should behave identically to refresh, and touchable identically to touchable refresh. TBR=pkasting@chromium.org (cherry picked from commit 788d3d6f0076dc38304b5ca6b9ad99c8fdaefc78) Bug: 899483 , 901788 Change-Id: I616e35e50a95d467c361bc40eacbb738a3368665 TBR: nektar Reviewed-on: https://chromium-review.googlesource.com/c/1287929 Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601401} Reviewed-on: https://chromium-review.googlesource.com/c/1327209 Cr-Commit-Position: refs/branch-heads/3578@{#586} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/027174c8d187ea7feeee16c822b3201704957894 commit 027174c8d187ea7feeee16c822b3201704957894 Author: Peter Kasting <pkasting@chromium.org> Date: Thu Nov 08 20:50:29 2018 Remove pre-Refresh MD modes from top-chrome-md With Refresh launched we no longer need to support pre-Refresh modes. This code is being cleaned up, so removing them from chrome://flags prevents them from being used in the wild. TBR=sky@chromium.org (cherry picked from commit 06b383969bc77710e075aa443a0fe263ef6e2010) Bug: 899483 , 901788 Change-Id: I62dcff14b13874c2c2f11440197713c021abb1e9 Reviewed-on: https://chromium-review.googlesource.com/c/1285082 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601735} Reviewed-on: https://chromium-review.googlesource.com/c/1327212 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#587} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/027174c8d187ea7feeee16c822b3201704957894/chrome/browser/about_flags.cc [modify] https://crrev.com/027174c8d187ea7feeee16c822b3201704957894/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/027174c8d187ea7feeee16c822b3201704957894/chrome/browser/ui/views/location_bar/location_bar_view_browsertest.cc [modify] https://crrev.com/027174c8d187ea7feeee16c822b3201704957894/ui/base/material_design/material_design_controller.cc [modify] https://crrev.com/027174c8d187ea7feeee16c822b3201704957894/ui/base/ui_base_switches.cc [modify] https://crrev.com/027174c8d187ea7feeee16c822b3201704957894/ui/base/ui_base_switches.h [modify] https://crrev.com/027174c8d187ea7feeee16c822b3201704957894/ui/views/controls/button/label_button_unittest.cc
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/027174c8d187ea7feeee16c822b3201704957894 Commit: 027174c8d187ea7feeee16c822b3201704957894 Author: pkasting@chromium.org Commiter: pkasting@chromium.org Date: 2018-11-08 20:50:29 +0000 UTC Remove pre-Refresh MD modes from top-chrome-md With Refresh launched we no longer need to support pre-Refresh modes. This code is being cleaned up, so removing them from chrome://flags prevents them from being used in the wild. TBR=sky@chromium.org (cherry picked from commit 06b383969bc77710e075aa443a0fe263ef6e2010) Bug: 899483 , 901788 Change-Id: I62dcff14b13874c2c2f11440197713c021abb1e9 Reviewed-on: https://chromium-review.googlesource.com/c/1285082 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601735} Reviewed-on: https://chromium-review.googlesource.com/c/1327212 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#587} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/027174c8d187ea7feeee16c822b3201704957894 commit 027174c8d187ea7feeee16c822b3201704957894 Author: Peter Kasting <pkasting@chromium.org> Date: Thu Nov 08 20:50:29 2018 Remove pre-Refresh MD modes from top-chrome-md With Refresh launched we no longer need to support pre-Refresh modes. This code is being cleaned up, so removing them from chrome://flags prevents them from being used in the wild. TBR=sky@chromium.org (cherry picked from commit 06b383969bc77710e075aa443a0fe263ef6e2010) Bug: 899483 , 901788 Change-Id: I62dcff14b13874c2c2f11440197713c021abb1e9 Reviewed-on: https://chromium-review.googlesource.com/c/1285082 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601735} Reviewed-on: https://chromium-review.googlesource.com/c/1327212 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#587} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/027174c8d187ea7feeee16c822b3201704957894/chrome/browser/about_flags.cc [modify] https://crrev.com/027174c8d187ea7feeee16c822b3201704957894/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/027174c8d187ea7feeee16c822b3201704957894/chrome/browser/ui/views/location_bar/location_bar_view_browsertest.cc [modify] https://crrev.com/027174c8d187ea7feeee16c822b3201704957894/ui/base/material_design/material_design_controller.cc [modify] https://crrev.com/027174c8d187ea7feeee16c822b3201704957894/ui/base/ui_base_switches.cc [modify] https://crrev.com/027174c8d187ea7feeee16c822b3201704957894/ui/base/ui_base_switches.h [modify] https://crrev.com/027174c8d187ea7feeee16c822b3201704957894/ui/views/controls/button/label_button_unittest.cc
,
Nov 8
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/857bce27c9d1b92c650e87196781a43c9ba09f3a commit 857bce27c9d1b92c650e87196781a43c9ba09f3a Author: Peter Kasting <pkasting@chromium.org> Date: Thu Nov 08 21:30:21 2018 Fix compile failures on 3578 branch. On trunk https://chromium-review.googlesource.com/c/1277268 removed some uses of IsNewerMaterialUi(). That doesn't look suitable to merge into the branch, so just disable the pre-refresh codepaths directly. Bug: 899483 , 901788 Change-Id: I4765596275c47435b97f8b0ea831bd0176e8ada0 TBR: pbos Reviewed-on: https://chromium-review.googlesource.com/c/1327214 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#589} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/857bce27c9d1b92c650e87196781a43c9ba09f3a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/857bce27c9d1b92c650e87196781a43c9ba09f3a/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/857bce27c9d1b92c650e87196781a43c9ba09f3a Commit: 857bce27c9d1b92c650e87196781a43c9ba09f3a Author: pkasting@chromium.org Commiter: pkasting@chromium.org Date: 2018-11-08 21:30:21 +0000 UTC Fix compile failures on 3578 branch. On trunk https://chromium-review.googlesource.com/c/1277268 removed some uses of IsNewerMaterialUi(). That doesn't look suitable to merge into the branch, so just disable the pre-refresh codepaths directly. Bug: 899483 , 901788 Change-Id: I4765596275c47435b97f8b0ea831bd0176e8ada0 TBR: pbos Reviewed-on: https://chromium-review.googlesource.com/c/1327214 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#589} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by krajshree@chromium.org
, Oct 29