New issue
Advanced search Search tips

Issue 899474 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in v8::internal::AstNode::position

Project Member Reported by ClusterFuzz, Oct 27

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6480476938960896

Fuzzer: libFuzzer_v8_fully_instrumented_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  v8::internal::AstNode::position
  v8::internal::ParserBase<v8::internal::Parser>::ParseClassPropertyDefinition
  v8::internal::ParserBase<v8::internal::Parser>::ParseClassLiteral
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=603295:603298

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6480476938960896

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 27

Components: Blink>JavaScript>Language Blink>JavaScript>Parser
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 27

Cc: metzman@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Oct 27

Labels: Test-Predator-Auto-Owner
Owner: verwa...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/88c49eac28717322516c3baa01f828fa6e697531 ([parser] Remove RETURN_IF* part 10).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 4 by ClusterFuzz, Oct 27

Labels: OS-Mac
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/dc70cb6694e10067f77da72b3c55b479dfba4838

commit dc70cb6694e10067f77da72b3c55b479dfba4838
Author: Toon Verwaest <verwaest@chromium.org>
Date: Mon Oct 29 09:26:04 2018

[parser] Only throw spread class property error if it's the first error

Bug:  chromium:899474 , v8:8363,  v8:7926 
Change-Id: I89680d35ab2557f5a2b2282813362f5f654862a9
Reviewed-on: https://chromium-review.googlesource.com/c/1304314
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57058}
[modify] https://crrev.com/dc70cb6694e10067f77da72b3c55b479dfba4838/src/parsing/parser-base.h
[add] https://crrev.com/dc70cb6694e10067f77da72b3c55b479dfba4838/test/mjsunit/regress/regress-899474.js

Project Member

Comment 6 by ClusterFuzz, Oct 30

ClusterFuzz has detected this issue as fixed in range 603474:603476.

Detailed report: https://clusterfuzz.com/testcase?key=6480476938960896

Fuzzer: libFuzzer_v8_fully_instrumented_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  v8::internal::AstNode::position
  v8::internal::ParserBase<v8::internal::Parser>::ParseClassPropertyDefinition
  v8::internal::ParserBase<v8::internal::Parser>::ParseClassLiteral
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=603295:603298
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=603474:603476

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6480476938960896

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Oct 30

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6480476938960896 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment