New issue
Advanced search Search tips

Issue 899472 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 16
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Signin] Multilogin should not fail when there is more than 10 accounts

Project Member Reported by valeriyas@google.com, Oct 27

Issue description

Currently Multilogin endpoint returns INVALID_INPUT status and no cookies if there are more than 10 accounts which is a regression in comparison with Merge Session.
Should probably rebuild cookies for 10 first accounts.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90db8cbd9d930955df0e6097a621ddaaea826685

commit 90db8cbd9d930955df0e6097a621ddaaea826685
Author: David Roger <droger@chromium.org>
Date: Fri Nov 16 10:47:42 2018

[signin] OAuthMultilogin maintains current account ordering

OAuth multilogin now tries to keep the current account ordering as
much as possible.
It also handles the cases where there are more than 10 accounts in
Chrome (which happens in real life), and where there are more than
10 accounts in the cookie (should not happen in real life, but
should be handled gracefully).

Bug:  899472 
Change-Id: I04b6ab195beb2691ce23f25e1a645b19b0e2c9d9
Reviewed-on: https://chromium-review.googlesource.com/c/1335598
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608723}
[modify] https://crrev.com/90db8cbd9d930955df0e6097a621ddaaea826685/components/signin/core/browser/BUILD.gn
[modify] https://crrev.com/90db8cbd9d930955df0e6097a621ddaaea826685/components/signin/core/browser/account_reconcilor_delegate.cc
[modify] https://crrev.com/90db8cbd9d930955df0e6097a621ddaaea826685/components/signin/core/browser/account_reconcilor_delegate.h
[add] https://crrev.com/90db8cbd9d930955df0e6097a621ddaaea826685/components/signin/core/browser/account_reconcilor_delegate_unittest.cc
[modify] https://crrev.com/90db8cbd9d930955df0e6097a621ddaaea826685/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/90db8cbd9d930955df0e6097a621ddaaea826685/components/signin/core/browser/dice_account_reconcilor_delegate.cc
[modify] https://crrev.com/90db8cbd9d930955df0e6097a621ddaaea826685/components/signin/core/browser/dice_account_reconcilor_delegate.h
[modify] https://crrev.com/90db8cbd9d930955df0e6097a621ddaaea826685/components/signin/core/browser/mirror_account_reconcilor_delegate.cc
[modify] https://crrev.com/90db8cbd9d930955df0e6097a621ddaaea826685/components/signin/core/browser/mirror_account_reconcilor_delegate.h

Status: Fixed (was: Assigned)

Sign in to add a comment