New issue
Advanced search Search tips

Issue 899445 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Float-cast-overflow in blink::SVGInteger::CalculateAnimatedValue

Project Member Reported by ClusterFuzz, Oct 27

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6523787657609216

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::SVGInteger::CalculateAnimatedValue
  blink::SVGAnimateElement::CalculateAnimatedValue
  blink::SVGAnimationElement::UpdateAnimation
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=551565:563900

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6523787657609216

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 27

Components: Blink>SVG
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 27

Cc: sergeyu@chromium.org hajimehoshi@chromium.org juri.val...@qt.io
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Mark base::*Callback, GURL and mojo::ScopeHandleBase as noexcept movable by juri.valdmann@qt.io - https://chromium.googlesource.com/chromium/src/+/f841ac2afe7ac227b760d0300f2abfbe4c278bae

Replace kInternalAnimation with kInternalDefault by hajimehoshi@chromium.org - https://chromium.googlesource.com/chromium/src/+/f5ec9dde2be3999c4783f0ba2955abf320b0c26f

Fix documentation in callback.h by sergeyu@chromium.org - https://chromium.googlesource.com/chromium/src/+/3947bb6e0509198bd60f801e58050c654cd2ed19

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Status: Available (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/563390b263333c486e017cfedd9f206bcf12c462

commit 563390b263333c486e017cfedd9f206bcf12c462
Author: Fredrik Söderquist <fs@opera.com>
Date: Mon Oct 29 17:47:38 2018

Use clampTo<int> in SVGInteger::CalculateAnimatedValue

Matches what we do in SVGIntegerOptionalInteger::CalculateAnimatedValue,
and avoids undefined overflow.

Bug:  899445 
Change-Id: I1250a05482713780f707301ed29e015fd81e65f2
Reviewed-on: https://chromium-review.googlesource.com/c/1304483
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#603548}
[modify] https://crrev.com/563390b263333c486e017cfedd9f206bcf12c462/third_party/blink/renderer/core/svg/svg_integer.cc

Project Member

Comment 5 by ClusterFuzz, Oct 30

ClusterFuzz has detected this issue as fixed in range 603543:603564.

Detailed report: https://clusterfuzz.com/testcase?key=6523787657609216

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::SVGInteger::CalculateAnimatedValue
  blink::SVGAnimateElement::CalculateAnimatedValue
  blink::SVGAnimationElement::UpdateAnimation
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=551565:563900
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=603543:603564

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6523787657609216

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Oct 30

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 6523787657609216 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment