New issue
Advanced search Search tips

Issue 899432 link

Starred by 0 users
Status: Fixed
Owner:
edcourtney@chromium.org
Closed: Oct 31
Cc:
sammiequon@chromium.org
mccanny@chromium.org
osh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Black background animating on enter/exit overview.

Project Member Reported by sammiequon@chromium.org, Oct 27 
What steps will reproduce the problem?
(1) In tablet mode, enter overview.

What is the expected result?
No black background animated.

What happens instead?
If you look closely, and with slowed animation, there is a black background animating.
cinnamon-20181026-1.webm
3.2 MB View Download

Comment 1 by sammiequon@chromium.org, Oct 27

Owner: edcourtney@chromium.org
Status: Assigned (was: Untriaged)
+edcourtney

Bisected to [1]. Assigning to CL author.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1220350

Comment 2 by edcourtney@google.com, Oct 30

Status: Started (was: Assigned)
Thanks for doing the bisect. Let me take a look

Comment 3 by edcourtney@google.com, Oct 30

Cc: osh...@chromium.org
Looks like UpdatePipState was overzealously overwriting the window visibility animation type. Uploaded https://chromium-review.googlesource.com/c/chromium/src/+/1306971.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef7a7124e5ec59efae5d2173ab3f1508e1108782

commit ef7a7124e5ec59efae5d2173ab3f1508e1108782
Author: Eliot Courtney <edcourtney@google.com>
Date: Wed Oct 31 11:37:16 2018

Update WindowVisibilityAnimationType for PIP more conservatively.

It seems that WindowState::UpdatePipState was overwriting window
visibility animation types set by other code. Modify it to be called
earlier and only to update the window visibility animation type on
transitions from and to PIP.

as well (properly uses FADE type animation)

Bug:  899432 
Test: Animation to overview mode no longer has black backdrop animating
Test: Dismiss animation for PIP still works on closing the PIP window.
Change-Id: I9a575fbc55273cb4be7e26482f6f749e6d3ce15c
Reviewed-on: https://chromium-review.googlesource.com/c/1306971
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604208}
[modify] https://crrev.com/ef7a7124e5ec59efae5d2173ab3f1508e1108782/ash/wm/client_controlled_state.cc
[modify] https://crrev.com/ef7a7124e5ec59efae5d2173ab3f1508e1108782/ash/wm/default_state.cc
[modify] https://crrev.com/ef7a7124e5ec59efae5d2173ab3f1508e1108782/ash/wm/window_state.cc
[modify] https://crrev.com/ef7a7124e5ec59efae5d2173ab3f1508e1108782/ash/wm/window_state.h

Comment 5 by edcourtney@chromium.org, Oct 31

Status: Fixed (was: Started)
►

Sign in to add a comment