New issue
Advanced search Search tips

Issue 899429 link

Starred by 1 user
Status: Fixed
Owner:
mukai@chromium.org
Closed: Oct 30
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Mash: WindowTree::CancelActiveTouches seems used too many

Project Member Reported by mukai@chromium.org, Oct 27 
During debugging chrome with --enable-features=SingleProcessMash and --vmodule=window_tree=3, it seems CancelActiveTouches are too often invoked. As roughly counted, creating a new tab causes ~30 invocation of this, and a tab-switch also causes this >10 times. Also these happen even without using any touches. We don't have to send this if it actually doesn't cancel anything (i.e. no touch history in there).
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ff4782ac1800ff6c089d036b579ae64951ec21f

commit 8ff4782ac1800ff6c089d036b579ae64951ec21f
Author: Jun Mukai <mukai@chromium.org>
Date: Tue Oct 30 02:22:16 2018

Do not emit OnActiveTouchesCanceled if cancel did not happen

As is reported in the bug, the window service receives too many
mojo messages for CancelActiveTouches, and that's because
it always sends the messages every time CancelActiveTouches is
requested. But it doesn't have to send it if nothing has to be
canceled.

BUG= 899429 
TEST=manually, and the new test case covers

Change-Id: I26b0234ef9e541b5dc31623d27162a0ea374bb54
Reviewed-on: https://chromium-review.googlesource.com/c/1305235
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603744}
[modify] https://crrev.com/8ff4782ac1800ff6c089d036b579ae64951ec21f/ui/aura/mus/gesture_synchronizer_unittest.cc
[modify] https://crrev.com/8ff4782ac1800ff6c089d036b579ae64951ec21f/ui/events/gestures/gesture_recognizer_impl.cc
[modify] https://crrev.com/8ff4782ac1800ff6c089d036b579ae64951ec21f/ui/events/gestures/gesture_recognizer_impl_unittest.cc
[modify] https://crrev.com/8ff4782ac1800ff6c089d036b579ae64951ec21f/ui/events/gestures/gesture_recognizer_observer.h

Comment 2 by mukai@chromium.org, Oct 30

Status: Fixed (was: Started)
►

Sign in to add a comment