New issue
Advanced search Search tips

Issue 899423 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
q4



Sign in to add a comment

Inline tab navigation functions in HistorySideSwipeController

Project Member Reported by mrefaat@chromium.org, Oct 27

Issue description

This may need some refactoring to be able to access the webstate.

 

Comment 1 Deleted

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84fc8828939c77deb9a75710040438e84a58c8aa

commit 84fc8828939c77deb9a75710040438e84a58c8aa
Author: mrefaat <mrefaat@chromium.org>
Date: Thu Dec 20 18:47:00 2018

Create web_navigation_util and use it for navigation logic that depend
on the webState.

Change SideSwipeController & BrowserViewController to use it instead of
tab methods.

Also Remove the existing tab_util and move the CreateWebLoadParams to
the navigation utils.

Bug:  899598 , 899423, 915955
Change-Id: I811e358fbd669c278855bf79f718274cc8cac712
Reviewed-on: https://chromium-review.googlesource.com/c/1380559
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618279}
[modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/app/BUILD.gn
[modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/tabs/BUILD.gn
[delete] https://crrev.com/c33c286e565fc89faaa492178a3b4ba7cf666ae8/ios/chrome/browser/tabs/tab_util.h
[delete] https://crrev.com/c33c286e565fc89faaa492178a3b4ba7cf666ae8/ios/chrome/browser/tabs/tab_util_unittest.mm
[modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm
[modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/web/BUILD.gn
[add] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/web/web_navigation_util.h
[rename] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/web/web_navigation_util.mm
[add] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/chrome/browser/web/web_navigation_util_unittest.mm
[modify] https://crrev.com/84fc8828939c77deb9a75710040438e84a58c8aa/ios/web/public/test/fakes/test_navigation_manager.mm

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65ba1ea52cfc6a4a4e1d6a17d1aea05aee3614c4

commit 65ba1ea52cfc6a4a4e1d6a17d1aea05aee3614c4
Author: mrefaat <mrefaat@chromium.org>
Date: Thu Jan 17 23:21:17 2019

Remove usage of tab's goBack/goForward from sideSwipeController

Use WebStateList to access webState instead of getting it from tab.
Use WebState to get the navigationManager which can be used for goBack and goForward.

Bug: 899423
Change-Id: Idf62bbbdbcbd11df1a1706f4374f8eb8cc3e6e27
Reviewed-on: https://chromium-review.googlesource.com/c/1371013
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623902}
[modify] https://crrev.com/65ba1ea52cfc6a4a4e1d6a17d1aea05aee3614c4/ios/chrome/browser/ui/side_swipe/BUILD.gn
[modify] https://crrev.com/65ba1ea52cfc6a4a4e1d6a17d1aea05aee3614c4/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Today (13 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cd609afcf8825991fadd04feeae2baaaa1fc9fb

commit 4cd609afcf8825991fadd04feeae2baaaa1fc9fb
Author: mrefaat <mrefaat@chromium.org>
Date: Tue Jan 22 18:34:47 2019

Remove Tab's navigation methods

Removes: goBack, canGoBack, goForward and canGoForward

Bug: 661664,  899598 , 899423
Change-Id: Ia1b781d6827ffc50ca2fe18c513e67d7f4ac2b15
Reviewed-on: https://chromium-review.googlesource.com/c/1372174
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624844}
[modify] https://crrev.com/4cd609afcf8825991fadd04feeae2baaaa1fc9fb/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/4cd609afcf8825991fadd04feeae2baaaa1fc9fb/ios/chrome/browser/tabs/tab.mm

Sign in to add a comment