New issue
Advanced search Search tips

Issue 899399 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocked on:
issue 900599



Sign in to add a comment

Remove Meta Viewport Restriction for GPU Rasterization

Project Member Reported by ericrk@chromium.org, Oct 26

Issue description

Historically we avoided GPU rasterization on desktop sites on mobile for a few reasons:
- Avoids bugs exposed by more complex desktop site shaders.
- Avoids complex scheduling during pinch/zoom.

Now that GPU raster has launched on most desktop platforms and we have
the GPU scheduler in place on Android, it seems like a good time to
re-visit this.

This bug tracks work to enable GPU raster for all mobile sites.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0623ec7cb1b2ed48c4d9496f324323609cce773c

commit 0623ec7cb1b2ed48c4d9496f324323609cce773c
Author: Eric Karl <ericrk@chromium.org>
Date: Tue Oct 30 19:43:26 2018

Add feature to remove Viewport Meta GPU Raster restriction

This change adds a feature, EnableGpuRasterizationViewportRestriction,
which, when disabled, allows us to enable GPU raster for all content
independent of the viewport trigger.

TBR=chrishtr@chromium.org, as pdr has reviewed, but owns the .h but not .cc part of features.*

Bug: 899399
Change-Id: I986d6e40d93f149cb2d5fc11758ca8b3f0bc1a89
Reviewed-on: https://chromium-review.googlesource.com/c/1303397
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603987}
[modify] https://crrev.com/0623ec7cb1b2ed48c4d9496f324323609cce773c/third_party/blink/common/features.cc
[modify] https://crrev.com/0623ec7cb1b2ed48c4d9496f324323609cce773c/third_party/blink/public/common/features.h
[modify] https://crrev.com/0623ec7cb1b2ed48c4d9496f324323609cce773c/third_party/blink/renderer/core/page/viewport_description.cc

> Now that GPU raster has launched on most desktop platforms and we have
> the GPU scheduler in place on Android, it seems like a good time to
> re-visit this.

Something to keep in mind is GPU Scheduling is more limited with OOPR, until more of the SkDDL and/or threading work is done for raster.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/924edd7aee62613bf0d3f51b4c4d00e63f5c104e

commit 924edd7aee62613bf0d3f51b4c4d00e63f5c104e
Author: Eric Karl <ericrk@chromium.org>
Date: Wed Oct 31 03:23:49 2018

EnableGpuRasterizationViewportRestriction bot config

This CL sets EnableGpuRasterizationViewportRestriction to false on bots,
removing the restriction that GPU rasterization is only used for mobile
sites on Android. This will allow us to collect data on performance and
memory impact and prepare for launch.

Bug: 899399
Change-Id: I60e7c8ab99020c4a4a498ce9cc924de012ad8b64
Reviewed-on: https://chromium-review.googlesource.com/c/1306345
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604133}
[modify] https://crrev.com/924edd7aee62613bf0d3f51b4c4d00e63f5c104e/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/924edd7aee62613bf0d3f51b4c4d00e63f5c104e/content/test/gpu/gpu_tests/pixel_test_pages.py
[modify] https://crrev.com/924edd7aee62613bf0d3f51b4c4d00e63f5c104e/testing/variations/fieldtrial_testing_config.json

Eric, I think the CL in #3 broke
Pixel_CanvasDisplayLinearRGBAccelerated2D and
Pixel_CanvasDisplayLinearRGBUnaccelerated2DGPUCompositing
on Nexus 5
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%205%29/10945

Please take a look and suppress or rebase if needed.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/197840b8f502ea95e836089266d24396b3f1877b

commit 197840b8f502ea95e836089266d24396b3f1877b
Author: Eric Karl <ericrk@chromium.org>
Date: Wed Oct 31 18:38:08 2018

EnableGpuRasterizationViewportRestriction: re-enable pixel tests

Re-enables pixel tests after rebaselining due to the
EnableGpuRasterizationViewportRestriction experiment.

TBR=kbr@chromium.org for second half of pixel test rebaseline

Bug: 899399
Change-Id: Icc11b44b9b2240b4e70ffe5bf78f1a24673db0ff
Reviewed-on: https://chromium-review.googlesource.com/c/1309103
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604347}
[modify] https://crrev.com/197840b8f502ea95e836089266d24396b3f1877b/content/test/gpu/gpu_tests/pixel_expectations.py

Blockedon: 900599

Sign in to add a comment