New issue
Advanced search Search tips

Issue 899369 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Oct 31
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: breakpoint does not turn orange after editing condition

Project Member Reported by l...@chromium.org, Oct 26 
What steps will reproduce the problem?
(1) Open a script in Sources that has not been mapped (Workspace script, or Snippet that hasn't been run)
(2) Add a breakpoint (it's blue)
(3) Right click > 'Edit breakpoint' > commit

What is the expected result?
Breakpoint should turn orange

What happens instead?
Breakpoint remains blue, even though it acts as a conditional breakpoint
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fa30d92ee5b39c4816f980e7bfd948079b35e60

commit 9fa30d92ee5b39c4816f980e7bfd948079b35e60
Author: Erik Luo <luoe@chromium.org>
Date: Wed Oct 31 01:40:47 2018

DevTools: breakpoints without uilocation should update decoration

When editing a breakpoint (disable, edit condition), we trigger
BreakpointRemoved, BreakpointAdded by resetting live UILocations.
Un-evaluated Snippets and Filesystem scripts may have a
'defaultUILocation' but no live UILocation, so edits will not
update the decoration.

This CL resets the defaultUILocation to trigger decoration
update.

Bug:  899369 
Change-Id: I4474d39c5fd25f14588e0488ce9b284aa453988e
Reviewed-on: https://chromium-review.googlesource.com/c/1303096
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604103}
[add] https://crrev.com/9fa30d92ee5b39c4816f980e7bfd948079b35e60/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/snippet-edit-breakpoint-expected.txt
[add] https://crrev.com/9fa30d92ee5b39c4816f980e7bfd948079b35e60/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/snippet-edit-breakpoint.js
[modify] https://crrev.com/9fa30d92ee5b39c4816f980e7bfd948079b35e60/third_party/blink/renderer/devtools/front_end/bindings/BreakpointManager.js
[modify] https://crrev.com/9fa30d92ee5b39c4816f980e7bfd948079b35e60/third_party/blink/renderer/devtools/front_end/sources_test_runner/DebuggerTestRunner.js

Comment 3 by l...@chromium.org, Oct 31

Status: Fixed (was: Assigned)
►

Sign in to add a comment