New issue
Advanced search Search tips

Issue 899368 link

Starred by 1 user
Status: Verified
Owner:
jsaul@google.com
Closed: Oct 30
Cc:
annelim@google.com
dlkumar@google.com
linds...@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task



Sign in to add a comment

[Merge Request M71] Add StrikeDatabase flag to iOS about_flags

Project Member Reported by jsaul@google.com, Oct 26 
This is a merge request for "[Autofill] Add Autofill StrikeDatabase switch to about_flags for iOS"
https://chromium-review.googlesource.com/c/chromium/src/+/1302329

The flag entry was missing from iOS.  This CL makes the flag appear on chrome://flags so that the iOS testing team can test the feature.

(I have not yet confirmed that this flag successfully appears on iOS; I will be able to do so with the next iOS Chrome Dev rollout.)
Project Member

Comment 1 by sheriffbot@chromium.org, Oct 26

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by kariahda@chromium.org, Oct 29 

Can you confirm this on canary? If not, dev goes out every Tuesday so you should be able to verify the flag is there by EOD tomorrow.

Comment 3 by jsaul@google.com, Oct 29 

Yep, I just confirmed that the flag correctly appears in Canary (and also correctly enables the feature).

Comment 4 by jsaul@google.com, Oct 29

Cc: linds...@chromium.org

Comment 5 by kariahda@chromium.org, Oct 30

Labels: -Merge-Review-71 Merge-Approved-71
Approved.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 30

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d3abc780bdd08c3cf69d9fe9acf1f574fafca96

commit 5d3abc780bdd08c3cf69d9fe9acf1f574fafca96
Author: Jared Saul <jsaul@google.com>
Date: Tue Oct 30 21:30:04 2018

[Autofill] Add Autofill StrikeDatabase switch to about_flags for iOS

Bug:  899368 
Change-Id: Ie2535ee36d806801ecc98891c6ec37c53a339365
Reviewed-on: https://chromium-review.googlesource.com/c/1302329
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#603185}(cherry picked from commit 2e55e7f1f6e3bbc23946ab48ebfd44d656e73e81)
Reviewed-on: https://chromium-review.googlesource.com/c/1308772
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/branch-heads/3578@{#419}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/5d3abc780bdd08c3cf69d9fe9acf1f574fafca96/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/5d3abc780bdd08c3cf69d9fe9acf1f574fafca96/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/5d3abc780bdd08c3cf69d9fe9acf1f574fafca96/ios/chrome/browser/ios_chrome_flag_descriptions.h

Comment 7 by jsaul@google.com, Oct 30

Status: Fixed (was: Assigned)
Done, thanks!  This should be available as of version 71.0.3578.30.
Project Member

Comment 8 by cr-audit...@appspot.gserviceaccount.com, Oct 30

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/5d3abc780bdd08c3cf69d9fe9acf1f574fafca96

Commit: 5d3abc780bdd08c3cf69d9fe9acf1f574fafca96
Author: jsaul@google.com
Commiter: jsaul@google.com
Date: 2018-10-30 21:30:04 +0000 UTC

[Autofill] Add Autofill StrikeDatabase switch to about_flags for iOS

Bug:  899368 
Change-Id: Ie2535ee36d806801ecc98891c6ec37c53a339365
Reviewed-on: https://chromium-review.googlesource.com/c/1302329
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#603185}(cherry picked from commit 2e55e7f1f6e3bbc23946ab48ebfd44d656e73e81)
Reviewed-on: https://chromium-review.googlesource.com/c/1308772
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/branch-heads/3578@{#419}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Comment 9 by shbarezer@google.com, Nov 7

Status: Verified (was: Fixed)
Verified on 71.0.3578.41 Beta,  iPhoneX iOS 11.4.1

#enable-autofill-save-credit-card-uses-strike-system flag in present.
►

Sign in to add a comment