New issue
Advanced search Search tips

Issue 899367 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Nag owners of fixed/closed bugs if disabled tests are still associated with supposedly fixed bugs

Project Member Reported by lukasza@chromium.org, Oct 26

Issue description

1. There are quite a few tests that are still disabled, even though the bug they is marked as related to the test has been fixed.  The "disabled test <-> bug" association is easiest to find in layout test expectations, but disabled gtest tests are also sometimes informally associated with a bug via a comment.

2. It would be great if we had a process for making sure that tests are re-enabled in a timely manner.

Proposal: Can we automatically nag owners of fixed/closed bugs if disabled tests are still associated with the supposedly fixed/closed bugs?
 
Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)
This seems like an excellent idea. I suppose we should hook into a transition-to-fixed event on Chromium bugs. robertma@chromium.org do you know how to make this happen?
Cc: dpranke@chromium.org
+Dirk
FWIW, I am trying to create an AppScript that can 1) use MonorailAPI + 2) scrape https://cs.chromium.org to either 3) populate a spreadsheet with stale bugs or 4) add comments/labels to such bugs.

I tried to create such script via lukasza@chromium.org account, but got told that my @chromium.org account doesn't have access to the library MonorailAPI... :-(

So, for now the (unfinished) spreadsheet + script are Google-internaly only :-(
- https://docs.google.com/spreadsheets/d/14NKy1kbi2FQ3J9_eXCYxpeLajBQLz7Wc7Tw1AMlu9Ns
- https://script.google.com/a/google.com/d/16Wmwj3-oFOYSorExzJlEyvNikxfniyHv-NG1fUbR0AO-6Cp-X1B1f2M0/edit

My progress on the script is currently blocked by lack of access to the library Monorail API from either lukasza@google.com or lukasza@chromium.org.  I opened https://bugs.chromium.org/p/monorail/issues/detail?id=4509 to try requesting access.


RE: #c1:

Thanks for the suggestion to also "hook into a transition-to-fixed event on Chromium bugs".  The AppScript above would be useful for enumerating *currently existing* stale bugs, while the transition-to-fixed-hook might be useful to catch *new* stale bugs (which sounds quite desirable).
I think the AppScript works now.  It found 152 bugs that are "closed", but are still associated with one or more of LayoutTests/TestExpectations.  The results are in https://docs.google.com/spreadsheets/d/14NKy1kbi2FQ3J9_eXCYxpeLajBQLz7Wc7Tw1AMlu9Ns (Google-internal only... see https://bugs.chromium.org/p/monorail/issues/detail?id=4509#c5).

Not sure what the next steps are.  Let me ask on chromium-dev@.

Sign in to add a comment