New issue
Advanced search Search tips

Issue 899348 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Task

Blocked on:
issue 900428



Sign in to add a comment

[Fuchsia] Move Ozone Scenic platform to Views V2 API

Project Member Reported by sergeyu@chromium.org, Oct 26

Issue description

Currently Scenic ozone platform uses Views V1 API. Scenic now supports second version of the API so we should transition ASAP.
 
Components: Internals>PlatformIntegration
Labels: -Pri-2 M-72 Pri-1
Blockedon: 881591
Blockedon: -881591
Blockedon: 900428
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d239fd5a510626a89741a41df98d616c9f51f801

commit d239fd5a510626a89741a41df98d616c9f51f801
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Oct 31 01:40:34 2018

[Fuchsia] Use scenic_cpp in Ozone

Previously scenic platform was using FIDL Scenic interfaces directly.
SDK now includes scenic_cpp wrappers for Scenic interfaces. This CL
updates Scenic Ozone platform to use scenic_cpp, which makes the code
more readable and less error-prone.

Bug: 899348
Change-Id: Id5fac3485b6a8cfac1aaefe1a921555090ec8138
Reviewed-on: https://chromium-review.googlesource.com/c/1308987
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604102}
[modify] https://crrev.com/d239fd5a510626a89741a41df98d616c9f51f801/ui/ozone/platform/scenic/BUILD.gn
[delete] https://crrev.com/5d014c91c4a7056c8a0530240efbf377bdb5c6c4/ui/ozone/platform/scenic/scenic_session.cc
[delete] https://crrev.com/5d014c91c4a7056c8a0530240efbf377bdb5c6c4/ui/ozone/platform/scenic/scenic_session.h
[modify] https://crrev.com/d239fd5a510626a89741a41df98d616c9f51f801/ui/ozone/platform/scenic/scenic_window.cc
[modify] https://crrev.com/d239fd5a510626a89741a41df98d616c9f51f801/ui/ozone/platform/scenic/scenic_window.h
[modify] https://crrev.com/d239fd5a510626a89741a41df98d616c9f51f801/ui/ozone/platform/scenic/scenic_window_canvas.cc
[modify] https://crrev.com/d239fd5a510626a89741a41df98d616c9f51f801/ui/ozone/platform/scenic/scenic_window_canvas.h
[modify] https://crrev.com/d239fd5a510626a89741a41df98d616c9f51f801/ui/ozone/platform/scenic/vulkan_implementation_scenic.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b0926d7999e854deaa0677d94b7f08daba1e513

commit 2b0926d7999e854deaa0677d94b7f08daba1e513
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Oct 31 22:16:24 2018

[Fuchsia] Minor cleanups in ScenicWindowCanvas

Minor fixes in the code that allocates VMOs to pass images to scenic:
1. VMO handle is now dropped immediately after VMO is mapped.
2. Added check to verify that VMO is mapped successfully.
3. Read-only VMO handle is passed to Scenic.

Bug: 899348
Change-Id: Ie78261ffc00dd5c9b80cc2b93ad2006a47c5118d
Reviewed-on: https://chromium-review.googlesource.com/c/1309301
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604417}
[modify] https://crrev.com/2b0926d7999e854deaa0677d94b7f08daba1e513/ui/ozone/platform/scenic/scenic_window_canvas.cc
[modify] https://crrev.com/2b0926d7999e854deaa0677d94b7f08daba1e513/ui/ozone/platform/scenic/scenic_window_canvas.h

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e4ece7123dea5790ed5cd1640b50a054daea4fa

commit 6e4ece7123dea5790ed5cd1640b50a054daea4fa
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Sun Nov 04 04:07:00 2018

[Fuchsia] Prepare webrunner for ViewsV2 migration.

The old fuchsia.ui.viewsv1 API is being replaced with views support
in Scenic. This CL prepares chromium for that migration:
1. Adds implementation of fuchsia.app.ViewFactory in WebComponent.
   fuchsia.viewsv1.ViewFactory will be removed in the future after
   it's removed and all consumers are updated.
2. Added CreateView2() method in the chromium.web.Frame interface.
   It is compatible with ViewsV2 and will replace the old
   CreateView().
3. Updated content_shell and ozone_demo to use Presenter::Present2(),
   which is compatible with ViewsV2.

Bug: 899348
Change-Id: I82d066cdd60dc06cf598f336a40cca4584d1e3bb
Reviewed-on: https://chromium-review.googlesource.com/c/1311123
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605203}
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/content/shell/browser/shell_platform_data_aura.cc
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/ui/ozone/demo/demo_window.cc
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/ui/ozone/platform/scenic/ozone_platform_scenic.cc
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/ui/ozone/platform/scenic/scenic_window.cc
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/ui/ozone/platform/scenic/scenic_window.h
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/ui/ozone/platform/scenic/scenic_window_manager.cc
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/ui/ozone/public/ozone_platform.cc
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/ui/ozone/public/ozone_platform.h
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/ui/platform_window/BUILD.gn
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/ui/platform_window/platform_window_init_properties.h
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/webrunner/BUILD.gn
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/webrunner/app/common/web_component.cc
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/webrunner/app/common/web_component.h
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/webrunner/browser/frame_impl.cc
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/webrunner/browser/frame_impl.h
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/webrunner/fidl/web/frame.fidl
[modify] https://crrev.com/6e4ece7123dea5790ed5cd1640b50a054daea4fa/webrunner/service/context_provider_impl_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/034a565655b1f6164c8f1e73b0c0df970c01544c

commit 034a565655b1f6164c8f1e73b0c0df970c01544c
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Dec 04 23:35:20 2018

[Fuchsia] Export fuchsia::ui::app::ViewProvider in WebComponent.

As part of ViewsV2 migration WebComponent was updated to implement
the new ViewProvider interface, but not to export it. As result it
stopped working when tiles was updated to ViewsV2. Added ServiceBinding
for the interfaces to fix that issues.

Bug: 899348
Change-Id: Icbe0a345b7df857273a3e0f23016a8edf3c500d9
Reviewed-on: https://chromium-review.googlesource.com/c/1362212
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613759}
[modify] https://crrev.com/034a565655b1f6164c8f1e73b0c0df970c01544c/webrunner/app/common/web_component.cc
[modify] https://crrev.com/034a565655b1f6164c8f1e73b0c0df970c01544c/webrunner/app/common/web_component.h

Sign in to add a comment