New issue
Advanced search Search tips

Issue 899337 link

Starred by 1 user
Status: Assigned
Owner:
hua...@chromium.org
Cc:
agrieve@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

SuperSize: Need test .map file for LLD

Project Member Reported by huangs@google.com, Oct 26 
SuperSize's linker_map_parser.py was developed for Gold's linker map format. For integration tests, the test .map file is:

  tools/binary_size/libsupersize/testdata/test.map  

In https://chromium-review.googlesource.com/c/chromium/src/+/759090 , support for LLD's linker map was added (in fact we've seen 2 versions of this). However, we have yet to update test.map to the new format.

This bug is a reminder to update test.map.

Comment 1 by huangs@google.com, Oct 26 

We've seen 3 formats:
* Gold  <== Current version
* LLD v0
* LLD v1

Perhaps we should just update test.map from Gold to LLD v1, rather than supporting all 3 versions and make integration test 3 times as slow?

Comment 2 by benhenry@google.com, Jan 11

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Comment 3 by hua...@chromium.org, Jan 14

Labels: -Type-Bug Type-Feature
The CL https://chromium-review.googlesource.com/c/1378679 added 

tools/binary_size/libsupersize/testdata/linker_map_parser/test_lld-lto_v1.map

for testing linker_map_parser.py. This provides coverage for .map file testing, although no for end-to-end flow.
►

Sign in to add a comment