Flaky test: media/controls/overflow-menu-toggle-class-for-animation.html Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.mac/WebKit%20Mac10.13%20%28retina%29/6030 Test output log: https://chromium-swarm.appspot.com/task?id=40ca74661cb27b10 Culprit (100.0% confidence): r603116 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy7gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCK3AWNocm9taXVtLm1hYy9XZWJLaXQgTWFjMTAuMTMgKHJldGluYSkvNjAzMC93ZWJraXRfbGF5b3V0X3Rlc3RzIG9uIEFUSSBHUFUgb24gTWFjIFJldGluYSBvbiBNYWMtMTAuMTMuNi9iV1ZrYVdFdlkyOXVkSEp2YkhNdmIzWmxjbVpzYjNjdGJXVnVkUzEwYjJkbmJHVXRZMnhoYzNNdFptOXlMV0Z1YVcxaGRHbHZiaTVvZEcxcwwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20media/controls/overflow-menu-toggle-class-for-animation.html&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy7gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCK3AWNocm9taXVtLm1hYy9XZWJLaXQgTWFjMTAuMTMgKHJldGluYSkvNjAzMC93ZWJraXRfbGF5b3V0X3Rlc3RzIG9uIEFUSSBHUFUgb24gTWFjIFJldGluYSBvbiBNYWMtMTAuMTMuNi9iV1ZrYVdFdlkyOXVkSEp2YkhNdmIzWmxjbVpzYjNjdGJXVnVkUzEwYjJkbmJHVXRZMnhoYzNNdFptOXlMV0Z1YVcxaGRHbHZiaTVvZEcxcwwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c32b4659479549bd0b0b6dff40c32e7a9857e424 commit c32b4659479549bd0b0b6dff40c32e7a9857e424 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Fri Oct 26 19:06:46 2018 Revert "[Media Controls] Added animation to overflow menu" This reverts commit 4fcaee53139b0afb003ff1ba13b902a6a3f2a315. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 603116 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNGZjYWVlNTMxMzliMGFmYjAwM2ZmMWJhMTNiOTAyYTZhM2YyYTMxNQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/WebKit%20Mac10.13%20%28retina%29/6030 Sample Failed Step: webkit_layout_tests on ATI GPU on Mac Retina on Mac-10.13.6 Sample Flaky Test: media/controls/overflow-menu-toggle-class-for-animation.html Original change's description: > [Media Controls] Added animation to overflow menu > > Toggle "closed" class when open/close menu to achieve transition animation. > This CL only has opening animation. > > TODO: Add close animation; Add wave like animation to label when opening menu. > > Bug: 814507 > > Change-Id: I2a036297741f34905fe868c7ea0a99e9ea91cea3 > Reviewed-on: https://chromium-review.googlesource.com/c/1286949 > Commit-Queue: Jazz Xu <jazzhsu@google.com> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603116} Change-Id: Ia9b6c5e419ec201f6ac328a1de049c65528f6dc0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 814507 , 899335 Reviewed-on: https://chromium-review.googlesource.com/c/1302577 Cr-Commit-Position: refs/heads/master@{#603158} [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-saves-media-cross-origin.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-saves-media.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/http/tests/media/video-controls-overflow-menu-download-button.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/controls/closed-captions-dynamic-update.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/controls/closed-captions-on-off.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/controls/closed-captions-single-track.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/controls/closed-captions-switch-track.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/controls/overflow-menu-hide-on-click-item.html [delete] https://crrev.com/bc440db926560222bd83bfedf897615e21a4e32e/third_party/WebKit/LayoutTests/media/controls/overflow-menu-toggle-class-for-animation.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/controls/text-track-menu-keyboard-navigation.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/controls/text-track-menu-pointer-selection.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/picture-in-picture/controls/picture-in-picture-button.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/picture-in-picture/picture-in-picture-interstitial-sizing.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/picture-in-picture/picture-in-picture-interstitial.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-add-track.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/video-controls-labels.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-closed-captions-button.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-fullscreen-button.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-mute-button.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-play-button.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/WebKit/LayoutTests/media/video-controls-track-selection-menu.html [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_list_element.cc [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_list_element.h [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/blink/renderer/modules/media_controls/elements/media_control_text_track_list_element.cc [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/blink/renderer/modules/media_controls/media_controls_impl.h [modify] https://crrev.com/c32b4659479549bd0b0b6dff40c32e7a9857e424/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css
Issue 899338 has been merged into this issue.
Issue 899349 has been merged into this issue.
This flake has been identified as being introduced in r623535
No, FindIt. Bad FindIt.
Comment 1 by bugdroid1@chromium.org
, Oct 26