New issue
Advanced search Search tips

Issue 899324 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Remove v1 EasyUnlock code

Project Member Reported by jhawkins@chromium.org, Oct 26

Issue description

With unified setup out the door, we can remove the old EasyUnlock code (app, easyunlock private API, etc).
 
Labels: OS-Chrome
AFAIK, easy unlock app is the only client for screenLockPrivate API - if so, that one should be removed, too
tbarzic: Yep, that's the plan!
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bb8dfd77b1beb144e2b9af52c24fe2e0925ec8f

commit 3bb8dfd77b1beb144e2b9af52c24fe2e0925ec8f
Author: James Hawkins <jhawkins@chromium.org>
Date: Fri Oct 26 22:50:55 2018

Smart Lock: Remove unused promo notification code.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I762ae359249c60481ba4866703aa1e7fbbc6552e
Reviewed-on: https://chromium-review.googlesource.com/c/1302330
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603234}
[delete] https://crrev.com/2e46681d6ef261bde61742357e93bf358b7c1e0a/chrome/app/theme/default_100_percent/cros/notification_easyunlock_promo.png
[delete] https://crrev.com/2e46681d6ef261bde61742357e93bf358b7c1e0a/chrome/app/theme/default_200_percent/cros/notification_easyunlock_promo.png
[modify] https://crrev.com/3bb8dfd77b1beb144e2b9af52c24fe2e0925ec8f/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/3bb8dfd77b1beb144e2b9af52c24fe2e0925ec8f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.cc
[modify] https://crrev.com/3bb8dfd77b1beb144e2b9af52c24fe2e0925ec8f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.h
[modify] https://crrev.com/3bb8dfd77b1beb144e2b9af52c24fe2e0925ec8f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller_chromeos_unittest.cc
[modify] https://crrev.com/3bb8dfd77b1beb144e2b9af52c24fe2e0925ec8f/chromeos/components/proximity_auth/notification_controller.h

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/218f9a3be029f649fad25e02d89abdd42affed18

commit 218f9a3be029f649fad25e02d89abdd42affed18
Author: James Hawkins <jhawkins@chromium.org>
Date: Mon Oct 29 19:29:16 2018

Smart Lock: Remove RecordClickOnLockIcon.

This was only used for the EasyUnlock trial which is currently unused
and about to be removed.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Ic3b7271a386d26728e7af4e4ea56dfdd6b19c675
Reviewed-on: https://chromium-review.googlesource.com/c/1302696
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603586}
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/ash/login/login_screen_controller.cc
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/ash/login/login_screen_controller.h
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/ash/login/login_screen_controller_unittest.cc
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.cc
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.h
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler_unittest.cc
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/lock/views_screen_locker.h
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/screens/user_selection_screen.h
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/ui/ash/login_screen_client.h
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.cc
[modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.h

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c491d560e79043e204bdf81126fa4fd54f211f6

commit 0c491d560e79043e204bdf81126fa4fd54f211f6
Author: James Hawkins <jhawkins@chromium.org>
Date: Mon Oct 29 20:34:00 2018

Smart Lock: Remove SetTrialRun method.

There is no longer a trial run in the new setup flow.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Ic466140fbe18890e707f3338a38b58f385af0f2f
Reviewed-on: https://chromium-review.googlesource.com/c/1302704
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603607}
[modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/ash/public/interfaces/login_user_info.mojom
[modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_metrics.cc
[modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_metrics.h
[modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.cc
[modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.h
[modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler_unittest.cc
[modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h
[modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/user_board_view_mojo.cc
[modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc
[modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chromeos/components/proximity_auth/screenlock_bridge.cc
[modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chromeos/components/proximity_auth/screenlock_bridge.h

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/665e73505703afdd017085f3121258c6d9a7fa20

commit 665e73505703afdd017085f3121258c6d9a7fa20
Author: James Hawkins <jhawkins@chromium.org>
Date: Tue Oct 30 01:16:55 2018

Smart Lock: Remove EasyUnlock V1 setup button.

The turn-off flow will be removed in a follow-up CL.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Ie6ac355c020ca428d49b67c1f9c65e1103e666ad
Reviewed-on: https://chromium-review.googlesource.com/c/1306833
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603717}
[modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h
[modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h
[modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.h
[modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/resources/settings/people_page/easy_unlock_browser_proxy.js
[modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/resources/settings/people_page/lock_screen.js
[modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc
[modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc
[modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab31d75022a96b699ddf28d3ff8ebfbe577bdb90

commit ab31d75022a96b699ddf28d3ff8ebfbe577bdb90
Author: James Hawkins <jhawkins@chromium.org>
Date: Tue Oct 30 17:54:35 2018

Smart Lock: Remove unused OpenSetupAppAfterReauth.

Bug: 899324
Test: none
Change-Id: I9f632473636f6a6df3e2528a957adadda006a176
Reviewed-on: https://chromium-review.googlesource.com/c/1307236
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603956}
[modify] https://crrev.com/ab31d75022a96b699ddf28d3ff8ebfbe577bdb90/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/ab31d75022a96b699ddf28d3ff8ebfbe577bdb90/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feb61914cd18ac1b6d697f455e574eba1a1645c3

commit feb61914cd18ac1b6d697f455e574eba1a1645c3
Author: James Hawkins <jhawkins@chromium.org>
Date: Tue Oct 30 20:47:32 2018

Smart Lock: Remove the 'turn off' functionality from EasyUnlock V1.

R=dpapad@chromium.org, hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I01b9786b3e5f49490660829bd1c3a7659e73f9c7
Reviewed-on: https://chromium-review.googlesource.com/c/1306916
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604003}
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_observer.h
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.h
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/resources/settings/people_page/BUILD.gn
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/resources/settings/people_page/easy_unlock_browser_proxy.js
[delete] https://crrev.com/4f64b82677f39d0b8feb880e781fd0d5c7efa75d/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html
[delete] https://crrev.com/4f64b82677f39d0b8feb880e781fd0d5c7efa75d/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/resources/settings/people_page/lock_screen.js
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/test/data/webui/BUILD.gn
[delete] https://crrev.com/4f64b82677f39d0b8feb880e781fd0d5c7efa75d/chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b392bbf3408afacba96358e1e0b7ded000be4a64

commit b392bbf3408afacba96358e1e0b7ded000be4a64
Author: James Hawkins <jhawkins@chromium.org>
Date: Wed Oct 31 15:55:08 2018

Smart LocK: Remove unused observer OnScreenLockStateChanged.

Since is the last method on EasyUnlockServiceObserver, that interface is
also removed.

Bug: 899324
Test: none
Change-Id: Idf4c4136ec97431a5ceaa6d9a3c69a5a782b7882
Reviewed-on: https://chromium-review.googlesource.com/c/1307068
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604271}
[modify] https://crrev.com/b392bbf3408afacba96358e1e0b7ded000be4a64/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[delete] https://crrev.com/9f61c8347bc424d4a49e821a3752c03a1d81ecb6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_observer.h
[modify] https://crrev.com/b392bbf3408afacba96358e1e0b7ded000be4a64/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7cdff063ccabf78ab0d056dd47da671cccdade3

commit e7cdff063ccabf78ab0d056dd47da671cccdade3
Author: James Hawkins <jhawkins@chromium.org>
Date: Wed Oct 31 15:56:16 2018

Smart Lock: Remove authentication caching mechanism.

The EasyUnlock V1 setup flow is being removed, so this caching mechanism
is not necessary at the moment and helps break up the removal change.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I7a15a78d95edf5585636dc398f708fa12a7e0bc7
Reviewed-on: https://chromium-review.googlesource.com/c/1306348
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604272}
[modify] https://crrev.com/e7cdff063ccabf78ab0d056dd47da671cccdade3/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/e7cdff063ccabf78ab0d056dd47da671cccdade3/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
[modify] https://crrev.com/e7cdff063ccabf78ab0d056dd47da671cccdade3/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
[modify] https://crrev.com/e7cdff063ccabf78ab0d056dd47da671cccdade3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/e7cdff063ccabf78ab0d056dd47da671cccdade3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h
[modify] https://crrev.com/e7cdff063ccabf78ab0d056dd47da671cccdade3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/e7cdff063ccabf78ab0d056dd47da671cccdade3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h
[delete] https://crrev.com/b392bbf3408afacba96358e1e0b7ded000be4a64/chrome/browser/chromeos/login/easy_unlock/short_lived_user_context.cc
[delete] https://crrev.com/b392bbf3408afacba96358e1e0b7ded000be4a64/chrome/browser/chromeos/login/easy_unlock/short_lived_user_context.h

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf

commit d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf
Author: James Hawkins <jhawkins@chromium.org>
Date: Thu Nov 01 17:22:45 2018

Smart Lock: Remove SendAuthAttempt calls.

This method did nothing given that no event listener was registered for
the auth attempt listener in the WebUI.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I4f46d553ee95538a468b05a434f609ab60c7ca52
Reviewed-on: https://chromium-review.googlesource.com/c/1312300
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604625}
[modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager.cc
[modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager.h
[modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager_unittest.cc
[modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_auth_attempt.cc
[modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_auth_attempt.h
[modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_auth_attempt_unittest.cc
[modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_unittest_chromeos.cc
[modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc
[modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h
[modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc
[modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/common/extensions/api/screenlock_private.idl
[delete] https://crrev.com/5f2cc6d8103e545960e56f845cbfa97268d5f2b6/chrome/test/data/extensions/api_test/screenlock_private/auth_type/manifest.json
[delete] https://crrev.com/5f2cc6d8103e545960e56f845cbfa97268d5f2b6/chrome/test/data/extensions/api_test/screenlock_private/auth_type/test.js
[modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/extensions/browser/extension_event_histogram_value.h

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9094c99449adbde1ed817b9c3af33cd9b07506d

commit c9094c99449adbde1ed817b9c3af33cd9b07506d
Author: James Hawkins <jhawkins@chromium.org>
Date: Thu Nov 01 17:42:35 2018

Smart Lock: Remove EasyUnlockBrowserProxy.

The get*Enabled method is no longer called in release.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I91261c61ae5f666cf45c14e6c71512f3a7c70a42
Reviewed-on: https://chromium-review.googlesource.com/c/1312094
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604631}
[modify] https://crrev.com/c9094c99449adbde1ed817b9c3af33cd9b07506d/chrome/browser/resources/settings/people_page/BUILD.gn
[delete] https://crrev.com/56d152ff60b364132d7caf2f456c0d06bf2cfe6f/chrome/browser/resources/settings/people_page/easy_unlock_browser_proxy.html
[delete] https://crrev.com/56d152ff60b364132d7caf2f456c0d06bf2cfe6f/chrome/browser/resources/settings/people_page/easy_unlock_browser_proxy.js
[modify] https://crrev.com/c9094c99449adbde1ed817b9c3af33cd9b07506d/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/c9094c99449adbde1ed817b9c3af33cd9b07506d/chrome/browser/resources/settings/people_page/lock_screen.js
[modify] https://crrev.com/c9094c99449adbde1ed817b9c3af33cd9b07506d/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/c9094c99449adbde1ed817b9c3af33cd9b07506d/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc
[modify] https://crrev.com/c9094c99449adbde1ed817b9c3af33cd9b07506d/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h
[modify] https://crrev.com/c9094c99449adbde1ed817b9c3af33cd9b07506d/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0151fd7c56ecc6e906b1a45c00ba2f793458ee91

commit 0151fd7c56ecc6e906b1a45c00ba2f793458ee91
Author: James Hawkins <jhawkins@chromium.org>
Date: Thu Nov 01 21:50:52 2018

Smart Lock: Remove Unused EasyUnlockAppManager.

The remaining call sites just (re)loaded/disabled the app but did not
use any of the app for functionality.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Idf93dea3d8dd6fbff5e842c283055ab67bc2b779
Reviewed-on: https://chromium-review.googlesource.com/c/1312301
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604717}
[modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/browser/chromeos/BUILD.gn
[delete] https://crrev.com/87bded8e04f6e4b91d6a9cb948f2277fa9977b7f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager.cc
[delete] https://crrev.com/87bded8e04f6e4b91d6a9cb948f2277fa9977b7f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager.h
[delete] https://crrev.com/87bded8e04f6e4b91d6a9cb948f2277fa9977b7f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager_unittest.cc
[modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h
[modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_factory.cc
[modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.h
[modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_unittest_chromeos.cc
[modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/test/BUILD.gn

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1163df95c26954b75bff51caa4fce3a2c3832433

commit 1163df95c26954b75bff51caa4fce3a2c3832433
Author: James Hawkins <jhawkins@chromium.org>
Date: Fri Nov 02 19:41:50 2018

Smart Lock: Remove unused service observer methods.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Ic0e717072a242ab397aad86a5ce651d4ea7de970
Reviewed-on: https://chromium-review.googlesource.com/c/1315488
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605018}
[modify] https://crrev.com/1163df95c26954b75bff51caa4fce3a2c3832433/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/1163df95c26954b75bff51caa4fce3a2c3832433/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h

Project Member

Comment 17 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35ff0677f58b46ae0be755d9cc3a816af62711e0

commit 35ff0677f58b46ae0be755d9cc3a816af62711e0
Author: James Hawkins <jhawkins@chromium.org>
Date: Fri Nov 02 19:44:51 2018

Smart Lock: Remove EasyUnlock app monitoring.

The app doesn't change state anymore so there is nothing to monitor.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I7daa43cb9137e37b3f38cece458d7aa921239f46
Reviewed-on: https://chromium-review.googlesource.com/c/1315351
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605019}
[modify] https://crrev.com/35ff0677f58b46ae0be755d9cc3a816af62711e0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/35ff0677f58b46ae0be755d9cc3a816af62711e0/chrome/common/extensions/extension_constants.cc
[modify] https://crrev.com/35ff0677f58b46ae0be755d9cc3a816af62711e0/chrome/common/extensions/extension_constants.h

Project Member

Comment 18 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/523e9b8e56a22808d4b60227fa653a8f30ffc1f1

commit 523e9b8e56a22808d4b60227fa653a8f30ffc1f1
Author: James Hawkins <jhawkins@chromium.org>
Date: Mon Nov 05 16:46:58 2018

Smart Lock: Remove unused strings.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I7a7c5f4c56029da02a0d14c2351115cbdd7fbcc9
Reviewed-on: https://chromium-review.googlesource.com/c/1316101
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605356}
[modify] https://crrev.com/523e9b8e56a22808d4b60227fa653a8f30ffc1f1/chrome/app/chromeos_strings.grdp

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e95be812a3336c85ea972cbfc2377bf648d2287

commit 3e95be812a3336c85ea972cbfc2377bf648d2287
Author: James Hawkins <jhawkins@chromium.org>
Date: Mon Nov 05 19:29:23 2018

Smart Lock: Remove two unused includes.

R=nohle@chromium.org

Bug: 899324
Test: none
Change-Id: I6ef5f75f6f7c051a7174c8d04ff45f0788e21258
Reviewed-on: https://chromium-review.googlesource.com/c/1318074
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605411}
[modify] https://crrev.com/3e95be812a3336c85ea972cbfc2377bf648d2287/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c390b84177cf3173d1f55ac7fc7d1c47c122655

commit 5c390b84177cf3173d1f55ac7fc7d1c47c122655
Author: James Hawkins <jhawkins@chromium.org>
Date: Tue Nov 06 01:20:37 2018

Smart Lock: Remove unused EasyUnlock V1 settings.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I50f48538f781edde9489e7067bdd3558d7b5525c
Reviewed-on: https://chromium-review.googlesource.com/c/1315955
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605556}
[modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/browser/resources/settings/people_page/lock_screen.js
[modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/82b903b50d058ac617d69638be67add2e34ff0a7/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc
[delete] https://crrev.com/82b903b50d058ac617d69638be67add2e34ff0a7/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h
[delete] https://crrev.com/82b903b50d058ac617d69638be67add2e34ff0a7/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc
[modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/test/data/webui/settings/people_page_test.js

Project Member

Comment 23 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2756e0a7572b056c24325d909755ca512446abb0

commit 2756e0a7572b056c24325d909755ca512446abb0
Author: James Hawkins <jhawkins@chromium.org>
Date: Thu Nov 08 16:39:34 2018

Proximity Auth: Remove kMultiDeviceApi flagging in Messenger.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I500b7249e5d7d87b028c1446cfb28f4d4159f7df
Reviewed-on: https://chromium-review.googlesource.com/c/1325215
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606496}
[modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/fake_remote_device_life_cycle.cc
[modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/fake_remote_device_life_cycle.h
[modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/messenger.h
[modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/messenger_impl.cc
[modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/messenger_impl.h
[modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/messenger_impl_unittest.cc
[modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/remote_device_life_cycle.h
[modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/remote_device_life_cycle_impl.cc
[modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/remote_device_life_cycle_impl.h
[modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc
[modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/unlock_manager_impl.cc
[modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/unlock_manager_impl_unittest.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c1193a01aec5445d435abf698732c444edd4c1f

commit 4c1193a01aec5445d435abf698732c444edd4c1f
Author: James Hawkins <jhawkins@chromium.org>
Date: Thu Nov 08 17:25:44 2018

Proximity Auth: Remove kMultiDeviceApi flagging from UnlockManagerImpl.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Idc3b7e4bb138d0c81066f6e32af97bd67979e8c4
Reviewed-on: https://chromium-review.googlesource.com/c/1325349
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606510}
[modify] https://crrev.com/4c1193a01aec5445d435abf698732c444edd4c1f/chromeos/components/proximity_auth/unlock_manager_impl.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14e753e8ab0e6ad9212fc862d88f50380a83aa95

commit 14e753e8ab0e6ad9212fc862d88f50380a83aa95
Author: James Hawkins <jhawkins@chromium.org>
Date: Thu Nov 08 17:33:42 2018

Smart Lock: Remove easy_unlock_private_api.

This is now unused.

R=tbarzic@chromium.org
TBR=droger@chromium.org

TBRing David for the removal of EnsureAPIBrowserContextKeyedServiceFactoriesBuilt() from chrome_browser_main_extra_parts_profiles.cc.

Bug: 899324
Test: none
Change-Id: Ife19019fd8b05dfcd627e92167f485e96401662b
Reviewed-on: https://chromium-review.googlesource.com/c/1319340
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606516}
[modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/WATCHLISTS
[modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/browser/apps/platform_apps/api/BUILD.gn
[delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/browser_context_keyed_service_factories.cc
[delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/browser_context_keyed_service_factories.h
[delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/OWNERS
[delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_api.cc
[delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_api.h
[delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc
[delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_connection.cc
[delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_connection.h
[delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_connection_manager.cc
[delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_connection_manager.h
[modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/common/apps/platform_apps/api/_api_features.json
[modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/common/apps/platform_apps/api/_permission_features.json
[modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/common/apps/platform_apps/api/api_sources.gni
[delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/common/apps/platform_apps/api/easy_unlock_private.idl
[modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/common/apps/platform_apps/chrome_apps_api_permissions.cc
[modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/common/extensions/permissions/permission_set_unittest.cc
[modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/test/BUILD.gn
[modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/extensions/browser/extension_event_histogram_value.h
[modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/extensions/common/permissions/api_permission.h
[modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/tools/metrics/histograms/enums.xml

Project Member

Comment 27 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b445fc957b9ca1a4da3ce91650b79bdbd1617f3

commit 7b445fc957b9ca1a4da3ce91650b79bdbd1617f3
Author: James Hawkins <jhawkins@chromium.org>
Date: Thu Nov 08 17:34:51 2018

Proximity Auth: Remove kMultiDeviceApi flagging from ProximityAuthSystem.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I0738957fbcdb63da03152d852cf20e02603f7924
Reviewed-on: https://chromium-review.googlesource.com/c/1325429
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606518}
[modify] https://crrev.com/7b445fc957b9ca1a4da3ce91650b79bdbd1617f3/chromeos/components/proximity_auth/proximity_auth_system.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e24118ce26b6871edd171c97e48f1dd81a88ddf

commit 9e24118ce26b6871edd171c97e48f1dd81a88ddf
Author: James Hawkins <jhawkins@chromium.org>
Date: Thu Nov 08 18:49:44 2018

Smart Lock: Remove unused strings.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Ib1c2d571dffddf742276c28875275abe790724f1
Reviewed-on: https://chromium-review.googlesource.com/c/1321149
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606551}
[modify] https://crrev.com/9e24118ce26b6871edd171c97e48f1dd81a88ddf/chrome/app/chromeos_strings.grdp

Project Member

Comment 30 by bugdroid1@chromium.org, Nov 8

Project Member

Comment 33 by bugdroid1@chromium.org, Nov 9

Project Member

Comment 35 by bugdroid1@chromium.org, Nov 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e94e6a76822e8b76a8a9a8eb00d6e6bb2172ba00

commit e94e6a76822e8b76a8a9a8eb00d6e6bb2172ba00
Author: James Hawkins <jhawkins@chromium.org>
Date: Sat Nov 10 01:00:39 2018

Proximity Auth: Remove unused cryptauth deps from RDLCI test.

R=khorimoto@chromium.org

Bug: 899324
Test: none
Change-Id: I7c06a44ad5aa7bc3dc9ff2249fa819551b942088
Reviewed-on: https://chromium-review.googlesource.com/c/1330807
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607055}
[modify] https://crrev.com/e94e6a76822e8b76a8a9a8eb00d6e6bb2172ba00/chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60366ceeafc0161b11a85614eef2d24c6604cd7e

commit 60366ceeafc0161b11a85614eef2d24c6604cd7e
Author: James Hawkins <jhawkins@chromium.org>
Date: Mon Nov 12 17:04:16 2018

CryptAuth: Remove unused FakeCryptAuthDeviceIdProvider.

R=khorimoto@chromium.org

Bug: 899324
Test: none
Change-Id: I764a9dc6f2d38f896a8d7ec41f15a834e5bbba85
Reviewed-on: https://chromium-review.googlesource.com/c/1330842
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607271}
[modify] https://crrev.com/60366ceeafc0161b11a85614eef2d24c6604cd7e/components/cryptauth/BUILD.gn
[delete] https://crrev.com/ce58bfa0bccae56fffff5e79aecab69960afcd88/components/cryptauth/fake_cryptauth_device_id_provider.cc
[delete] https://crrev.com/ce58bfa0bccae56fffff5e79aecab69960afcd88/components/cryptauth/fake_cryptauth_device_id_provider.h

Project Member

Comment 39 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ee94ddd6ab24f7643910f343e35e2d27e9fcc03

commit 2ee94ddd6ab24f7643910f343e35e2d27e9fcc03
Author: James Hawkins <jhawkins@chromium.org>
Date: Mon Nov 12 17:04:42 2018

CryptAuth: Remove unused CalculateDeviceUserId.

R=khorimoto@chromium.org

Bug: 899324
Test: none
Change-Id: Ia4d3093f9f70dd3aeeb0a49d87475bc3f4f2c58d
Reviewed-on: https://chromium-review.googlesource.com/c/1330891
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607272}
[modify] https://crrev.com/2ee94ddd6ab24f7643910f343e35e2d27e9fcc03/components/cryptauth/cryptauth_enrollment_utils.cc
[modify] https://crrev.com/2ee94ddd6ab24f7643910f343e35e2d27e9fcc03/components/cryptauth/cryptauth_enrollment_utils.h

Project Member

Comment 40 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c1f4453b4567ebae69ca9f42fd6602e06d1b1dc

commit 6c1f4453b4567ebae69ca9f42fd6602e06d1b1dc
Author: James Hawkins <jhawkins@chromium.org>
Date: Mon Nov 12 19:25:38 2018

CryptAuth: Remove unused ConnectionFinder.

Bug: 899324
Test: none
Change-Id: I30f07136ac7c3ed3ac49b678e5f45d250fcbe65f
Reviewed-on: https://chromium-review.googlesource.com/c/1331573
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607302}
[delete] https://crrev.com/dc8c60c35aac283f098567ec35045b821b9590c7/components/cryptauth/connection_finder.h

Project Member

Comment 41 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23ba3a17fb2e90137d3f6095b5ba42a047403edd

commit 23ba3a17fb2e90137d3f6095b5ba42a047403edd
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Mon Nov 12 19:54:46 2018

Revert "CryptAuth: Remove unused ConnectionFinder."

This reverts commit 6c1f4453b4567ebae69ca9f42fd6602e06d1b1dc.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 607302 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZjMWY0NDUzYjQ1NjdlYmFlNjljYTlmNDJmZDY2MDJlMDZkMWIxZGMM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Full/109736

Sample Failed Step: compile

Original change's description:
> CryptAuth: Remove unused ConnectionFinder.
> 
> Bug: 899324
> Test: none
> Change-Id: I30f07136ac7c3ed3ac49b678e5f45d250fcbe65f
> Reviewed-on: https://chromium-review.googlesource.com/c/1331573
> Reviewed-by: Jeremy Klein <jlklein@chromium.org>
> Commit-Queue: James Hawkins <jhawkins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607302}

Change-Id: I0c821dda827a0daf2a144b60718e370c459abd6f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 899324
Reviewed-on: https://chromium-review.googlesource.com/c/1331948
Cr-Commit-Position: refs/heads/master@{#607310}
[add] https://crrev.com/23ba3a17fb2e90137d3f6095b5ba42a047403edd/components/cryptauth/connection_finder.h

Project Member

Comment 42 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a006576c66d9a17148fa56e81780ab29b8956689

commit a006576c66d9a17148fa56e81780ab29b8956689
Author: James Hawkins <jhawkins@chromium.org>
Date: Tue Nov 13 02:06:14 2018

Reland crrev.com/c/1331573 w/ build fixes in place.

Bug: 899324
Test: none

Original change description:

> CryptAuth: Remove unused ConnectionFinder.
>
> Bug: 899324
> Test: none
> Change-Id: I30f07136ac7c3ed3ac49b678e5f45d250fcbe65f
> Reviewed-on: https://chromium-review.googlesource.com/c/1331573
> Reviewed-by: Jeremy Klein <jlklein@chromium.org>
> Commit-Queue: James Hawkins <jhawkins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607302}

R=hansberry@chromium.org

Change-Id: Ia14bbe45b5b76a94c79aea5c4b687695df843163
Reviewed-on: https://chromium-review.googlesource.com/c/1333109
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607436}
[modify] https://crrev.com/a006576c66d9a17148fa56e81780ab29b8956689/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.cc
[modify] https://crrev.com/a006576c66d9a17148fa56e81780ab29b8956689/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc
[delete] https://crrev.com/15242c0c52f055089ca410881dc049f43a2c4e62/components/cryptauth/connection_finder.h

Project Member

Comment 43 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70edfcdd79bd2a400bd5b57e7bc171c45de41a69

commit 70edfcdd79bd2a400bd5b57e7bc171c45de41a69
Author: James Hawkins <jhawkins@chromium.org>
Date: Wed Nov 14 22:44:29 2018

Proximity Auth: Remove unused metrics loggers.

R=khorimoto@chromium.org

Bug: 899324
Test: none
Change-Id: I0c579f604635d89ba2b1394d5142fbb21de12560
Reviewed-on: https://chromium-review.googlesource.com/c/1330828
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608148}
[modify] https://crrev.com/70edfcdd79bd2a400bd5b57e7bc171c45de41a69/chromeos/components/proximity_auth/metrics.cc
[modify] https://crrev.com/70edfcdd79bd2a400bd5b57e7bc171c45de41a69/chromeos/components/proximity_auth/metrics.h
[modify] https://crrev.com/70edfcdd79bd2a400bd5b57e7bc171c45de41a69/tools/metrics/histograms/histograms.xml

Sign in to add a comment