With unified setup out the door, we can remove the old EasyUnlock code (app, easyunlock private API, etc).
AFAIK, easy unlock app is the only client for screenLockPrivate API - if so, that one should be removed, too
tbarzic: Yep, that's the plan!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bb8dfd77b1beb144e2b9af52c24fe2e0925ec8f commit 3bb8dfd77b1beb144e2b9af52c24fe2e0925ec8f Author: James Hawkins <jhawkins@chromium.org> Date: Fri Oct 26 22:50:55 2018 Smart Lock: Remove unused promo notification code. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I762ae359249c60481ba4866703aa1e7fbbc6552e Reviewed-on: https://chromium-review.googlesource.com/c/1302330 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#603234} [delete] https://crrev.com/2e46681d6ef261bde61742357e93bf358b7c1e0a/chrome/app/theme/default_100_percent/cros/notification_easyunlock_promo.png [delete] https://crrev.com/2e46681d6ef261bde61742357e93bf358b7c1e0a/chrome/app/theme/default_200_percent/cros/notification_easyunlock_promo.png [modify] https://crrev.com/3bb8dfd77b1beb144e2b9af52c24fe2e0925ec8f/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/3bb8dfd77b1beb144e2b9af52c24fe2e0925ec8f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.cc [modify] https://crrev.com/3bb8dfd77b1beb144e2b9af52c24fe2e0925ec8f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.h [modify] https://crrev.com/3bb8dfd77b1beb144e2b9af52c24fe2e0925ec8f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller_chromeos_unittest.cc [modify] https://crrev.com/3bb8dfd77b1beb144e2b9af52c24fe2e0925ec8f/chromeos/components/proximity_auth/notification_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/218f9a3be029f649fad25e02d89abdd42affed18 commit 218f9a3be029f649fad25e02d89abdd42affed18 Author: James Hawkins <jhawkins@chromium.org> Date: Mon Oct 29 19:29:16 2018 Smart Lock: Remove RecordClickOnLockIcon. This was only used for the EasyUnlock trial which is currently unused and about to be removed. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ic3b7271a386d26728e7af4e4ea56dfdd6b19c675 Reviewed-on: https://chromium-review.googlesource.com/c/1302696 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#603586} [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/ash/login/login_screen_controller.cc [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/ash/login/login_screen_controller.h [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/ash/login/login_screen_controller_unittest.cc [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/ash/login/mock_login_screen_client.h [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/ash/public/interfaces/login_screen.mojom [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.cc [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.h [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler_unittest.cc [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/lock/views_screen_locker.cc [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/lock/views_screen_locker.h [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/screens/user_selection_screen.cc [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/screens/user_selection_screen.h [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/chromeos/login/ui/login_display_host_mojo.h [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/ui/ash/login_screen_client.cc [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/ui/ash/login_screen_client.h [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.cc [modify] https://crrev.com/218f9a3be029f649fad25e02d89abdd42affed18/chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c491d560e79043e204bdf81126fa4fd54f211f6 commit 0c491d560e79043e204bdf81126fa4fd54f211f6 Author: James Hawkins <jhawkins@chromium.org> Date: Mon Oct 29 20:34:00 2018 Smart Lock: Remove SetTrialRun method. There is no longer a trial run in the new setup flow. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ic466140fbe18890e707f3338a38b58f385af0f2f Reviewed-on: https://chromium-review.googlesource.com/c/1302704 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#603607} [modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/ash/public/interfaces/login_user_info.mojom [modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_metrics.cc [modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_metrics.h [modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.cc [modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.h [modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler_unittest.cc [modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h [modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/chromeos/login/user_board_view_mojo.cc [modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc [modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chromeos/components/proximity_auth/screenlock_bridge.cc [modify] https://crrev.com/0c491d560e79043e204bdf81126fa4fd54f211f6/chromeos/components/proximity_auth/screenlock_bridge.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/665e73505703afdd017085f3121258c6d9a7fa20 commit 665e73505703afdd017085f3121258c6d9a7fa20 Author: James Hawkins <jhawkins@chromium.org> Date: Tue Oct 30 01:16:55 2018 Smart Lock: Remove EasyUnlock V1 setup button. The turn-off flow will be removed in a follow-up CL. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ie6ac355c020ca428d49b67c1f9c65e1103e666ad Reviewed-on: https://chromium-review.googlesource.com/c/1306833 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#603717} [modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h [modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc [modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h [modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc [modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.h [modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/resources/settings/people_page/easy_unlock_browser_proxy.js [modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/resources/settings/people_page/lock_screen.html [modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/resources/settings/people_page/lock_screen.js [modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc [modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc [modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/665e73505703afdd017085f3121258c6d9a7fa20/chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab31d75022a96b699ddf28d3ff8ebfbe577bdb90 commit ab31d75022a96b699ddf28d3ff8ebfbe577bdb90 Author: James Hawkins <jhawkins@chromium.org> Date: Tue Oct 30 17:54:35 2018 Smart Lock: Remove unused OpenSetupAppAfterReauth. Bug: 899324 Test: none Change-Id: I9f632473636f6a6df3e2528a957adadda006a176 Reviewed-on: https://chromium-review.googlesource.com/c/1307236 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#603956} [modify] https://crrev.com/ab31d75022a96b699ddf28d3ff8ebfbe577bdb90/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc [modify] https://crrev.com/ab31d75022a96b699ddf28d3ff8ebfbe577bdb90/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/feb61914cd18ac1b6d697f455e574eba1a1645c3 commit feb61914cd18ac1b6d697f455e574eba1a1645c3 Author: James Hawkins <jhawkins@chromium.org> Date: Tue Oct 30 20:47:32 2018 Smart Lock: Remove the 'turn off' functionality from EasyUnlock V1. R=dpapad@chromium.org, hansberry@chromium.org Bug: 899324 Test: none Change-Id: I01b9786b3e5f49490660829bd1c3a7659e73f9c7 Reviewed-on: https://chromium-review.googlesource.com/c/1306916 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#604003} [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_observer.h [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.h [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/resources/settings/people_page/BUILD.gn [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/resources/settings/people_page/easy_unlock_browser_proxy.js [delete] https://crrev.com/4f64b82677f39d0b8feb880e781fd0d5c7efa75d/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html [delete] https://crrev.com/4f64b82677f39d0b8feb880e781fd0d5c7efa75d/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/resources/settings/people_page/lock_screen.html [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/resources/settings/people_page/lock_screen.js [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/feb61914cd18ac1b6d697f455e574eba1a1645c3/chrome/test/data/webui/BUILD.gn [delete] https://crrev.com/4f64b82677f39d0b8feb880e781fd0d5c7efa75d/chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b392bbf3408afacba96358e1e0b7ded000be4a64 commit b392bbf3408afacba96358e1e0b7ded000be4a64 Author: James Hawkins <jhawkins@chromium.org> Date: Wed Oct 31 15:55:08 2018 Smart LocK: Remove unused observer OnScreenLockStateChanged. Since is the last method on EasyUnlockServiceObserver, that interface is also removed. Bug: 899324 Test: none Change-Id: Idf4c4136ec97431a5ceaa6d9a3c69a5a782b7882 Reviewed-on: https://chromium-review.googlesource.com/c/1307068 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#604271} [modify] https://crrev.com/b392bbf3408afacba96358e1e0b7ded000be4a64/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [delete] https://crrev.com/9f61c8347bc424d4a49e821a3752c03a1d81ecb6/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_observer.h [modify] https://crrev.com/b392bbf3408afacba96358e1e0b7ded000be4a64/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7cdff063ccabf78ab0d056dd47da671cccdade3 commit e7cdff063ccabf78ab0d056dd47da671cccdade3 Author: James Hawkins <jhawkins@chromium.org> Date: Wed Oct 31 15:56:16 2018 Smart Lock: Remove authentication caching mechanism. The EasyUnlock V1 setup flow is being removed, so this caching mechanism is not necessary at the moment and helps break up the removal change. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I7a15a78d95edf5585636dc398f708fa12a7e0bc7 Reviewed-on: https://chromium-review.googlesource.com/c/1306348 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#604272} [modify] https://crrev.com/e7cdff063ccabf78ab0d056dd47da671cccdade3/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/e7cdff063ccabf78ab0d056dd47da671cccdade3/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc [modify] https://crrev.com/e7cdff063ccabf78ab0d056dd47da671cccdade3/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc [modify] https://crrev.com/e7cdff063ccabf78ab0d056dd47da671cccdade3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/e7cdff063ccabf78ab0d056dd47da671cccdade3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h [modify] https://crrev.com/e7cdff063ccabf78ab0d056dd47da671cccdade3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc [modify] https://crrev.com/e7cdff063ccabf78ab0d056dd47da671cccdade3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h [delete] https://crrev.com/b392bbf3408afacba96358e1e0b7ded000be4a64/chrome/browser/chromeos/login/easy_unlock/short_lived_user_context.cc [delete] https://crrev.com/b392bbf3408afacba96358e1e0b7ded000be4a64/chrome/browser/chromeos/login/easy_unlock/short_lived_user_context.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba75dd4d6e1feb0faa33e24f26b3ff6168f686be commit ba75dd4d6e1feb0faa33e24f26b3ff6168f686be Author: James Hawkins <jhawkins@chromium.org> Date: Thu Nov 01 02:10:55 2018 Smart Lock: Remove unused methods from EasyUnlockAppManager. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I2c85ce8fcd794998583c7b5bb63a51b3e90ce450 Reviewed-on: https://chromium-review.googlesource.com/c/1312295 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#604488} [modify] https://crrev.com/ba75dd4d6e1feb0faa33e24f26b3ff6168f686be/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager.cc [modify] https://crrev.com/ba75dd4d6e1feb0faa33e24f26b3ff6168f686be/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager.h [modify] https://crrev.com/ba75dd4d6e1feb0faa33e24f26b3ff6168f686be/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager_unittest.cc [modify] https://crrev.com/ba75dd4d6e1feb0faa33e24f26b3ff6168f686be/chrome/browser/chromeos/login/easy_unlock/easy_unlock_auth_attempt_unittest.cc [modify] https://crrev.com/ba75dd4d6e1feb0faa33e24f26b3ff6168f686be/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_unittest_chromeos.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf commit d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf Author: James Hawkins <jhawkins@chromium.org> Date: Thu Nov 01 17:22:45 2018 Smart Lock: Remove SendAuthAttempt calls. This method did nothing given that no event listener was registered for the auth attempt listener in the WebUI. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I4f46d553ee95538a468b05a434f609ab60c7ca52 Reviewed-on: https://chromium-review.googlesource.com/c/1312300 Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#604625} [modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager.cc [modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager.h [modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager_unittest.cc [modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_auth_attempt.cc [modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_auth_attempt.h [modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_auth_attempt_unittest.cc [modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_unittest_chromeos.cc [modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc [modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h [modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc [modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/chrome/common/extensions/api/screenlock_private.idl [delete] https://crrev.com/5f2cc6d8103e545960e56f845cbfa97268d5f2b6/chrome/test/data/extensions/api_test/screenlock_private/auth_type/manifest.json [delete] https://crrev.com/5f2cc6d8103e545960e56f845cbfa97268d5f2b6/chrome/test/data/extensions/api_test/screenlock_private/auth_type/test.js [modify] https://crrev.com/d3f959d3dae4cbe1a289d6e60d7dc0dbad8cdaaf/extensions/browser/extension_event_histogram_value.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9094c99449adbde1ed817b9c3af33cd9b07506d commit c9094c99449adbde1ed817b9c3af33cd9b07506d Author: James Hawkins <jhawkins@chromium.org> Date: Thu Nov 01 17:42:35 2018 Smart Lock: Remove EasyUnlockBrowserProxy. The get*Enabled method is no longer called in release. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I91261c61ae5f666cf45c14e6c71512f3a7c70a42 Reviewed-on: https://chromium-review.googlesource.com/c/1312094 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#604631} [modify] https://crrev.com/c9094c99449adbde1ed817b9c3af33cd9b07506d/chrome/browser/resources/settings/people_page/BUILD.gn [delete] https://crrev.com/56d152ff60b364132d7caf2f456c0d06bf2cfe6f/chrome/browser/resources/settings/people_page/easy_unlock_browser_proxy.html [delete] https://crrev.com/56d152ff60b364132d7caf2f456c0d06bf2cfe6f/chrome/browser/resources/settings/people_page/easy_unlock_browser_proxy.js [modify] https://crrev.com/c9094c99449adbde1ed817b9c3af33cd9b07506d/chrome/browser/resources/settings/people_page/lock_screen.html [modify] https://crrev.com/c9094c99449adbde1ed817b9c3af33cd9b07506d/chrome/browser/resources/settings/people_page/lock_screen.js [modify] https://crrev.com/c9094c99449adbde1ed817b9c3af33cd9b07506d/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/c9094c99449adbde1ed817b9c3af33cd9b07506d/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc [modify] https://crrev.com/c9094c99449adbde1ed817b9c3af33cd9b07506d/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h [modify] https://crrev.com/c9094c99449adbde1ed817b9c3af33cd9b07506d/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0151fd7c56ecc6e906b1a45c00ba2f793458ee91 commit 0151fd7c56ecc6e906b1a45c00ba2f793458ee91 Author: James Hawkins <jhawkins@chromium.org> Date: Thu Nov 01 21:50:52 2018 Smart Lock: Remove Unused EasyUnlockAppManager. The remaining call sites just (re)loaded/disabled the app but did not use any of the app for functionality. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Idf93dea3d8dd6fbff5e842c283055ab67bc2b779 Reviewed-on: https://chromium-review.googlesource.com/c/1312301 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#604717} [modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/browser/chromeos/BUILD.gn [delete] https://crrev.com/87bded8e04f6e4b91d6a9cb948f2277fa9977b7f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager.cc [delete] https://crrev.com/87bded8e04f6e4b91d6a9cb948f2277fa9977b7f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager.h [delete] https://crrev.com/87bded8e04f6e4b91d6a9cb948f2277fa9977b7f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager_unittest.cc [modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h [modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_factory.cc [modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc [modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.h [modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_unittest_chromeos.cc [modify] https://crrev.com/0151fd7c56ecc6e906b1a45c00ba2f793458ee91/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1163df95c26954b75bff51caa4fce3a2c3832433 commit 1163df95c26954b75bff51caa4fce3a2c3832433 Author: James Hawkins <jhawkins@chromium.org> Date: Fri Nov 02 19:41:50 2018 Smart Lock: Remove unused service observer methods. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ic0e717072a242ab397aad86a5ce651d4ea7de970 Reviewed-on: https://chromium-review.googlesource.com/c/1315488 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#605018} [modify] https://crrev.com/1163df95c26954b75bff51caa4fce3a2c3832433/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/1163df95c26954b75bff51caa4fce3a2c3832433/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35ff0677f58b46ae0be755d9cc3a816af62711e0 commit 35ff0677f58b46ae0be755d9cc3a816af62711e0 Author: James Hawkins <jhawkins@chromium.org> Date: Fri Nov 02 19:44:51 2018 Smart Lock: Remove EasyUnlock app monitoring. The app doesn't change state anymore so there is nothing to monitor. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I7daa43cb9137e37b3f38cece458d7aa921239f46 Reviewed-on: https://chromium-review.googlesource.com/c/1315351 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#605019} [modify] https://crrev.com/35ff0677f58b46ae0be755d9cc3a816af62711e0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/35ff0677f58b46ae0be755d9cc3a816af62711e0/chrome/common/extensions/extension_constants.cc [modify] https://crrev.com/35ff0677f58b46ae0be755d9cc3a816af62711e0/chrome/common/extensions/extension_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/523e9b8e56a22808d4b60227fa653a8f30ffc1f1 commit 523e9b8e56a22808d4b60227fa653a8f30ffc1f1 Author: James Hawkins <jhawkins@chromium.org> Date: Mon Nov 05 16:46:58 2018 Smart Lock: Remove unused strings. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I7a7c5f4c56029da02a0d14c2351115cbdd7fbcc9 Reviewed-on: https://chromium-review.googlesource.com/c/1316101 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#605356} [modify] https://crrev.com/523e9b8e56a22808d4b60227fa653a8f30ffc1f1/chrome/app/chromeos_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e95be812a3336c85ea972cbfc2377bf648d2287 commit 3e95be812a3336c85ea972cbfc2377bf648d2287 Author: James Hawkins <jhawkins@chromium.org> Date: Mon Nov 05 19:29:23 2018 Smart Lock: Remove two unused includes. R=nohle@chromium.org Bug: 899324 Test: none Change-Id: I6ef5f75f6f7c051a7174c8d04ff45f0788e21258 Reviewed-on: https://chromium-review.googlesource.com/c/1318074 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#605411} [modify] https://crrev.com/3e95be812a3336c85ea972cbfc2377bf648d2287/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c390b84177cf3173d1f55ac7fc7d1c47c122655 commit 5c390b84177cf3173d1f55ac7fc7d1c47c122655 Author: James Hawkins <jhawkins@chromium.org> Date: Tue Nov 06 01:20:37 2018 Smart Lock: Remove unused EasyUnlock V1 settings. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I50f48538f781edde9489e7067bdd3558d7b5525c Reviewed-on: https://chromium-review.googlesource.com/c/1315955 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#605556} [modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/browser/resources/settings/people_page/lock_screen.html [modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/browser/resources/settings/people_page/lock_screen.js [modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/82b903b50d058ac617d69638be67add2e34ff0a7/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc [delete] https://crrev.com/82b903b50d058ac617d69638be67add2e34ff0a7/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h [delete] https://crrev.com/82b903b50d058ac617d69638be67add2e34ff0a7/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc [modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/browser/ui/webui/settings/md_settings_ui.cc [modify] https://crrev.com/5c390b84177cf3173d1f55ac7fc7d1c47c122655/chrome/test/data/webui/settings/people_page_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2c76c0dabc3bd497715165bcf209e5a94ded497 commit e2c76c0dabc3bd497715165bcf209e5a94ded497 Author: James Hawkins <jhawkins@chromium.org> Date: Tue Nov 06 18:22:36 2018 Smart Lock: Remove deprecated test files. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I300f9e21a19abdfff93b8a70a21cec6dac00db31 Reviewed-on: https://chromium-review.googlesource.com/c/1319338 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#605747} [delete] https://crrev.com/d86841e2fe2b3eda485a350a7ef44a489f15009e/chrome/test/data/login/easy_unlock/auth_code_login.html [delete] https://crrev.com/d86841e2fe2b3eda485a350a7ef44a489f15009e/chrome/test/data/login/easy_unlock/auto_pair_failure/easy_unlock_background.js [delete] https://crrev.com/d86841e2fe2b3eda485a350a7ef44a489f15009e/chrome/test/data/login/easy_unlock/auto_pair_success/easy_unlock_background.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/930c435dc98354829a40023fb5f43c6cb046a1f2 commit 930c435dc98354829a40023fb5f43c6cb046a1f2 Author: James Hawkins <jhawkins@chromium.org> Date: Thu Nov 08 00:49:33 2018 Smart Lock: Remove unused EasyUnlockReauth. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I4d1f6b4f7eec6ec938360dd955ce37b9df4a5914 Reviewed-on: https://chromium-review.googlesource.com/c/1325031 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#606258} [modify] https://crrev.com/930c435dc98354829a40023fb5f43c6cb046a1f2/chrome/browser/chromeos/BUILD.gn [delete] https://crrev.com/65ccf613b9cf4b98d2d8af520899bed36a24d901/chrome/browser/chromeos/login/easy_unlock/easy_unlock_reauth.cc [delete] https://crrev.com/65ccf613b9cf4b98d2d8af520899bed36a24d901/chrome/browser/chromeos/login/easy_unlock/easy_unlock_reauth.h [modify] https://crrev.com/930c435dc98354829a40023fb5f43c6cb046a1f2/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2756e0a7572b056c24325d909755ca512446abb0 commit 2756e0a7572b056c24325d909755ca512446abb0 Author: James Hawkins <jhawkins@chromium.org> Date: Thu Nov 08 16:39:34 2018 Proximity Auth: Remove kMultiDeviceApi flagging in Messenger. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I500b7249e5d7d87b028c1446cfb28f4d4159f7df Reviewed-on: https://chromium-review.googlesource.com/c/1325215 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#606496} [modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/fake_remote_device_life_cycle.cc [modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/fake_remote_device_life_cycle.h [modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/messenger.h [modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/messenger_impl.cc [modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/messenger_impl.h [modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/messenger_impl_unittest.cc [modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/remote_device_life_cycle.h [modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/remote_device_life_cycle_impl.cc [modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/remote_device_life_cycle_impl.h [modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc [modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/unlock_manager_impl.cc [modify] https://crrev.com/2756e0a7572b056c24325d909755ca512446abb0/chromeos/components/proximity_auth/unlock_manager_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c63d2c39442ad2bbec49bbfe6e393a38a7d7fcf commit 1c63d2c39442ad2bbec49bbfe6e393a38a7d7fcf Author: James Hawkins <jhawkins@chromium.org> Date: Thu Nov 08 16:56:49 2018 Proximity Auth: Remove kMultiDeviceApi flagging from RDLI. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ib749683f19dad9fad2e0917673f319acb8bb3983 Reviewed-on: https://chromium-review.googlesource.com/c/1325310 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#606500} [modify] https://crrev.com/1c63d2c39442ad2bbec49bbfe6e393a38a7d7fcf/chromeos/components/proximity_auth/remote_device_life_cycle_impl.cc [modify] https://crrev.com/1c63d2c39442ad2bbec49bbfe6e393a38a7d7fcf/chromeos/components/proximity_auth/remote_device_life_cycle_impl.h [modify] https://crrev.com/1c63d2c39442ad2bbec49bbfe6e393a38a7d7fcf/chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c1193a01aec5445d435abf698732c444edd4c1f commit 4c1193a01aec5445d435abf698732c444edd4c1f Author: James Hawkins <jhawkins@chromium.org> Date: Thu Nov 08 17:25:44 2018 Proximity Auth: Remove kMultiDeviceApi flagging from UnlockManagerImpl. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Idc3b7e4bb138d0c81066f6e32af97bd67979e8c4 Reviewed-on: https://chromium-review.googlesource.com/c/1325349 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#606510} [modify] https://crrev.com/4c1193a01aec5445d435abf698732c444edd4c1f/chromeos/components/proximity_auth/unlock_manager_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14e753e8ab0e6ad9212fc862d88f50380a83aa95 commit 14e753e8ab0e6ad9212fc862d88f50380a83aa95 Author: James Hawkins <jhawkins@chromium.org> Date: Thu Nov 08 17:33:42 2018 Smart Lock: Remove easy_unlock_private_api. This is now unused. R=tbarzic@chromium.org TBR=droger@chromium.org TBRing David for the removal of EnsureAPIBrowserContextKeyedServiceFactoriesBuilt() from chrome_browser_main_extra_parts_profiles.cc. Bug: 899324 Test: none Change-Id: Ife19019fd8b05dfcd627e92167f485e96401662b Reviewed-on: https://chromium-review.googlesource.com/c/1319340 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#606516} [modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/WATCHLISTS [modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/browser/apps/platform_apps/api/BUILD.gn [delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/browser_context_keyed_service_factories.cc [delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/browser_context_keyed_service_factories.h [delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/OWNERS [delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_api.cc [delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_api.h [delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc [delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_connection.cc [delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_connection.h [delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_connection_manager.cc [delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/browser/apps/platform_apps/api/easy_unlock_private/easy_unlock_private_connection_manager.h [modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc [modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc [modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/common/apps/platform_apps/api/_api_features.json [modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/common/apps/platform_apps/api/_permission_features.json [modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/common/apps/platform_apps/api/api_sources.gni [delete] https://crrev.com/2b6197eb9948156d2877087345bbc9a38100ca31/chrome/common/apps/platform_apps/api/easy_unlock_private.idl [modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/common/apps/platform_apps/chrome_apps_api_permissions.cc [modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/common/extensions/permissions/permission_set_unittest.cc [modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/chrome/test/BUILD.gn [modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/extensions/browser/extension_event_histogram_value.h [modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/extensions/common/permissions/api_permission.h [modify] https://crrev.com/14e753e8ab0e6ad9212fc862d88f50380a83aa95/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b445fc957b9ca1a4da3ce91650b79bdbd1617f3 commit 7b445fc957b9ca1a4da3ce91650b79bdbd1617f3 Author: James Hawkins <jhawkins@chromium.org> Date: Thu Nov 08 17:34:51 2018 Proximity Auth: Remove kMultiDeviceApi flagging from ProximityAuthSystem. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I0738957fbcdb63da03152d852cf20e02603f7924 Reviewed-on: https://chromium-review.googlesource.com/c/1325429 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#606518} [modify] https://crrev.com/7b445fc957b9ca1a4da3ce91650b79bdbd1617f3/chromeos/components/proximity_auth/proximity_auth_system.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b01bada3875641ac6497eb60a65997a42963876a commit b01bada3875641ac6497eb60a65997a42963876a Author: James Hawkins <jhawkins@chromium.org> Date: Thu Nov 08 17:53:44 2018 Smart Lock: Remove unused BleSetupConnectionFinder. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ib2089db12d37b7da709909dd797a695a2f1e8a8d Reviewed-on: https://chromium-review.googlesource.com/c/1324872 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#606527} [modify] https://crrev.com/b01bada3875641ac6497eb60a65997a42963876a/chromeos/components/proximity_auth/BUILD.gn [delete] https://crrev.com/ba46f11f0f8e7ee0c1a5fa0a1023630c784a3beb/chromeos/components/proximity_auth/bluetooth_low_energy_setup_connection_finder.cc [delete] https://crrev.com/ba46f11f0f8e7ee0c1a5fa0a1023630c784a3beb/chromeos/components/proximity_auth/bluetooth_low_energy_setup_connection_finder.h [modify] https://crrev.com/b01bada3875641ac6497eb60a65997a42963876a/components/cryptauth/remote_device_ref.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e24118ce26b6871edd171c97e48f1dd81a88ddf commit 9e24118ce26b6871edd171c97e48f1dd81a88ddf Author: James Hawkins <jhawkins@chromium.org> Date: Thu Nov 08 18:49:44 2018 Smart Lock: Remove unused strings. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ib1c2d571dffddf742276c28875275abe790724f1 Reviewed-on: https://chromium-review.googlesource.com/c/1321149 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#606551} [modify] https://crrev.com/9e24118ce26b6871edd171c97e48f1dd81a88ddf/chrome/app/chromeos_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d98b722cb5b520317c9892b24845e1f9956ae1f commit 9d98b722cb5b520317c9892b24845e1f9956ae1f Author: James Hawkins <jhawkins@chromium.org> Date: Thu Nov 08 19:24:30 2018 Smart Lock: Remove unused Chrome app manifest. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I08eff200cd6d8eb2eaad989d0abcab7fc1f3d53f Reviewed-on: https://chromium-review.googlesource.com/c/1321030 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#606563} [modify] https://crrev.com/9d98b722cb5b520317c9892b24845e1f9956ae1f/chrome/browser/browser_resources.grd [modify] https://crrev.com/9d98b722cb5b520317c9892b24845e1f9956ae1f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_factory.cc [modify] https://crrev.com/9d98b722cb5b520317c9892b24845e1f9956ae1f/chrome/browser/extensions/component_extensions_whitelist/whitelist.cc [delete] https://crrev.com/5047f588f53bb793f497396bc633e4756f545a85/chrome/browser/resources/easy_unlock/OWNERS [delete] https://crrev.com/5047f588f53bb793f497396bc633e4756f545a85/chrome/browser/resources/easy_unlock/manifest.json [delete] https://crrev.com/5047f588f53bb793f497396bc633e4756f545a85/chrome/browser/resources/easy_unlock/manifest_signin.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf72a0774107216880566d82a66625c8ecbc4cae commit cf72a0774107216880566d82a66625c8ecbc4cae Author: James Hawkins <jhawkins@chromium.org> Date: Thu Nov 08 19:30:38 2018 Proximity Auth: Remove kMultiDeviceApi flagging from ProximityMonitorImpl. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I331612216739e82fb46d674aef5853b7777b7a7d Reviewed-on: https://chromium-review.googlesource.com/c/1325549 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#606564} [modify] https://crrev.com/cf72a0774107216880566d82a66625c8ecbc4cae/chromeos/components/proximity_auth/proximity_monitor_impl.cc [modify] https://crrev.com/cf72a0774107216880566d82a66625c8ecbc4cae/chromeos/components/proximity_auth/proximity_monitor_impl.h [modify] https://crrev.com/cf72a0774107216880566d82a66625c8ecbc4cae/chromeos/components/proximity_auth/proximity_monitor_impl_unittest.cc [modify] https://crrev.com/cf72a0774107216880566d82a66625c8ecbc4cae/chromeos/components/proximity_auth/unlock_manager_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7bfd5bb2031d217d0e0f87240b4ce16705abb3d commit d7bfd5bb2031d217d0e0f87240b4ce16705abb3d Author: James Hawkins <jhawkins@chromium.org> Date: Fri Nov 09 16:30:20 2018 Proximity Auth: Remove kMultiDeviceApi flagging from ProxAuthWebuiHandler. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Iac6aacb1b40608d261d6c13b12fd37bfd6b0df8f Reviewed-on: https://chromium-review.googlesource.com/c/1325393 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#606865} [modify] https://crrev.com/d7bfd5bb2031d217d0e0f87240b4ce16705abb3d/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [modify] https://crrev.com/d7bfd5bb2031d217d0e0f87240b4ce16705abb3d/chromeos/components/proximity_auth/webui/proximity_auth_ui.cc [modify] https://crrev.com/d7bfd5bb2031d217d0e0f87240b4ce16705abb3d/chromeos/components/proximity_auth/webui/proximity_auth_ui.h [modify] https://crrev.com/d7bfd5bb2031d217d0e0f87240b4ce16705abb3d/chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc [modify] https://crrev.com/d7bfd5bb2031d217d0e0f87240b4ce16705abb3d/chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/072fd3d152da154f619059436848411d22015977 commit 072fd3d152da154f619059436848411d22015977 Author: James Hawkins <jhawkins@chromium.org> Date: Fri Nov 09 20:22:29 2018 Proximity Auth: Remove final kMultiDeviceApi flagging. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ic9ea29d50b11385db9641a0d106a80b68ea0b1da Reviewed-on: https://chromium-review.googlesource.com/c/1327417 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#606949} [modify] https://crrev.com/072fd3d152da154f619059436848411d22015977/chromeos/components/proximity_auth/messenger_impl_unittest.cc [modify] https://crrev.com/072fd3d152da154f619059436848411d22015977/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager_unittest.cc [modify] https://crrev.com/072fd3d152da154f619059436848411d22015977/chromeos/components/proximity_auth/proximity_auth_system_unittest.cc [modify] https://crrev.com/072fd3d152da154f619059436848411d22015977/chromeos/components/proximity_auth/proximity_monitor_impl_unittest.cc [modify] https://crrev.com/072fd3d152da154f619059436848411d22015977/chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc [modify] https://crrev.com/072fd3d152da154f619059436848411d22015977/chromeos/components/proximity_auth/unlock_manager_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8c807e7479ae0b5da0f10871d3432c7bb0e199b commit e8c807e7479ae0b5da0f10871d3432c7bb0e199b Author: James Hawkins <jhawkins@chromium.org> Date: Sat Nov 10 00:58:31 2018 Proximity Auth: Remove kEnableUnifiedMultiDeviceSetup flagging. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I45d7f04e97a914596cd1bffd5e2ea73543064810 Reviewed-on: https://chromium-review.googlesource.com/c/1329889 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#607051} [modify] https://crrev.com/e8c807e7479ae0b5da0f10871d3432c7bb0e199b/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager.cc [modify] https://crrev.com/e8c807e7479ae0b5da0f10871d3432c7bb0e199b/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager_unittest.cc [modify] https://crrev.com/e8c807e7479ae0b5da0f10871d3432c7bb0e199b/chromeos/components/proximity_auth/proximity_auth_system_unittest.cc [modify] https://crrev.com/e8c807e7479ae0b5da0f10871d3432c7bb0e199b/chromeos/components/proximity_auth/unlock_manager_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e94e6a76822e8b76a8a9a8eb00d6e6bb2172ba00 commit e94e6a76822e8b76a8a9a8eb00d6e6bb2172ba00 Author: James Hawkins <jhawkins@chromium.org> Date: Sat Nov 10 01:00:39 2018 Proximity Auth: Remove unused cryptauth deps from RDLCI test. R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: I7c06a44ad5aa7bc3dc9ff2249fa819551b942088 Reviewed-on: https://chromium-review.googlesource.com/c/1330807 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#607055} [modify] https://crrev.com/e94e6a76822e8b76a8a9a8eb00d6e6bb2172ba00/chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/614a8f74a1a94ac414dddc0525bcdb1caad01738 commit 614a8f74a1a94ac414dddc0525bcdb1caad01738 Author: James Hawkins <jhawkins@chromium.org> Date: Sat Nov 10 01:03:57 2018 Proximity Auth: Remove unused BluetoothLowEnergeyConnectionFinder. R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: I00093b332711218ac96cca78fdfe17ab8ae7f1e7 Reviewed-on: https://chromium-review.googlesource.com/c/1330720 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#607062} [modify] https://crrev.com/614a8f74a1a94ac414dddc0525bcdb1caad01738/chromeos/components/proximity_auth/BUILD.gn [delete] https://crrev.com/3275875871d7e5dd239acbe5ac6545d51a25cb3d/chromeos/components/proximity_auth/bluetooth_low_energy_connection_finder.cc [delete] https://crrev.com/3275875871d7e5dd239acbe5ac6545d51a25cb3d/chromeos/components/proximity_auth/bluetooth_low_energy_connection_finder.h [delete] https://crrev.com/3275875871d7e5dd239acbe5ac6545d51a25cb3d/chromeos/components/proximity_auth/bluetooth_low_energy_connection_finder_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5469b5be2b41173a52eff79d258df7513a93626 commit b5469b5be2b41173a52eff79d258df7513a93626 Author: James Hawkins <jhawkins@chromium.org> Date: Sat Nov 10 02:15:01 2018 Proximity Auth: Clean up unused cruft from ProxAuthSystem. R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: I997296b1712ddebfe3ceacc69aa25e8b5fed4395 Reviewed-on: https://chromium-review.googlesource.com/c/1330835 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#607079} [modify] https://crrev.com/b5469b5be2b41173a52eff79d258df7513a93626/chromeos/components/proximity_auth/proximity_auth_system.cc [modify] https://crrev.com/b5469b5be2b41173a52eff79d258df7513a93626/chromeos/components/proximity_auth/proximity_auth_system.h [modify] https://crrev.com/b5469b5be2b41173a52eff79d258df7513a93626/chromeos/components/proximity_auth/proximity_auth_system_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60366ceeafc0161b11a85614eef2d24c6604cd7e commit 60366ceeafc0161b11a85614eef2d24c6604cd7e Author: James Hawkins <jhawkins@chromium.org> Date: Mon Nov 12 17:04:16 2018 CryptAuth: Remove unused FakeCryptAuthDeviceIdProvider. R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: I764a9dc6f2d38f896a8d7ec41f15a834e5bbba85 Reviewed-on: https://chromium-review.googlesource.com/c/1330842 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#607271} [modify] https://crrev.com/60366ceeafc0161b11a85614eef2d24c6604cd7e/components/cryptauth/BUILD.gn [delete] https://crrev.com/ce58bfa0bccae56fffff5e79aecab69960afcd88/components/cryptauth/fake_cryptauth_device_id_provider.cc [delete] https://crrev.com/ce58bfa0bccae56fffff5e79aecab69960afcd88/components/cryptauth/fake_cryptauth_device_id_provider.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ee94ddd6ab24f7643910f343e35e2d27e9fcc03 commit 2ee94ddd6ab24f7643910f343e35e2d27e9fcc03 Author: James Hawkins <jhawkins@chromium.org> Date: Mon Nov 12 17:04:42 2018 CryptAuth: Remove unused CalculateDeviceUserId. R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: Ia4d3093f9f70dd3aeeb0a49d87475bc3f4f2c58d Reviewed-on: https://chromium-review.googlesource.com/c/1330891 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#607272} [modify] https://crrev.com/2ee94ddd6ab24f7643910f343e35e2d27e9fcc03/components/cryptauth/cryptauth_enrollment_utils.cc [modify] https://crrev.com/2ee94ddd6ab24f7643910f343e35e2d27e9fcc03/components/cryptauth/cryptauth_enrollment_utils.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c1f4453b4567ebae69ca9f42fd6602e06d1b1dc commit 6c1f4453b4567ebae69ca9f42fd6602e06d1b1dc Author: James Hawkins <jhawkins@chromium.org> Date: Mon Nov 12 19:25:38 2018 CryptAuth: Remove unused ConnectionFinder. Bug: 899324 Test: none Change-Id: I30f07136ac7c3ed3ac49b678e5f45d250fcbe65f Reviewed-on: https://chromium-review.googlesource.com/c/1331573 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#607302} [delete] https://crrev.com/dc8c60c35aac283f098567ec35045b821b9590c7/components/cryptauth/connection_finder.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23ba3a17fb2e90137d3f6095b5ba42a047403edd commit 23ba3a17fb2e90137d3f6095b5ba42a047403edd Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Mon Nov 12 19:54:46 2018 Revert "CryptAuth: Remove unused ConnectionFinder." This reverts commit 6c1f4453b4567ebae69ca9f42fd6602e06d1b1dc. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 607302 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZjMWY0NDUzYjQ1NjdlYmFlNjljYTlmNDJmZDY2MDJlMDZkMWIxZGMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Full/109736 Sample Failed Step: compile Original change's description: > CryptAuth: Remove unused ConnectionFinder. > > Bug: 899324 > Test: none > Change-Id: I30f07136ac7c3ed3ac49b678e5f45d250fcbe65f > Reviewed-on: https://chromium-review.googlesource.com/c/1331573 > Reviewed-by: Jeremy Klein <jlklein@chromium.org> > Commit-Queue: James Hawkins <jhawkins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607302} Change-Id: I0c821dda827a0daf2a144b60718e370c459abd6f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899324 Reviewed-on: https://chromium-review.googlesource.com/c/1331948 Cr-Commit-Position: refs/heads/master@{#607310} [add] https://crrev.com/23ba3a17fb2e90137d3f6095b5ba42a047403edd/components/cryptauth/connection_finder.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a006576c66d9a17148fa56e81780ab29b8956689 commit a006576c66d9a17148fa56e81780ab29b8956689 Author: James Hawkins <jhawkins@chromium.org> Date: Tue Nov 13 02:06:14 2018 Reland crrev.com/c/1331573 w/ build fixes in place. Bug: 899324 Test: none Original change description: > CryptAuth: Remove unused ConnectionFinder. > > Bug: 899324 > Test: none > Change-Id: I30f07136ac7c3ed3ac49b678e5f45d250fcbe65f > Reviewed-on: https://chromium-review.googlesource.com/c/1331573 > Reviewed-by: Jeremy Klein <jlklein@chromium.org> > Commit-Queue: James Hawkins <jhawkins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607302} R=hansberry@chromium.org Change-Id: Ia14bbe45b5b76a94c79aea5c4b687695df843163 Reviewed-on: https://chromium-review.googlesource.com/c/1333109 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#607436} [modify] https://crrev.com/a006576c66d9a17148fa56e81780ab29b8956689/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.cc [modify] https://crrev.com/a006576c66d9a17148fa56e81780ab29b8956689/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc [delete] https://crrev.com/15242c0c52f055089ca410881dc049f43a2c4e62/components/cryptauth/connection_finder.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70edfcdd79bd2a400bd5b57e7bc171c45de41a69 commit 70edfcdd79bd2a400bd5b57e7bc171c45de41a69 Author: James Hawkins <jhawkins@chromium.org> Date: Wed Nov 14 22:44:29 2018 Proximity Auth: Remove unused metrics loggers. R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: I0c579f604635d89ba2b1394d5142fbb21de12560 Reviewed-on: https://chromium-review.googlesource.com/c/1330828 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#608148} [modify] https://crrev.com/70edfcdd79bd2a400bd5b57e7bc171c45de41a69/chromeos/components/proximity_auth/metrics.cc [modify] https://crrev.com/70edfcdd79bd2a400bd5b57e7bc171c45de41a69/chromeos/components/proximity_auth/metrics.h [modify] https://crrev.com/70edfcdd79bd2a400bd5b57e7bc171c45de41a69/tools/metrics/histograms/histograms.xml
Comment 1 by jhawkins@chromium.org
, Oct 26