Remove rounded mask during animations in overview. |
|||||||||
Issue descriptionPreviously only removed the mask on the animating window, but we get better performance if we remove it on all windows.
,
Oct 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7fab70753074d8f48bdaa30c6058a78b3a277ea commit c7fab70753074d8f48bdaa30c6058a78b3a277ea Author: Sammie Quon <sammiequon@google.com> Date: Sat Oct 27 01:37:31 2018 overview: Apply mask after animations done. Previous, only removed masks on the window that is animating. But removing masks on all windows reduces jank, and UX is OK with it. Test: manual Bug: 899308 Change-Id: I7daa6bde8cbd2ab839123002024e440cbafa6627 Reviewed-on: https://chromium-review.googlesource.com/c/1302776 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#603288} [modify] https://crrev.com/c7fab70753074d8f48bdaa30c6058a78b3a277ea/ash/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/c7fab70753074d8f48bdaa30c6058a78b3a277ea/ash/wm/overview/scoped_transform_overview_window.h [modify] https://crrev.com/c7fab70753074d8f48bdaa30c6058a78b3a277ea/ash/wm/overview/start_animation_observer.h [modify] https://crrev.com/c7fab70753074d8f48bdaa30c6058a78b3a277ea/ash/wm/overview/window_selector.cc [modify] https://crrev.com/c7fab70753074d8f48bdaa30c6058a78b3a277ea/ash/wm/overview/window_selector.h [modify] https://crrev.com/c7fab70753074d8f48bdaa30c6058a78b3a277ea/ash/wm/overview/window_selector_controller.cc [modify] https://crrev.com/c7fab70753074d8f48bdaa30c6058a78b3a277ea/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/c7fab70753074d8f48bdaa30c6058a78b3a277ea/ash/wm/overview/window_selector_item.h
,
Oct 27
,
Oct 28
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 28
+kbleicher for permissions
,
Oct 28
,
Oct 29
Hi, has this been verified? What's the risk if we merge? Not seeing that on the bug.. Thanks.
,
Oct 29
This has been tested locally. The only risk will be some edge case UI tweaks to overview mode.
,
Oct 29
Have you tested on more than one device to identify the edge cases?
,
Oct 29
Yes, I have.
,
Oct 30
Approving merge to M71 Chrome OS.
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c8346d0efad63f11c18c50079bb046b57a39c0d Commit: 7c8346d0efad63f11c18c50079bb046b57a39c0d Author: sammiequon@google.com Commiter: sammiequon@chromium.org Date: 2018-10-30 19:34:00 +0000 UTC [merge to 71] overview: Apply mask after animations done. Previous, only removed masks on the window that is animating. But removing masks on all windows reduces jank, and UX is OK with it. TBR=sammiequon@google.com (cherry picked from commit c7fab70753074d8f48bdaa30c6058a78b3a277ea) Test: manual Bug: 899308 Change-Id: I7daa6bde8cbd2ab839123002024e440cbafa6627 Reviewed-on: https://chromium-review.googlesource.com/c/1302776 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603288} Reviewed-on: https://chromium-review.googlesource.com/c/1308662 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#412} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c8346d0efad63f11c18c50079bb046b57a39c0d commit 7c8346d0efad63f11c18c50079bb046b57a39c0d Author: Sammie Quon <sammiequon@google.com> Date: Tue Oct 30 19:34:00 2018 [merge to 71] overview: Apply mask after animations done. Previous, only removed masks on the window that is animating. But removing masks on all windows reduces jank, and UX is OK with it. TBR=sammiequon@google.com (cherry picked from commit c7fab70753074d8f48bdaa30c6058a78b3a277ea) Test: manual Bug: 899308 Change-Id: I7daa6bde8cbd2ab839123002024e440cbafa6627 Reviewed-on: https://chromium-review.googlesource.com/c/1302776 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603288} Reviewed-on: https://chromium-review.googlesource.com/c/1308662 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#412} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/7c8346d0efad63f11c18c50079bb046b57a39c0d/ash/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/7c8346d0efad63f11c18c50079bb046b57a39c0d/ash/wm/overview/scoped_transform_overview_window.h [modify] https://crrev.com/7c8346d0efad63f11c18c50079bb046b57a39c0d/ash/wm/overview/start_animation_observer.h [modify] https://crrev.com/7c8346d0efad63f11c18c50079bb046b57a39c0d/ash/wm/overview/window_selector.cc [modify] https://crrev.com/7c8346d0efad63f11c18c50079bb046b57a39c0d/ash/wm/overview/window_selector.h [modify] https://crrev.com/7c8346d0efad63f11c18c50079bb046b57a39c0d/ash/wm/overview/window_selector_controller.cc [modify] https://crrev.com/7c8346d0efad63f11c18c50079bb046b57a39c0d/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/7c8346d0efad63f11c18c50079bb046b57a39c0d/ash/wm/overview/window_selector_item.h
,
Oct 30
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sammiequon@chromium.org
, Oct 26