New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 899303 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: support browser-wide network interception

Project Member Reported by caseq@chromium.org, Oct 26

Issue description

... AKA Fetch domain on the Browser target.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2d4ff7a9f2bc8e67334a95ea7b169a8158d5ac7

commit f2d4ff7a9f2bc8e67334a95ea7b169a8158d5ac7
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Mon Oct 29 20:09:59 2018

Extract instrumentation methods from RenderFrameDevToolsAgentHost into devtools_instrumentation

Bug:  899303 
Change-Id: If13f08e4e45e4f4f4cfc16bd4f2921cab22ecc07
Reviewed-on: https://chromium-review.googlesource.com/c/1303181
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603598}
[modify] https://crrev.com/f2d4ff7a9f2bc8e67334a95ea7b169a8158d5ac7/content/browser/BUILD.gn
[add] https://crrev.com/f2d4ff7a9f2bc8e67334a95ea7b169a8158d5ac7/content/browser/devtools/devtools_instrumentation.cc
[add] https://crrev.com/f2d4ff7a9f2bc8e67334a95ea7b169a8158d5ac7/content/browser/devtools/devtools_instrumentation.h
[modify] https://crrev.com/f2d4ff7a9f2bc8e67334a95ea7b169a8158d5ac7/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/f2d4ff7a9f2bc8e67334a95ea7b169a8158d5ac7/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/f2d4ff7a9f2bc8e67334a95ea7b169a8158d5ac7/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/f2d4ff7a9f2bc8e67334a95ea7b169a8158d5ac7/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/f2d4ff7a9f2bc8e67334a95ea7b169a8158d5ac7/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/f2d4ff7a9f2bc8e67334a95ea7b169a8158d5ac7/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/f2d4ff7a9f2bc8e67334a95ea7b169a8158d5ac7/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/f2d4ff7a9f2bc8e67334a95ea7b169a8158d5ac7/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/f2d4ff7a9f2bc8e67334a95ea7b169a8158d5ac7/content/browser/web_package/signed_exchange_devtools_proxy.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 29

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd

commit d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Wed Oct 31 17:52:58 2018

DevTools: introduce Fetch domain

This adds Fetch domain on the browser target, that carries interception
functionality previously available through Network domain, with a
slightly brushed up interface.

Bug:  899303 
Change-Id: I74ef83ddfe711c566500ab9e815a24dfbf813106
Reviewed-on: https://chromium-review.googlesource.com/c/1292008
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604323}
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/content/browser/BUILD.gn
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/content/browser/devtools/BUILD.gn
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/content/browser/devtools/browser_devtools_agent_host.cc
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/content/browser/devtools/devtools_instrumentation.cc
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/content/browser/devtools/devtools_network_interceptor.cc
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/content/browser/devtools/devtools_network_interceptor.h
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/content/browser/devtools/devtools_url_loader_interceptor.cc
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/content/browser/devtools/devtools_url_loader_interceptor.h
[add] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/content/browser/devtools/protocol/fetch_handler.cc
[add] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/content/browser/devtools/protocol/fetch_handler.h
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/third_party/WebKit/LayoutTests/http/tests/devtools/agents-enable-disable.js
[add] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/fetch/fetch-basic-expected.txt
[add] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/fetch/fetch-basic.js
[add] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/fetch/resources/fetch-test.js
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/inspector-protocol-test.js
[modify] https://crrev.com/d076d0d4dd2fde10e2a04ad39d9939fc80f89fcd/third_party/blink/renderer/core/inspector/browser_protocol.pdl

Status: Fixed (was: Assigned)

Sign in to add a comment