New issue
Advanced search Search tips

Issue 899297 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 26
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----



Sign in to add a comment

misc app_list_view cleanups

Project Member Reported by newcomer@chromium.org, Oct 26

Issue description

Reorder header/cc to match, and a few other misc cleanups.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a19b3399afee75d619fd65ed4fe46aa40391ac9e

commit a19b3399afee75d619fd65ed4fe46aa40391ac9e
Author: Alex Newcomer <newcomer@chromium.org>
Date: Fri Oct 26 23:08:14 2018

cros: Clean up app_list_view

Moves functions to match their orderings in h and cc.
Also removes a little dead code.

Bug:  899297 
Change-Id: I9c8202f5c24c811025db6dadf72edd9d2f73f4bc
Reviewed-on: https://chromium-review.googlesource.com/c/1302822
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603240}
[modify] https://crrev.com/a19b3399afee75d619fd65ed4fe46aa40391ac9e/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/a19b3399afee75d619fd65ed4fe46aa40391ac9e/ash/app_list/views/app_list_view.h

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c962ca3ed7a5add717c4ff2d3c691b3e0614f66e

commit c962ca3ed7a5add717c4ff2d3c691b3e0614f66e
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Sat Oct 27 02:46:05 2018

Revert "cros: Clean up app_list_view"

This reverts commit a19b3399afee75d619fd65ed4fe46aa40391ac9e.

Reason for revert: let's land this after performance turning work.

Original change's description:
> cros: Clean up app_list_view
> 
> Moves functions to match their orderings in h and cc.
> Also removes a little dead code.
> 
> Bug:  899297 
> Change-Id: I9c8202f5c24c811025db6dadf72edd9d2f73f4bc
> Reviewed-on: https://chromium-review.googlesource.com/c/1302822
> Reviewed-by: Weidong Guo <weidongg@chromium.org>
> Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603240}

TBR=newcomer@chromium.org,weidongg@chromium.org

Change-Id: Ibb0c287a03b381347f4289e30899153c2457003c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  899297 
Reviewed-on: https://chromium-review.googlesource.com/c/1303638
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603299}
[modify] https://crrev.com/c962ca3ed7a5add717c4ff2d3c691b3e0614f66e/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/c962ca3ed7a5add717c4ff2d3c691b3e0614f66e/ash/app_list/views/app_list_view.h

Sign in to add a comment