New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 899291 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 31
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-10-31
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Overflow: visible doesnt work correctly when bezier curve is modified

Reported by r.hilsc...@gmail.com, Oct 26

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.20 Safari/537.36

Steps to reproduce the problem:
1. Draw svg path with overflow visible 
My example
<svg version="1.2" preserveAspectRatio="none" class="ng-element" viewBox="0 0 275.0107727050781 222.6671905517578" style="position:absolute; overflow: visible; width: 275.011px; height: 222.667px; opacity: 1; mix-blend-mode: normal; transform: rotate(0deg) translate(54px, 106.724px) rotate(0deg); pointer-events: auto; z-index: 1;"><defs></defs><g style="transform: translate(-54px, -106.724px);"><path d="M152.99999999999758 112.00000000000193 C152.99999999999758 112.00000000000193 53.99999999999914 319.0000000000055 53.99999999999914 319.0000000000055 C53.99999999999914 319.0000000000055 330.9999999999976 376.0000000000019 328.99999999999477 223.00000000000387 C326.9999999999919 70.00000000000585 152.99999999999758 112.00000000000193 152.99999999999758 112.00000000000193 Z" style="stroke: rgb(102, 102, 102); stroke-width: 1; stroke-linecap: butt; stroke-linejoin: miter; fill: rgb(235, 235, 235);"></path></g></svg>

2. Change bezier curve points by using mousedown mousemove events

What is the expected behavior?
http://g.recordit.co/rBl3msKdGf.gif (This gif is from Chrom 69)

What went wrong?
http://g.recordit.co/vzBfietJB9.gif
Svg is cut when I moved bezier curve control points although it has overflow:visible attribute.

Did this work before? Yes 69

Does this work in other browsers? Yes

Chrome version: 71.0.3578.20  Channel: beta
OS Version: OS X 10.13.3
Flash Version:
 
Labels: Needs-Feedback
NextAction: 2018-11-12
The attached file has your SVG example.

In DevTools on a Mac if I change the coordinates to push the curve to the right, it is still visible.

Please provide us with a more thorough reproduction case, with the event handlers etc. that replicate your situation.
cr899291.html
926 bytes View Download
Hi, thank you for your answer.
I prepare for you simple script. Try to move red point.
http://g.recordit.co/pz0CuShmfN.gif
Problem is when container has backface-visibility:hidden; and I modify bezier curve point.
You can reproduce it by using devtools as well http://g.recordit.co/6KI3c4qR7N.gif
It's working correctly on firefox, safari and chrome 69.
index.html
2.6 KB View Download
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 28

Cc: schenney@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Bisected to r582337 = 46520ae13478333fe882e79041b667e5a3112796 = https://crrev.com/c/1168142 by chrishtr@chromium.org
"[PE] Stop dirtying compositing inputs on any layout for the root PaintLayer."
Landed in 70.0.3519.0
Labels: Needs-Bisect Needs-Triage-M71
Owner: chrishtr@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: susan.boorgula@chromium.org
Labels: -Pri-2 -Needs-Bisect ReleaseBlock-Stable Triaged-ET RegressedIn-70 Target-70 Target-71 Target-72 M-70 FoundIn-71 FoundIn-70 FoundIn-72 hasbisect Pri-1
r.hilscher@ Thanks for the issue.

Able to reproduce this issue on Windows 10, Mac OS 10.13.6 and Ubuntu 17.10 on the reported version 71.0.3578.20 and latest Canary 72.0.3595.0.

Bisect Information:
===================
Good Build: 70.0.3518.0
Bad Build : 70.0.3519.0

As per comment #4, suspecting the below change:
Reviewed-on: https://chromium-review.googlesource.com/1168142

chrishtr@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner.

Adding 'ReleaseBlock-Stable' as this is a recent regression. Please feel free to remove if it is not applicable.

Thanks..
Labels: OS-Linux OS-Windows
Confirmed still broken in Canary (M-72) and Beta (M-71), so not fixed by anything else.
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable  ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable  ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
Cc: chrishtr@chromium.org
Owner: vmp...@chromium.org
Vlad, I'm not sure Chris will be back in time for the stable promotion. Could you look at this?
Hi. I believe I'm facing the same overflow issue on Chrome 70. To reproduce the problem, click on "Extend Line" button in the attached test page. The expected and actual results are attached as screenshots.

Note that the SVG element in the test page has overflow, will-change and transform properties applied.
svg-overflow-bug-chrome70.html
1.0 KB View Download
expected.png
22.9 KB View Download
actual.png
19.4 KB View Download
Yep that looks like the same issue. The fix is in cq
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29b5904fa94cfcc838990f2cc731662a79979c46

commit 29b5904fa94cfcc838990f2cc731662a79979c46
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Tue Oct 30 01:38:07 2018

Ensure to invalidate compositing inputs on svg overflow change.

This patch ensures that we dirty the compositing inputs if our svg root
has visible overflow and that overflow changes.

R=chrishtr@chromium.org, pdr@chromium.org

Bug:  899291 
Change-Id: Iaaa0eb7f48b9855af141e6b3d79d3a1667c6e38f
Reviewed-on: https://chromium-review.googlesource.com/c/1306408
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603725}
[modify] https://crrev.com/29b5904fa94cfcc838990f2cc731662a79979c46/third_party/blink/renderer/core/layout/svg/layout_svg_root.cc
[modify] https://crrev.com/29b5904fa94cfcc838990f2cc731662a79979c46/third_party/blink/renderer/core/layout/svg/layout_svg_root_test.cc

Our customers rely on this fix for their graphics editing workflows to work properly. Any chance the fix can make it into Stable v70 or is that impossible?
Cc: abdulsyed@chromium.org
Labels: Merge-Request-71
The fix is definitely a good release merge candidate.

We'll let this sit in Canary for a day then request merge back to M-71 Beta, then if that goes well we'll discuss M-70 Stable. It's unlikely we will release a Stable update just for this, so we will need to coordinate with the release managers to find out what other issues might cause a Stable revision.

Cc: benmason@chromium.org
Labels: OS-Android OS-Chrome
NextAction: 2018-10-31
CL listed at #15 is not in canary yet. Pls update bug with canary result tomorrow. If change looks good in canary, will approve merge to M71. Thank you.
Project Member

Comment 19 by sheriffbot@chromium.org, Oct 30

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
@#18, the fix is pretty safe, so I'm comfortable with the merge whenever it is approved. I'll update the bug if there are any Canary issues that surface, but all else being quiet, I'd say we can merge.

The NextAction date has arrived: 2018-10-31
Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comment #20 and per offline with pdr@.
Labels: -Merge-Approved-71 Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/3075c459af7d475892d868fcfd430fabc6fab42d

Commit: 3075c459af7d475892d868fcfd430fabc6fab42d
Author: vmpstr@chromium.org
Commiter: vmpstr@chromium.org
Date: 2018-10-31 20:58:55 +0000 UTC

Ensure to invalidate compositing inputs on svg overflow change.

This patch ensures that we dirty the compositing inputs if our svg root
has visible overflow and that overflow changes.

R=chrishtr@chromium.org, pdr@chromium.org
TBR=vmpstr@chromium.org

(cherry picked from commit 29b5904fa94cfcc838990f2cc731662a79979c46)

Bug:  899291 
Change-Id: Iaaa0eb7f48b9855af141e6b3d79d3a1667c6e38f
Reviewed-on: https://chromium-review.googlesource.com/c/1306408
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603725}
Reviewed-on: https://chromium-review.googlesource.com/c/1311088
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#438}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 24 by bugdroid1@chromium.org, Oct 31

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3075c459af7d475892d868fcfd430fabc6fab42d

commit 3075c459af7d475892d868fcfd430fabc6fab42d
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Wed Oct 31 20:58:55 2018

Ensure to invalidate compositing inputs on svg overflow change.

This patch ensures that we dirty the compositing inputs if our svg root
has visible overflow and that overflow changes.

R=chrishtr@chromium.org, pdr@chromium.org
TBR=vmpstr@chromium.org

(cherry picked from commit 29b5904fa94cfcc838990f2cc731662a79979c46)

Bug:  899291 
Change-Id: Iaaa0eb7f48b9855af141e6b3d79d3a1667c6e38f
Reviewed-on: https://chromium-review.googlesource.com/c/1306408
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603725}
Reviewed-on: https://chromium-review.googlesource.com/c/1311088
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#438}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/3075c459af7d475892d868fcfd430fabc6fab42d/third_party/blink/renderer/core/layout/svg/layout_svg_root.cc
[modify] https://crrev.com/3075c459af7d475892d868fcfd430fabc6fab42d/third_party/blink/renderer/core/layout/svg/layout_svg_root_test.cc

Status: Fixed (was: Assigned)
I'm not able to reproduce the issue described in comment #13 in Canary Version 72.0.3598.0.

Looking forward to seeing this fix in the upcoming M71, and hopefully the stable M70 if possible.
Is there an ETA for when the fix will be merged to M71?
I'm not able to reproduce the issue described in comment #13 in Chrome Beta Version 71.0.3578.44.

Sign in to add a comment