New issue
Advanced search Search tips

Issue 899290 link

Starred by 1 user
Status: Assigned
Owner:
terelius@chromium.org
Cc:
agrieve@chromium.org
eladalon@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

36kb regression in resource_sizes (MonochromePublic.apk) at 603083:603083

Project Member Reported by agrieve@chromium.org, Oct 26 
Caused by “Reland "Encode RTC event logs in new format."”

Roll Commit: c35096d975aab1127c9c86160d0d2045c1f1491a
webrtc commit: https://webrtc.googlesource.com/src.git/+/c35096d975aab1127c9c86160d0d2045c1f1491a

Link to size graph: https://chromeperf.appspot.com/report?sid=bb23072657e2d7ca892a1c3fa4643b1ee29b3a0a44d0732adda87168e89c0380&num_points=10&rev=603083
Link to trybot result: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-binary-size/84856

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on supersize html, majority of increase is from protocol buffers.

It seem unlikely to me that this feature is worth this much of a binary size hit. Please have a look and either:
* Address the regression
* Justify the regression
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 26 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=899290

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=007f66e7559346a27506f6246b11dbadd238727db8cc7b3cb859480c44953355


Bot(s) for this bug's original alert(s):

Android Builder Perf
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Oct 26 

Assigning to chromium-autoroll@skia-public.iam.gserviceaccount.com because this is the only CL in range:
Roll src/third_party/webrtc a5d543ce21cd..2769cd540c1e (3 commits)

https://webrtc.googlesource.com/src.git/+log/a5d543ce21cd..2769cd540c1e


git log a5d543ce21cd..2769cd540c1e --date=short --no-merges --format='%ad %ae %s'
2018-10-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f54583b6a0..a539a24569 (602763:603045)
2018-10-26 kthelgason@webrtc.org Allocate CMBlockBuffers using a memory pool.
2018-10-26 terelius@webrtc.org Reland "Encode RTC event logs in new format."


Created with:
  gclient setdep -r src/third_party/webrtc@2769cd540c1e

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I3442c5036f6ba61b9675eb64f2643927597ac32b
Reviewed-on: https://chromium-review.googlesource.com/c/1301536
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603083}
►

Sign in to add a comment