Add testing for component enabling/disabling in org.chromium.webapk.new.splash
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62e33bd2f07eba06b6e0b8d0e96934c56a9983a6 commit 62e33bd2f07eba06b6e0b8d0e96934c56a9983a6 Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Fri Oct 26 19:52:19 2018 [Android WebAPK] Move manifest config files to manifest/ directory This CL also deletes unused javatest_manifest_config.json BUG=899274 Change-Id: Icdf3992983af4a0a9b4a942b544570bebd64448a Reviewed-on: https://chromium-review.googlesource.com/c/1302094 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603177} [modify] https://crrev.com/62e33bd2f07eba06b6e0b8d0e96934c56a9983a6/chrome/android/webapk/shell_apk/BUILD.gn [delete] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/android/webapk/shell_apk/javatest_manifest_config.json [rename] https://crrev.com/62e33bd2f07eba06b6e0b8d0e96934c56a9983a6/chrome/android/webapk/shell_apk/manifest/bound_manifest_config.json [rename] https://crrev.com/62e33bd2f07eba06b6e0b8d0e96934c56a9983a6/chrome/android/webapk/shell_apk/manifest/http_manifest_config.json [rename] https://crrev.com/62e33bd2f07eba06b6e0b8d0e96934c56a9983a6/chrome/android/webapk/shell_apk/manifest/manifest_mustache_pass.gni [rename] https://crrev.com/62e33bd2f07eba06b6e0b8d0e96934c56a9983a6/chrome/android/webapk/shell_apk/manifest/manifest_mustache_pass.py [rename] https://crrev.com/62e33bd2f07eba06b6e0b8d0e96934c56a9983a6/chrome/android/webapk/shell_apk/manifest/maps_go_manifest_config.json [rename] https://crrev.com/62e33bd2f07eba06b6e0b8d0e96934c56a9983a6/chrome/android/webapk/shell_apk/manifest/new_splash_manifest_config.json [rename] https://crrev.com/62e33bd2f07eba06b6e0b8d0e96934c56a9983a6/chrome/android/webapk/shell_apk/manifest/unbound_manifest_config.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d095129a77990afd1e30558a765615fe3dc2c3a commit 0d095129a77990afd1e30558a765615fe3dc2c3a Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Fri Oct 26 22:00:46 2018 [Android WebAPK]: Remove manifest_package from config This CL removes the manifest_package from the JSON config. This enables NewSplashWebApk.apk and WebApk.apk to use the same config. BUG=899274 Change-Id: Ibcc95142239de6055e60f7cc02f109cbde03408b Reviewed-on: https://chromium-review.googlesource.com/c/1302105 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#603206} [modify] https://crrev.com/0d095129a77990afd1e30558a765615fe3dc2c3a/chrome/android/webapk/shell_apk/BUILD.gn [modify] https://crrev.com/0d095129a77990afd1e30558a765615fe3dc2c3a/chrome/android/webapk/shell_apk/manifest/bound_manifest_config.json [modify] https://crrev.com/0d095129a77990afd1e30558a765615fe3dc2c3a/chrome/android/webapk/shell_apk/manifest/http_manifest_config.json [modify] https://crrev.com/0d095129a77990afd1e30558a765615fe3dc2c3a/chrome/android/webapk/shell_apk/manifest/maps_go_manifest_config.json [delete] https://crrev.com/9afecb6e13b1fd6fa5480a3e76fa11ab318a21bc/chrome/android/webapk/shell_apk/manifest/new_splash_manifest_config.json [modify] https://crrev.com/0d095129a77990afd1e30558a765615fe3dc2c3a/chrome/android/webapk/shell_apk/manifest/unbound_manifest_config.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25cc6a0ed99aaface710aaccd2c2bc7ae76023af commit 25cc6a0ed99aaface710aaccd2c2bc7ae76023af Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Sat Oct 27 01:09:16 2018 [Android WebAPK Refactor] Introduce way to define config JSON file as delta This CL introduces a way of defining a JSON config file as a "base JSON config file" + "delta config file". The generated config follows the following rules: - If a key is present in both the "base config" and the "delta config" the value in the "delta config" is used. - If a key is present in one of the "base config" and the "delta config" the key+value are included in the generated config. The reason for this change are to: 1) Make it easier to add test configs 2) Avoid breakages due to the configs being out of sync such as https://chromium-review.googlesource.com/c/chromium/src/+/1298428 BUG=899274 Change-Id: I48f236c4d6a86cba32c144b773ba6aab8c99b783 Reviewed-on: https://chromium-review.googlesource.com/c/1302326 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#603282} [modify] https://crrev.com/25cc6a0ed99aaface710aaccd2c2bc7ae76023af/chrome/android/webapk/shell_apk/BUILD.gn [delete] https://crrev.com/b13ee619fbf8ef10e74840a414b81a6b41120add/chrome/android/webapk/shell_apk/manifest/http_manifest_config.json [add] https://crrev.com/25cc6a0ed99aaface710aaccd2c2bc7ae76023af/chrome/android/webapk/shell_apk/manifest/http_manifest_config_delta.json [modify] https://crrev.com/25cc6a0ed99aaface710aaccd2c2bc7ae76023af/chrome/android/webapk/shell_apk/manifest/manifest_mustache_pass.gni [modify] https://crrev.com/25cc6a0ed99aaface710aaccd2c2bc7ae76023af/chrome/android/webapk/shell_apk/manifest/manifest_mustache_pass.py
Comment 1 by pkotw...@chromium.org
, Oct 26