New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 899246 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 27
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Refine cast overlay validator algorithm to filter video layers

Project Member Reported by dnicoara@chromium.org, Oct 26

Issue description

When layers, such as EXO layers are parsed in Viz, they look like the video layers. We can't filter EXO layers as video layers, so we need to refine how video layers are parsed by the overlay validator.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7

commit 3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Tue Nov 27 19:22:52 2018

cast: Add PROTECTED_VIDEO flag to video hole stub frame

When creating a video frame for the video hole, the compositor creates a
TextureDrawQuad. This is generic enough that the overlay strategy can't
distinguish between a video frame and a EXO texture.

Add a hint to the TextureDrawQuad that the video frame requires an
overlay and use that to differentiate the video hole quad.

TBR=kaznacheev@chromium.org
hole.
correctly.

Bug:  899246 
Test: Ran on device and ensured EXO content doesn't trigger the video
Test: Ran updated viz_unittests to verify new strategy filters content
Change-Id: I4e275550efa287fd2b491d31028a1dead9fbc053
Reviewed-on: https://chromium-review.googlesource.com/c/1316088
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Maggie Chen <magchen@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611247}
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/ash/components/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/cc/layers/nine_patch_generator.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/cc/layers/painted_overlay_scrollbar_layer_impl.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/cc/layers/painted_scrollbar_layer_impl.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/cc/layers/texture_layer_impl.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/cc/layers/ui_resource_layer_impl.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/components/exo/surface.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/components/viz/common/quads/draw_quad_perftest.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/components/viz/common/quads/draw_quad_unittest.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/components/viz/common/quads/texture_draw_quad.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/components/viz/common/quads/texture_draw_quad.h
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/components/viz/service/display/display_perftest.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/components/viz/service/display/overlay_candidate.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/components/viz/service/display/overlay_candidate.h
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/components/viz/service/display/overlay_strategy_underlay_cast.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/components/viz/service/display/surface_aggregator_perftest.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/media/base/video_frame_metadata.h
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/media/renderers/video_overlay_factory.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/media/renderers/video_resource_updater.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/services/viz/public/cpp/compositing/quads_struct_traits.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/services/viz/public/cpp/compositing/quads_struct_traits.h
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/services/viz/public/cpp/compositing/struct_traits_perftest.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/services/viz/public/interfaces/compositing/quads.mojom
[modify] https://crrev.com/3a0e00b8216a6e6f1bf6f7bc9705a3040acf96e7/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc

Status: Fixed (was: Assigned)

Sign in to add a comment