New issue
Advanced search Search tips

Issue 899227 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

SVG becomes invisible

Reported by rol...@nextendweb.com, Oct 26

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36

Example URL:
https://smartslider3.com/orion-page-group/

Steps to reproduce the problem:
1. Open https://smartslider3.com/orion-page-group/
2. Below the scroll down button you should see an SVG with 3 white triangles with different opacity which shrinks when you scroll
3. Click on the "Scroll Down" button
4. Scroll back to the top of the page

See the attached video for more details.

What is the expected behavior?
The SVG with the triangles should grow when your scroll back to the top after you clicked on the "Scroll Down" button.

What went wrong?
Chrome fails to render the SVG

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 70.0.3538.77  Channel: stable
OS Version: 10.0
Flash Version: 

If the container of the SVG gets a background color, it renders properly and there is no way to reproduce the bug.
 
output.mp4
8.6 MB View Download
Components: Blink>Scroll
Labels: Needs-Triage-M70
Cc: viswa.karala@chromium.org
Labels: Triaged-ET Needs-Bisect
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on reported chrome 70.0.3538.77 and on latest chrome 72.0.3595.0 Using Windows-10, issue is not seen on M-60(60.0.3112.0). Hence, Marking it as Untriage and will provide Bisect info and other OS behavior soon.

Thanks...! 
Components: Blink>Paint
Labels: -Pri-2 -Type-Compat -Needs-Bisect hasbisect-per-revision RegressedIn-67 Target-70 Target-71 Target-72 M-72 FoundIn-71 FoundIn-70 FoundIn-72 OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on reported version 70.0.3538.77 and latest chrome 72.0.3596.0 using Mac 10.12.6, Ubuntu 17.10 and Windows-10, hence providing Bisect Info

Bisect Info:
================
Good build: 67.0.3371.0
Bad build: 67.0.3372.0

You are probably looking for a change made after 543290 (known good), but no later than 543291 (first known bad).
https://chromium.googlesource.com/chromium/src/+log/63667eca2a1d86f5de61f29c7c5c6417cc351757..3a3c78a924a686ed0d3f90d765b00cdd78453e11
Change-Id: I5fdbcabc7ca0f2fa8e69ae0fbf5a0077bba46cfe
Reviewed-on: https://chromium-review.googlesource.com/923572

@Xianzhu Wang: Please confirm the issue and help in re-assigning if it is not related to your change.

Thanks!
Components: -Blink>Paint -Blink>Scroll Blink>Paint>Invalidation
Attaching minimized TC.
issue899227.html
592 bytes View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5ccedd6977c3be348003544c2af6f6761d777da

commit b5ccedd6977c3be348003544c2af6f6761d777da
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Mon Nov 05 15:44:14 2018

[PE] Fix under-invalidation when <svg> resizes from near-zero size

SVGRootPainter has the following code:
  if (PixelSnappedSize(paint_offset).IsEmpty())
    return;
so when the size changes bigger from near-zero, we need to check
the condition during paint. This requires us to repaint the containing
layer even if the <svg> object itself paints nothing.

Remove LayoutSVGRoot::PaintedOutputOfObjectHasNoEffectRegardlessOfSize
(and use the inherited LayoutReplaced version which always returns false)
so that we'll always invalidate paint of <svg> on size change even if
the object itself paints nothing, as the code above can be treated as a
paint effect.

Bug:  899227 
Change-Id: Icc83c352555c0ae183cdaf0bfb30c1ad99d6f428
Reviewed-on: https://chromium-review.googlesource.com/c/1317011
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#605342}
[add] https://crrev.com/b5ccedd6977c3be348003544c2af6f6761d777da/third_party/WebKit/LayoutTests/paint/invalidation/svg/svg-resize-from-near-zero-expected.html
[add] https://crrev.com/b5ccedd6977c3be348003544c2af6f6761d777da/third_party/WebKit/LayoutTests/paint/invalidation/svg/svg-resize-from-near-zero.html
[modify] https://crrev.com/b5ccedd6977c3be348003544c2af6f6761d777da/third_party/blink/renderer/core/layout/svg/layout_svg_root.cc
[modify] https://crrev.com/b5ccedd6977c3be348003544c2af6f6761d777da/third_party/blink/renderer/core/layout/svg/layout_svg_root.h
[modify] https://crrev.com/b5ccedd6977c3be348003544c2af6f6761d777da/third_party/blink/renderer/core/layout/svg/layout_svg_root_test.cc

Status: Fixed (was: Assigned)

Sign in to add a comment