Cache Finch flag "allow-start-service-manager-only" in SharedPreference |
||||
Issue descriptionStore this flag in the SharedPreference, so DownloadBroadcastManager can query it during the early startup. It is okay to get the Finch flag value cached during the last time when Chrome is running.
,
Oct 26
,
Nov 2
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8dfddfccbd029409ac24992a76c6f926e5818934 commit 8dfddfccbd029409ac24992a76c6f926e5818934 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Thu Nov 29 21:44:07 2018 Check AllowStartingServiceManagerOnly in ServiceManagerStartupUtils. AllowStartingServiceManagerOnly already gates starting the service manager early in the native code. Make the Java code check the flag too. Bug: 899225 , 899226 Change-Id: Iadc7d03b4e3b559815a72de66ff249f2ad36bbbb Reviewed-on: https://chromium-review.googlesource.com/c/1318362 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Xi Han <hanxi@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#612380} [modify] https://crrev.com/8dfddfccbd029409ac24992a76c6f926e5818934/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/8dfddfccbd029409ac24992a76c6f926e5818934/chrome/android/java/src/org/chromium/chrome/browser/init/ServiceManagerStartupUtils.java [modify] https://crrev.com/8dfddfccbd029409ac24992a76c6f926e5818934/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/8dfddfccbd029409ac24992a76c6f926e5818934/content/app/content_main_runner_impl.cc [modify] https://crrev.com/8dfddfccbd029409ac24992a76c6f926e5818934/content/public/common/content_features.cc [modify] https://crrev.com/8dfddfccbd029409ac24992a76c6f926e5818934/content/public/common/content_features.h
,
Nov 29
|
||||
►
Sign in to add a comment |
||||
Comment 1 by hanxi@chromium.org
, Oct 26