New issue
Advanced search Search tips

Issue 899225 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 27
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 864625
issue 905678

Blocking:
issue 729596



Sign in to add a comment

Create Finch experiment for starting browser in ServiceManager mode.

Project Member Reported by hanxi@chromium.org, Oct 26

Issue description

This experiment will be used for launching the new browser startup mode.
 
Status: Available (was: Untriaged)
Blocking: 729596
Owner: hnakashima@chromium.org
Status: Assigned (was: Available)
Blockedon: 905678
Blockedon: 864625
It's really blocked on having some metrics, could be crbug.com/864625 or  crbug.com/905678 .
 crbug.com/905678  fits better. I have worked on it, hopefully it won't block you soon:)

https://chromium-review.googlesource.com/c/chromium/src/+/1355244/
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dfddfccbd029409ac24992a76c6f926e5818934

commit 8dfddfccbd029409ac24992a76c6f926e5818934
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Thu Nov 29 21:44:07 2018

Check AllowStartingServiceManagerOnly in ServiceManagerStartupUtils.

AllowStartingServiceManagerOnly already gates starting the service
manager early in the native code. Make the Java code check the flag
too.

Bug:  899225 , 899226 
Change-Id: Iadc7d03b4e3b559815a72de66ff249f2ad36bbbb
Reviewed-on: https://chromium-review.googlesource.com/c/1318362
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612380}
[modify] https://crrev.com/8dfddfccbd029409ac24992a76c6f926e5818934/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/8dfddfccbd029409ac24992a76c6f926e5818934/chrome/android/java/src/org/chromium/chrome/browser/init/ServiceManagerStartupUtils.java
[modify] https://crrev.com/8dfddfccbd029409ac24992a76c6f926e5818934/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/8dfddfccbd029409ac24992a76c6f926e5818934/content/app/content_main_runner_impl.cc
[modify] https://crrev.com/8dfddfccbd029409ac24992a76c6f926e5818934/content/public/common/content_features.cc
[modify] https://crrev.com/8dfddfccbd029409ac24992a76c6f926e5818934/content/public/common/content_features.h

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb181327ccbc75581d8ce46148c45ec7746f14a6

commit fb181327ccbc75581d8ce46148c45ec7746f14a6
Author: Xi Han <hanxi@google.com>
Date: Fri Nov 30 16:05:26 2018

Update commandline flags for ServicificationBackgroundServiceTest.

This is a follow for CL (https://crrev.com/c/1318362) which changes
"AllowStartingServiceManagerOnly" from commandline flag to a feature.
Update the ServicificationBackgroundServiceTest accordingly which has
this flag turned on.

Bug:  899225 
Change-Id: Ia1256af793cf6a49c7b6aaa88b4fa95bf619b657
Reviewed-on: https://chromium-review.googlesource.com/c/1357000
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612664}
[modify] https://crrev.com/fb181327ccbc75581d8ce46148c45ec7746f14a6/chrome/android/javatests/src/org/chromium/chrome/browser/ServicificationBackgroundServiceTest.java

Status: Fixed (was: Assigned)

Sign in to add a comment