New issue
Advanced search Search tips

Issue 899193 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'Show password' icon is seen missing at 'Password' field in 'Join Wi-Fi network' overlay

Project Member Reported by mmanchala@chromium.org, Oct 26

Issue description

Chrome Version: 72.0.3591.0/11193.0.0 dev channel Peppy,Candy,Blaze
OS: Chrome

What steps will reproduce the problem?
(1)Recover build -> In OOBE screen click on 'Let's go' which navigates to 'Connect to network' screen
(2)Now select required Wi-Fi network -> 'Join Wi-Fi network' overlay is seen -> now observe for 'Show password' icon at 'Password' field
(Please refer Video and Screenshot)

Expected: 'Show password' icon should be available at 'Password' field
Actual: Instead 'Show password' icon is seen missing at 'Password' field

This is a Regression issue as same is working fine in 72.0.3582.0/11168.0.0  

 
Actual_NoShowPasswordIcon.mp4
9.7 MB View Download
Actual_NoShowPasswordIcon.jpg
862 KB View Download
Expected_ShowPasswordIcon.jpg
515 KB View Download
Cc: olsen@chromium.org
Owner: nikitapodguzov@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f61c8347bc424d4a49e821a3752c03a1d81ecb6

commit 9f61c8347bc424d4a49e821a3752c03a1d81ecb6
Author: Nikita Podguzov <nikitapodguzov@chromium.org>
Date: Wed Oct 31 15:53:12 2018

Fix the disappearance of 'Show password' button in network configuration.

Bug:  899193 
Change-Id: I282a91ea90d5cebe4353a223960712c3b3be9c73
Reviewed-on: https://chromium-review.googlesource.com/c/1308715
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
Cr-Commit-Position: refs/heads/master@{#604270}
[modify] https://crrev.com/9f61c8347bc424d4a49e821a3752c03a1d81ecb6/ui/webui/resources/cr_components/chromeos/network/network_password_input.html
[modify] https://crrev.com/9f61c8347bc424d4a49e821a3752c03a1d81ecb6/ui/webui/resources/cr_components/chromeos/network/network_password_input.js

Status: Fixed (was: Assigned)

Sign in to add a comment