Regression : Unable to select 'Custom' radio button through 'Spacebar' key even though focus is present on it.
Reported by
avsha...@etouch.net,
Oct 26
|
||||
Issue descriptionChrome Version : 72.0.3592.0 (Official Build) 3274d2b27158c8f54008ac69629235202f28f306-refs/branch-heads/3592@{#1} 32/64 bit OS : Mac(10.13.1, 10.13.6, 10.14.1), Windows(7,8,10), Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, open NTP and open Print Preview window. 2. Right click on 'Custom' radio button (Context menu opens) and press 'Esc' to dismiss context menu. 3. Hit 'Spacebar' key and observe. Actual Result : Unable to select 'Custom' radio button through 'Spacebar' key even though focus is present on it. Expected Result : 'Custom' radio button should get selected and text caret should appear in text field after step 3. This is a regression issue broken in M-72 and below is the bisect information: Good Build : 72.0.3589.0 (Revision : 601811) Bad Build : 72.0.3590.0(Revision : 602167) Chromium bisect URL: https://chromium.googlesource.com/chromium/src/+log/62396dd247b8f5d069706ddfd561148ef2f6d27b..d0372afee62a71bafb4ecaf73b13d371a1fabc58 Suspecting : r602152 ? Esmael@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : 1. Unable to provide bisect using 'per-revision' script as it shows "We don't have enough builds.." error message for above regression range, hence provided suspect through 'Chromium bisect'. (Tried on other machines but still getting the same error again) 2. In good build #72.0.3589.0, in Windows OS, after step 2, focus disappears on pressing 'Esc' key but then hitting 'Spacebar' brings text caret in 'Custom' text field and radio button gets selected. Thank you..!
,
Oct 26
,
Oct 30
hcarmona@ recommends hiding the tree when searching.
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56e59f79f0f447415b13602c29c177e016e4afd1 commit 56e59f79f0f447415b13602c29c177e016e4afd1 Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed Oct 31 05:15:01 2018 WebUI: cr-radio-group, select radio button with focus when enter/space pressed Bug: 899187 Change-Id: Ib640ceeec2abeb1f6ad1411cc10633018f85e303 Reviewed-on: https://chromium-review.googlesource.com/c/1308076 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#604160} [modify] https://crrev.com/56e59f79f0f447415b13602c29c177e016e4afd1/chrome/test/data/webui/cr_elements/cr_radio_group_test.js [modify] https://crrev.com/56e59f79f0f447415b13602c29c177e016e4afd1/ui/webui/resources/cr_elements/cr_radio_group/cr_radio_group.js
,
Oct 31
|
||||
►
Sign in to add a comment |
||||
Comment 1 by marthasi...@gmail.com
, Oct 26