New issue
Advanced search Search tips

Issue 899183 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 914316
Owner:
Closed: Dec 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Tool-tip is seen chopped on mouse hovering on 'iron' icon.

Reported by sanyam.g...@etouch.net, Oct 26

Issue description

Chrome version :72.0.3592.0 (Official Build)Revision 3274d2b27158c8f54008ac69629235202f28f306-refs/branch-heads/3592@{#1}(32/64-bit)
OS: Windows(7,8,8.1.10) ,Mac( 10.13.1 , 10.13.6 , 10.14), Linux(14.04 LTS) 

What steps will reproduce the problem?
1. Launch chrome and navigate to ' chrome://settings/content/notifications'.
2. Now mouse hover on iron-icon and observe.

Actual  : Tool-tip is seen chopped on mouse hovering on iron-icon in ' chrome://settings/content/notifications'
Expected: Tool-tip should not be seen chopped on mouse hovering on iron-icon in' chrome://settings/content/notifications'

This is a regression issue broken in ‘M-72’ and will soon update the bisect info:
Good Build : 72.0.3591.0 (Revision:602532)
Bad Build  : 72.0.3592.0 (Revision:602946)

 
Actual_Behaviour.mov
981 KB View Download
Expected_Behaviour.mov
1.0 MB View Download
Labels: hasbisect
Owner: aee@chromium.org
Status: Assigned (was: Unconfirmed)
Update:
Change-Log URL:
https://chromium.googlesource.com/chromium/src/+log/72.0.3591.0..72.0.3592.0?pretty=fuller&n=10000

Suspecting: r602577 ?

@Esmael: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1.Tried per revision bisect on Windows ,Mac and Linux OS but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect" error 
2.Unable to perform 'chromium bisect' script as issue is not reproducible on chromium builds, hence providing suspect through Manual change-log.
Cc: aee@chromium.org
 Issue 901274  has been merged into this issue.
Screenshots for https://chromium-review.googlesource.com/c/chromium/src/+/1315627.
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5181c8f75f52980b89768e7732a204b74bd3fc4b

commit 5181c8f75f52980b89768e7732a204b74bd3fc4b
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Nov 02 19:50:57 2018

Settings WebUI: site list, keep tooltip visible within offsetParent

Bug:  899183 
Change-Id: I36a9c92556215d79bc40dbe9aed6ec8f1d5fa5c1
Reviewed-on: https://chromium-review.googlesource.com/c/1315627
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605027}
[modify] https://crrev.com/5181c8f75f52980b89768e7732a204b74bd3fc4b/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/5181c8f75f52980b89768e7732a204b74bd3fc4b/chrome/browser/resources/settings/site_settings/site_list.js

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
Even if I revert r605027, I am no longer able to reproduce the tooltip being clipped (see screenshot). I believe the clipping issue has been fixed by the removal of Settings page/subpage animations as part of  issue 907333 .

Should we revert r605027 such that the tooltip is centered (again)?
tooltip_not_clipped.png
51.5 KB View Download
Cc: johntlee@chromium.org
Mergedinto: 914316
Status: Duplicate (was: Assigned)

Sign in to add a comment