New issue
Advanced search Search tips

Issue 899178 link

Starred by 1 user
Status: Fixed
Owner:
cbiesin...@chromium.org
Closed: Oct 30
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Buttons appear to overlap on extension card boundary

Reported by vineetha...@etouch.net, Oct 26 
Chrome Version: 72.0.3592.0 (Official Build) Revision 3274d2b27158c8f54008ac69629235202f28f306-refs/branch-heads/3592@{#1}(32/64 Bit)
OS: Windows(7,8,8.1,10), Mac (10.13.1, 10.13.6, 10.14.1)

What steps will reproduce the problem?
1. Launch chrome , navigate to chrome://settings/ and change font size to 'Very Large'.
2. Now navigate to chrome://extensions/ and observe the buttons in extension card.
 
Actual Result  : Buttons('Details' , 'Remove') appear to overlap on extension card boundary on changing font size to 'Very Large'.
Expected Result: Buttons should be within the limit of extension card boundary.

This is a regression issue, broken in M-72, and will soon update other info:

Good Build:72.0.3588.0 (Revision:601410)
Bad Build: 72.0.3589.0 (Revision:601810)
ActualVideo.mp4
467 KB View Download
ExpectedVideo.mp4
445 KB View Download

Comment 1 by vineetha...@etouch.net, Oct 26

Labels: hasbisect OS-Linux
Owner: cbiesin...@chromium.org
Status: Assigned (was: Unconfirmed)
Updating bisect info:

You are probably looking for a change made after 601528 (known good), but no later than 601541 (first known bad).
CHANGE-LOG URL:

https://chromium.googlesource.com/chromium/src/+log/a7dbc108d44baa4228ce37bfe6cfcb1b8990cf71..2fa238e3ac6f79fe0e11c8a1065fed41b4ac4a1e

Suspect:https://chromium.googlesource.com/chromium/src/+/155c1f2bf45369bc7130c89b88c75c2d3c915410

@cbiesinger: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Providing suspect through 'chromium bisect' because unable to perform bisect using 'per-revision' script.
2. Tried performing 'per revision' bisect on multiple Windows, Mac machines but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect" error .
3.Issue is also seen on Linux (14.04 LTS) OS.

Thank you
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df8c944e0f227f9c0fc2507a419f0e47f71929f3

commit df8c944e0f227f9c0fc2507a419f0e47f71929f3
Author: Christian Biesinger <cbiesinger@chromium.org>
Date: Tue Oct 30 00:44:36 2018

Fix regression in the extension UI

This div needs min-height: 0 after crrev.com/c/1269235

R=rdevlin.cronin@chromium.org

Bug:  899177 , 899178 
Change-Id: Ia000eb4f22b21247743986b81ae3190322d2c63e
Reviewed-on: https://chromium-review.googlesource.com/c/1306033
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603706}
[modify] https://crrev.com/df8c944e0f227f9c0fc2507a419f0e47f71929f3/chrome/browser/resources/md_extensions/item.html

Comment 4 by cbiesin...@chromium.org, Oct 30

Status: Fixed (was: Assigned)

Comment 5 by vineetha...@etouch.net, Nov 1

Labels: TE-Verified-M72 TE-Verified-72.0.3598.0
Update :

Rechecked the above issue on Windows(7,8,8.1,10), Mac(10.13.1 , 10.13.6, 10.14.1)OS with latest Canary version #72.0.3598.0 and the issue is fixed.

Kindly refer the attached screen cast.
CanaryBehaviour.mp4
302 KB View Download
►

Sign in to add a comment