New issue
Advanced search Search tips

Issue 899177 link

Starred by 1 user
Status: Fixed
Owner:
cbiesin...@chromium.org
Closed: Oct 30
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Distance between 'Details' and 'Remove' buttons and bottom border of 'Click and Clean' extension card is reduced.

Reported by shruti.j...@etouch.net, Oct 26 
Chrome Version: 72.0.3592.0 (Official Build) Revision3274d2b27158c8f54008ac69629235202f28f306-refs/branch-heads/3592@{#1}(32/64-bit)
OS : MAC(10.13.1,10.13.6,10.14.1) Windows(7,8,8.1,10) and Linux(14.04 LTS) OS


Test URL:https://chrome.google.com/webstore/detail/clickclean/ghgabhipcejejjmhhchfonmamedcbeod/related?utm_source=chrome-ntp-icon

Steps to reproduce:
1. Launch chrome and download the extension from above Test URL.
2. Navigate to chrome://extension.
3. Press Tab and bring the Focus on 'Details' and 'Remove' of click and clean extension card.

Actual Result: Distance between 'Details' and 'Remove' buttons and bottom border of extension card is reduced.
Expected Result :Proper distance should be seen between 'Details' and 'Remove' buttons and bottom border of extension card.

This is a regression issue broken in ‘M-72’ and will soon inform the bisect info:
Good Build : 72.0.3588.0
Bad Build : 72.0.3589.0

Kindly refer the attached screen-cast.
Thank you..!
Actual_result.mov
11.2 MB View Download
Expected_result.mov
8.9 MB View Download

Comment 1 by shruti.j...@etouch.net, Oct 26

Labels: hasbisect
Owner: cbiesin...@chromium.org
Status: Assigned (was: Unconfirmed)
Update:
Bisect info:

You are probably looking for a change made after 601528 (known good), but no later than 601541 (first known bad).
CHANGE-LOG URL:

https://chromium.googlesource.com/chromium/src/+log/a7dbc108d44baa4228ce37bfe6cfcb1b8990cf71..2fa238e3ac6f79fe0e11c8a1065fed41b4ac4a1e

Suspect:https://chromium.googlesource.com/chromium/src/+/155c1f2bf45369bc7130c89b88c75c2d3c915410

@Christian Biesinger: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.


Note:

1.Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect" error message.
2.Tried on other machines but still getting the same error again.
3.Hence provided suspect through 'Chromium bisect'.

Thank you..!
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df8c944e0f227f9c0fc2507a419f0e47f71929f3

commit df8c944e0f227f9c0fc2507a419f0e47f71929f3
Author: Christian Biesinger <cbiesinger@chromium.org>
Date: Tue Oct 30 00:44:36 2018

Fix regression in the extension UI

This div needs min-height: 0 after crrev.com/c/1269235

R=rdevlin.cronin@chromium.org

Bug:  899177 , 899178 
Change-Id: Ia000eb4f22b21247743986b81ae3190322d2c63e
Reviewed-on: https://chromium-review.googlesource.com/c/1306033
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603706}
[modify] https://crrev.com/df8c944e0f227f9c0fc2507a419f0e47f71929f3/chrome/browser/resources/md_extensions/item.html

Comment 4 by cbiesin...@chromium.org, Oct 30

Status: Fixed (was: Assigned)

Comment 5 by shruti.j...@etouch.net, Nov 1

Labels: TE-Verified-M72 TE-Verified-72.0.3598.0
Update : 
Retested above issue on  Mac(10.13.1 , 10.13.6 , 10.14.1)  Windows(7,8,10), Linux(14.04 LTS) OS using latest Canary #72.0.3598.0 and issue is fixed.Now distance is seen proper between 'Details' and 'Remove' buttons and bottom border of extension card.
Kindly review the attached screen-cast.
Thank you
Canaryt#72.0.3598.0.mov
7.2 MB View Download
►

Sign in to add a comment