New issue
Advanced search Search tips

Issue 899174 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Tab_Switching results calculation includes unwanted data

Reported by zhenyu.s...@intel.com, Oct 26

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36
Platform: 11092.0.0 (Official Build) dev-channel reef-unibuild test

Steps to reproduce the problem:
1. Run tab_switching.typical_25 on ChromeBook
2. See results and trace file

What is the expected behavior?
Result should include 24 tab_switching latency data as there are 24 web pages

What went wrong?
Results shows there are 25 data accounted in tab_switching_latency

An unwanted data at first page load is included, see attached trace at 22.134s in Renderer PID 4439

Did this work before? N/A 

Chrome version: 71.0.3558.0  Channel: dev
OS Version: 71.0.3558.0
Flash Version: 

This issue introduces huge regression and variance in tab_switching case, please take a look and fix it.
 
results1.html
1.1 MB View Download
multitab_misc_typical24_2018-10-26_16-23-14_88334.html
3.7 MB View Download
Cc: sadrul@chromium.org
Components: Speed>Metrics
Owner: vovoy@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to listed owner of the benchmark per https://cs.chromium.org/chromium/src/tools/perf/benchmark.csv?type=cs&q=tab_switching.typical_25&sq=package:chromium&g=0&l=64
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/277cdb9bcc3ea97b1e1e669394801a88c7c6c797

commit 277cdb9bcc3ea97b1e1e669394801a88c7c6c797
Author: trail <yuzhao.zhang@intel.com>
Date: Wed Dec 12 17:20:45 2018

Tab_Switching results calculation includes unwanted data

The TabSwitching::Latency trace events can be generated when opening the
initial set of tabs. However, the benchmark should ignore those times,
and only look at the ones that were generated during tab-swithcing. So
ignore the TabSwitching::Latancy traces that happen before the first
TabSwitchVisibilityRequest event.

Bug: chromium:899174
Change-Id: I1d37af49546de40549bff8bdb12ed64ced47f989
Reviewed-on: https://chromium-review.googlesource.com/c/1355971
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>

[modify] https://crrev.com/277cdb9bcc3ea97b1e1e669394801a88c7c6c797/tracing/tracing/metrics/tabs_metric_test.html
[modify] https://crrev.com/277cdb9bcc3ea97b1e1e669394801a88c7c6c797/tracing/tracing/metrics/tabs_metric.html
[modify] https://crrev.com/277cdb9bcc3ea97b1e1e669394801a88c7c6c797/AUTHORS

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/482f3998818b9b5556d519683bfce6bcb5ed7490

commit 482f3998818b9b5556d519683bfce6bcb5ed7490
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Dec 12 18:46:12 2018

Roll src/third_party/catapult 149e7c6373d2..277cdb9bcc3e (1 commits)

https://chromium.googlesource.com/catapult.git/+log/149e7c6373d2..277cdb9bcc3e


git log 149e7c6373d2..277cdb9bcc3e --date=short --no-merges --format='%ad %ae %s'
2018-12-12 yuzhao.zhang@intel.com Tab_Switching results calculation includes unwanted data


Created with:
  gclient setdep -r src/third_party/catapult@277cdb9bcc3e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:899174
TBR=sullivan@chromium.org

Change-Id: I679895819692b4a5e2575a90527918dd4525c3f9
Reviewed-on: https://chromium-review.googlesource.com/c/1374040
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615978}
[modify] https://crrev.com/482f3998818b9b5556d519683bfce6bcb5ed7490/DEPS

Sign in to add a comment