cr-toast does not handle long strings properly, button pushed outside of its bounds.
Reported by
aiman.an...@etouch.net,
Oct 26
|
||||||
Issue descriptionChrome Version: 71.0.3578.24 (Official Build) d5ca255f49a9e00ca6a6d3433ef95b17fb650a64-refs/branch-heads/3578@{#338} (32/64-bit). OS: Win(7,8,8.1,10) only. Pre-Condition: Change chrome browser language to 'Tamil' from chrome://settings/languages and Relaunch the browser. What steps will reproduce the problem? 1. In chrome, navigate to chrome://settings/privacy. 2. Toggle button for 'Allow Chrome sign-in'. 3. Observe Relaunch button in toast message. Actual Result: Relaunch button is seen out of toast message boundary. Expected Result: Relaunch button should be within the limit of toast message boundary. This is a regression issue, broken in M-71, and below is the bisect info Good Build:71.0.3570.0 (Revision:596429) Bad Build: 71.0.3571.0 (Revision:596950) CHANGE-LOG URL: Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/71.0.3570.0..71.0.3571.0?pretty=fuller&n=10000 Suspecting: r596752 ? govind@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect." error. 2. Unable to perform Chromium bisect as 'File is not a zip file' Error is seen. 3. Hence providing suspect manually. 4. Issue is not reproducible on Mac(10.13.1, 10.13.6, 10.14) and Linux(14.04 LTS) OS. Kindly refer the attached screen cast for reference. Thank You!
,
Oct 26
+pbommana@, could you ptal and find right owner? r596752 is automated CL created by translation script, so i don't think that is the culprit. "RBS" for tracking purpose as it is M71 regression.
,
Oct 29
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Oct 29
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Oct 29
r596752 simply updated translations, which reveales this bug, but is not the root cause. The actual underlying issue is that cr-toast has a fixed max width, and does not wrap its contentns accordingly. FWIW, I don't think this should be a RBS.
,
Oct 29
,
Oct 29
Candidate fix at https://chromium-review.googlesource.com/c/chromium/src/+/1305212. Posting before/after screenshots.
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69ad1a04c8171941637a440fa619d0923fefa993 commit 69ad1a04c8171941637a440fa619d0923fefa993 Author: dpapad <dpapad@chromium.org> Date: Mon Oct 29 21:41:14 2018 WebUI cr-toast: Handle long strings by wrapping. Previously content was pushed outside of the toast's boundaries. Bug: 899147 Change-Id: I0f235ff6cff1c52b3505f6ffd9c5dc5e7bfb0a68 Reviewed-on: https://chromium-review.googlesource.com/c/1305212 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#603638} [modify] https://crrev.com/69ad1a04c8171941637a440fa619d0923fefa993/ui/webui/resources/cr_elements/cr_toast/cr_toast.html
,
Oct 29
,
Oct 30
Hi, Retested the above issue on Win(7,8,8.1,10) using latest Canary build #72.0.3596.0 and issue is fixed now. Now, Relaunch button is within the limit of toast message. Kindly refer the attached screen-cast for reference. Thank You! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dpa...@chromium.org
, Oct 26Labels: -Pri-1 OS-Chrome OS-Linux OS-Mac Pri-3
Owner: ----
Status: Available (was: Assigned)