New issue
Advanced search Search tips

Issue 899128 link

Starred by 2 users
Status: Fixed
Owner:
jarhar@chromium.org
Closed: Nov 5
Cc:
susan.boorgula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

If response output has '%debug' in text, it will convert to Şbug in Preview Tag

Reported by hknguye...@gmail.com, Oct 26 
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36

Steps to reproduce the problem:
1. Create simple test.php file like this:

<?php
echo '%debug';

2. Run that file on browser with DevTools

What is the expected behavior?
On Response Tab and Preview Tab, we just see: 

%debug

What went wrong?
On Response Tab, we can see: 

%debug

But on Preview Tab, it convert to:

Şbug

Did this work before? N/A 

Chrome version: 70.0.3538.77  Channel: stable
OS Version: 10.0
Flash Version: 

Same problem on Version 69.0.3497.100 and Version 70.0.3538.77

Comment 1 by hknguye...@gmail.com, Oct 26 

Another case:

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36

Steps to reproduce the problem:
1. Create simple test.php file like this:

<?php
echo '…';

2. Run that file on browser with DevTools

What is the expected behavior?
On Response Tab and Preview Tab, we just see: 

…

What went wrong?
On Response Tab, we can see: 

…

But on Preview Tab, it's converted to:

…

Did this work before? N/A 

Chrome version: 70.0.3538.77  Channel: stable
OS Version: 10.0
Flash Version: 

I think on second case, it maybe cause by UTF-8 and ASCII characters.

Comment 2 by susan.boorgula@chromium.org, Oct 26

Cc: susan.boorgula@chromium.org
Labels: Triaged-ET Needs-Feedback Needs-Triage-M70
hknguyenvu@ Thanks for the issue.

Request you to provide a sample file where the issue can be reproduced, which will help in further triaging of the issue.

Thanks..

Comment 3 by hknguye...@gmail.com, Oct 26 

Yes, just very simple code to reproduce
test.png
7.1 KB View Download
test1.php
25 bytes View Download
test2.php
33 bytes View Download
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 26

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by jarhar@chromium.org, Oct 26

Owner: jarhar@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8265a0ceb8abec5b0d9374e87d49ceaba10f25f

commit b8265a0ceb8abec5b0d9374e87d49ceaba10f25f
Author: Joey Arhar <jarhar@chromium.org>
Date: Mon Nov 05 20:07:17 2018

[DevTools] Detect encoding to use for html previews

Bug:  899128 
Change-Id: I6275ce55fec18dcba45c8cbb085a1eea45b5fba6
Reviewed-on: https://chromium-review.googlesource.com/c/1310564
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605433}
[add] https://crrev.com/b8265a0ceb8abec5b0d9374e87d49ceaba10f25f/third_party/WebKit/LayoutTests/http/tests/devtools/network/html-preview-encoding-expected.txt
[add] https://crrev.com/b8265a0ceb8abec5b0d9374e87d49ceaba10f25f/third_party/WebKit/LayoutTests/http/tests/devtools/network/html-preview-encoding.js
[add] https://crrev.com/b8265a0ceb8abec5b0d9374e87d49ceaba10f25f/third_party/WebKit/LayoutTests/http/tests/devtools/network/resources/content-type-iso.php
[add] https://crrev.com/b8265a0ceb8abec5b0d9374e87d49ceaba10f25f/third_party/WebKit/LayoutTests/http/tests/devtools/network/resources/content-type-none.php
[add] https://crrev.com/b8265a0ceb8abec5b0d9374e87d49ceaba10f25f/third_party/WebKit/LayoutTests/http/tests/devtools/network/resources/content-type-utf8.php
[modify] https://crrev.com/b8265a0ceb8abec5b0d9374e87d49ceaba10f25f/third_party/blink/renderer/devtools/front_end/network/RequestPreviewView.js
[modify] https://crrev.com/b8265a0ceb8abec5b0d9374e87d49ceaba10f25f/third_party/blink/renderer/devtools/front_end/sdk/NetworkRequest.js

Comment 7 by jarhar@chromium.org, Nov 5

Status: Fixed (was: Assigned)
I submitted a fix, it should be visible in Canary within 24 hours
►

Sign in to add a comment