New issue
Advanced search Search tips

Issue 899109 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 850624



Sign in to add a comment

NavigationPredictor: Discard anchor elements that point to the same URL as the current document's URL

Project Member Reported by tbansal@chromium.org, Oct 26

Issue description

Some webpages contain anchor elements that point to the same target as the URL of the current webpage. Generally, such anchor elements appear in the viewport, but are unlikely to be clicked by the user. Examples include: Website logo that appears on the homepage and points to the homepage of the website.

While predicting the next navigation, we should discard such anchor elements.
 
Blocking: 850624
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2085e974ab1ac7a0ba144dfbb48a7c83d1480309

commit 2085e974ab1ac7a0ba144dfbb48a7c83d1480309
Author: Tarun Bansal <tbansal@chromium.org>
Date: Sat Oct 27 04:33:32 2018

NavigationPredictor: Do not include same document anchor elements when predicting next element

Change-Id: I592b1f4fcf2fe2e4f2576bb49f75885896485741
Bug:  899109 
Reviewed-on: https://chromium-review.googlesource.com/c/1300679
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603311}
[modify] https://crrev.com/2085e974ab1ac7a0ba144dfbb48a7c83d1480309/chrome/browser/navigation_predictor/navigation_predictor.cc
[modify] https://crrev.com/2085e974ab1ac7a0ba144dfbb48a7c83d1480309/chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc
[modify] https://crrev.com/2085e974ab1ac7a0ba144dfbb48a7c83d1480309/chrome/test/data/navigation_predictor/simple_page_with_anchors.html

Status: Fixed (was: Started)

Sign in to add a comment