New issue
Advanced search Search tips

Issue 899105 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Switch to use Uri instead of String when launching intent for downloaded content

Project Member Reported by qin...@chromium.org, Oct 26

Issue description

see b/63351122

We currently use String for both ORIGINATING_URI and REFERRER, should use Uri to match that of DownloadProvider
 
Labels: -Pri-3 Merge-Request-71 Pri-2
Owner: qin...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 26

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fed00e61e974797c6bf76b93d0a77bc562871775

commit fed00e61e974797c6bf76b93d0a77bc562871775
Author: Min Qin <qinmin@chromium.org>
Date: Fri Oct 26 22:01:51 2018

make intent extra a Uri instead of String when launching it

DownloadProvider sets the extra as Uri. Chrome should also do the same
so the security team can handle them properly.

BUG=899105

Change-Id: I264ed29c9a9f7c730531116ab4261e2de71481b9
Reviewed-on: https://chromium-review.googlesource.com/c/1302099
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603207}
[modify] https://crrev.com/fed00e61e974797c6bf76b93d0a77bc562871775/chrome/android/java/src/org/chromium/chrome/browser/media/MediaViewerUtils.java

Pls apply appropriate OSs label.
Labels: OS-Android
Labels: -Hotlist-Merge-Review -Merge-Review-71 Merge-Approved-71
Merge approved to 71, branch 3578.
Cc: benmason@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 30

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a5fefd42e1d5c0153179e3c3f1aaaffc3b9f2c2

commit 5a5fefd42e1d5c0153179e3c3f1aaaffc3b9f2c2
Author: Min Qin <qinmin@chromium.org>
Date: Tue Oct 30 18:02:27 2018

make intent extra a Uri instead of String when launching it

DownloadProvider sets the extra as Uri. Chrome should also do the same
so the security team can handle them properly.

BUG=899105

Change-Id: I264ed29c9a9f7c730531116ab4261e2de71481b9
Reviewed-on: https://chromium-review.googlesource.com/c/1302099
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603207}(cherry picked from commit fed00e61e974797c6bf76b93d0a77bc562871775)
Reviewed-on: https://chromium-review.googlesource.com/c/1308101
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#405}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/5a5fefd42e1d5c0153179e3c3f1aaaffc3b9f2c2/chrome/android/java/src/org/chromium/chrome/browser/media/MediaViewerUtils.java

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/5a5fefd42e1d5c0153179e3c3f1aaaffc3b9f2c2

Commit: 5a5fefd42e1d5c0153179e3c3f1aaaffc3b9f2c2
Author: qinmin@chromium.org
Commiter: qinmin@chromium.org
Date: 2018-10-30 18:02:27 +0000 UTC

make intent extra a Uri instead of String when launching it

DownloadProvider sets the extra as Uri. Chrome should also do the same
so the security team can handle them properly.

BUG=899105

Change-Id: I264ed29c9a9f7c730531116ab4261e2de71481b9
Reviewed-on: https://chromium-review.googlesource.com/c/1302099
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603207}(cherry picked from commit fed00e61e974797c6bf76b93d0a77bc562871775)
Reviewed-on: https://chromium-review.googlesource.com/c/1308101
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#405}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment