New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 899100 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Audit use of PA_LOG(INFO) and only preserve necessary logs

Project Member Reported by hansberry@chromium.org, Oct 25

Issue description

Most uses of PA_LOG(INFO) in our codebases should be verbose logs. As-is, they're very spammy. 
 
Owner: hansberry@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c7329627825343ffa0399d349a36c1960d830b3

commit 8c7329627825343ffa0399d349a36c1960d830b3
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Fri Nov 02 18:56:31 2018

Remove spammy PA_LOGs.

Most usages of PA_LOG(INFO) did not need to be in the default stdout,
and were spammy. This CL downgrades most to VERBOSE, but leaves a choice
few as INFO:
* //chrome/browser/chromeos/tether/tether_service.cc:519
* //chromeos/components/proximity_auth/unlock_manager_impl.cc:219
* //chromeos/components/proximity_auth/unlock_manager_impl.cc:466
* //chromeos/components/tether/active_host_network_state_updater.cc (all)
* //chromeos/services/multidevice_setup/host_backend_delegate_impl.cc:237
* //chromeos/services/secure_channel/ble_connection_manager_impl.cc:261
* //chromeos/services/secure_channel/ble_scanner_impl.cc (all)
* //chromeos/services/secure_channel/secure_channel_impl.cc:132
* //chromeos/services/secure_channel/secure_channel_impl.cc:177
* //components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.cc (all)
* //components/cryptauth/cryptauth_device_manager_impl.cc:659
* //components/cryptauth/secure_channel.cc:269

Some others which were actually error or unexpected cases have been moved
to WARNING or ERROR.

Bug:  899100 
Change-Id: I58c8b734138fcb4c19be940fe79327adebe4d568
Reviewed-on: https://chromium-review.googlesource.com/c/1313762
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604998}
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/ash/multi_device_setup/multi_device_notification_presenter.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chrome/browser/chromeos/android_sms/connection_establisher_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chrome/browser/chromeos/android_sms/connection_manager.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_challenge_wrapper.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chrome/browser/chromeos/multidevice_setup/android_sms_pairing_state_tracker_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chrome/browser/ui/ash/network/tether_notification_presenter.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chrome/browser/ui/webui/settings/chromeos/multidevice_handler.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/proximity_auth/bluetooth_low_energy_connection_finder.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/proximity_auth/messenger_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/proximity_auth/proximity_auth_local_state_pref_manager.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/proximity_auth/proximity_monitor_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/proximity_auth/remote_device_life_cycle_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/proximity_auth/unlock_manager_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/ble_connection_manager.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/ble_scanner_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/connect_tethering_operation.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/connection_preserver_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/disconnect_tethering_request_sender_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/gms_core_notifications_state_tracker_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/host_scan_scheduler_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/host_scanner_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/host_scanner_operation.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/hotspot_usage_duration_tracker.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/master_host_scan_cache.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/message_transfer_operation.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/network_configuration_remover.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/network_connection_handler_tether_delegate.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/network_host_scan_cache.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/tether_component_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/tether_connector_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/tether_disconnector_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/tether_network_disconnection_handler.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/wifi_hotspot_connector.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/components/tether/wifi_hotspot_disconnector_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/device_sync/device_sync_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/device_sync/device_sync_service.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/device_sync/public/cpp/device_sync_client_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/multidevice_setup/account_status_change_delegate_notifier_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/multidevice_setup/device_reenroller.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/multidevice_setup/feature_state_manager_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/multidevice_setup/grandfathered_easy_unlock_host_disabler.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/multidevice_setup/host_backend_delegate_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/multidevice_setup/host_device_timestamp_manager_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/multidevice_setup/host_status_provider_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/multidevice_setup/host_verifier_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/multidevice_setup/multidevice_setup_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/multidevice_setup/multidevice_setup_service.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/secure_channel/ble_connection_manager.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/secure_channel/ble_connection_manager_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/secure_channel/error_tolerant_ble_advertisement_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/secure_channel/pending_connection_manager_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/secure_channel/pending_connection_request_base.h
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/secure_channel/secure_channel_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/secure_channel/secure_channel_initializer.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/chromeos/services/secure_channel/secure_channel_service.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/components/cryptauth/cryptauth_api_call_flow.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/components/cryptauth/cryptauth_device_manager_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/components/cryptauth/cryptauth_enroller_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/components/cryptauth/cryptauth_enrollment_manager_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/components/cryptauth/cryptauth_gcm_manager_impl.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/components/cryptauth/device_to_device_authenticator.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/components/cryptauth/device_to_device_initiator_helper.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/components/cryptauth/device_to_device_responder_operations.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/components/cryptauth/remote_device_loader.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/components/cryptauth/secure_channel.cc
[modify] https://crrev.com/8c7329627825343ffa0399d349a36c1960d830b3/components/cryptauth/sync_scheduler_impl.cc

Status: Fixed (was: Started)
 Issue 901461  has been merged into this issue.
Status: Started (was: Fixed)
I thought converting to VERBOSE would have fixed this issue, but I'm still seeing VERBOSE logs when I run unit tests, like browser_tests. Reopening.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b4180419a3ecbf935bcedc6d79ab9d07647e7c8

commit 8b4180419a3ecbf935bcedc6d79ab9d07647e7c8
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Sat Nov 03 00:03:14 2018

Do not log VERBOSE PA_LOGs to standard logs.

Bug:  899100 
Change-Id: I96193d431fc13ea80068e0b44b7826a31a8e6003
Reviewed-on: https://chromium-review.googlesource.com/c/1316650
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605100}
[modify] https://crrev.com/8b4180419a3ecbf935bcedc6d79ab9d07647e7c8/chromeos/components/proximity_auth/logging/logging.cc
[modify] https://crrev.com/8b4180419a3ecbf935bcedc6d79ab9d07647e7c8/chromeos/components/proximity_auth/logging/logging_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment