New issue
Advanced search Search tips

Issue 899099 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::PaintArtifactCompositor::Update

Project Member Reported by ClusterFuzz, Oct 25

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5973024875216896

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000008
Crash State:
  blink::PaintArtifactCompositor::Update
  blink::LocalFrameView::PushPaintArtifactToCompositor
  blink::LocalFrameView::RunPaintLifecyclePhase
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=602149:602151

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5973024875216896

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 25

Components: Blink>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 25

Labels: Test-Predator-Auto-Owner
Owner: pdr@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/4e8eb7fbb5ada77093c526013db61d2c438ca24d ([BlinkGenPropertyTrees] Promote BGPT to experimental).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: pdr@chromium.org
Components: -Blink>Internals Blink>Paint
Owner: wangxianzhu@chromium.org
Xianzhu, could you look at this one?
Cc: -pdr@chromium.org wangxianzhu@chromium.org
Owner: pdr@chromium.org
Taking this back because I was able to address my other P1s.
Status: Started (was: Assigned)
Work in progress: https://chromium-review.googlesource.com/c/chromium/src/+/1303398
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f39d1bc5bb2f57e1cb60d9366729a59f6ce6514

commit 2f39d1bc5bb2f57e1cb60d9366729a59f6ce6514
Author: Philip Rogers <pdr@chromium.org>
Date: Mon Oct 29 22:48:54 2018

[BlinkGenPropertyTrees] Ensure highlight is removed after object removed

If a LayoutObject is removed we need to ensure the link highlight layers
are cleared. This may not set geometry_needs_update_ so we need to
check for this condition in LinkHighlightImpl::UpdateGeometry.

Bug:  899099 
Change-Id: I306ae5b14e8d84e06b77794e6f5df93460193fc2
Reviewed-on: https://chromium-review.googlesource.com/c/1303398
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603671}
[add] https://crrev.com/2f39d1bc5bb2f57e1cb60d9366729a59f6ce6514/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-removed-crash.html
[modify] https://crrev.com/2f39d1bc5bb2f57e1cb60d9366729a59f6ce6514/third_party/blink/renderer/core/paint/link_highlight_impl.cc

Project Member

Comment 7 by ClusterFuzz, Oct 30

ClusterFuzz has detected this issue as fixed in range 603666:603678.

Detailed report: https://clusterfuzz.com/testcase?key=5973024875216896

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000008
Crash State:
  blink::PaintArtifactCompositor::Update
  blink::LocalFrameView::PushPaintArtifactToCompositor
  blink::LocalFrameView::RunPaintLifecyclePhase
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=602149:602151
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=603666:603678

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5973024875216896

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Oct 30

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5973024875216896 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment