New issue
Advanced search Search tips

Issue 899090 link

Starred by 1 user
Status: Assigned
Owner:
achuith@chromium.org
Cc:
perezju@chromium.org
nedngu...@google.com
crouleau@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Telemetry should mute audio by default

Project Member Reported by sky@chromium.org, Oct 25 
I'm trying to run telemetry tests on actual chromeos devices. Because telemetry plays video at random times, this means I get audio playing at random times. Because the device is rebooted between runs, I have to remember to mute each time through. This is super annoying in the office!

I would be inclined to mute by default, but if we think that is problematic, then please add a command line switch. I'm happy to do this, if you point at the right place to make this change.

Comment 1 by achuith@chromium.org, Oct 25

Cc: nedngu...@google.com
Owner: achuith@chromium.org
A while ago I introduced --ash-disable-system-sounds to disable the startup sound:
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py?l=129

There's code here that seems to use it:
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/accessibility/accessibility_manager.cc?l=514

But this flag is not part of ash switches, but maybe it doesn't need to be?

We have a --mute-audio switch for testing that seems promising:
https://cs.chromium.org/chromium/src/media/base/media_switches.cc?l=123

Comment 2 by sky@chromium.org, Oct 25 

Nice! Let me try --mute-audio.

Comment 3 by nedngu...@google.com, Oct 25

Cc: crouleau@chromium.org perezju@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/593aa2b558d0f2799ef6ff554cd8c4a1ef89a07c

commit 593aa2b558d0f2799ef6ff554cd8c4a1ef89a07c
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Tue Oct 30 19:18:48 2018

Disable sounds when running chromeos tests.

Bug=chromium:899090

Change-Id: I26c28e20dc24f0e8d86359e52df10739986ac15f
Reviewed-on: https://chromium-review.googlesource.com/c/1306275
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/593aa2b558d0f2799ef6ff554cd8c4a1ef89a07c/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py

Comment 5 by benhenry@google.com, Jan 11

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Comment 6 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 7 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry
►

Sign in to add a comment