Android messaging can be installed in a bad state |
|||||||||
Issue descriptionIf it is installed when the site is unavailable, e.g. youre behind a captive portal, Chrome won't be able to get good metadata but will install anyway.
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c45167b26ce8f2ee7d0b44746436f42698d0f6e7 commit c45167b26ce8f2ee7d0b44746436f42698d0f6e7 Author: Ben Wells <benwells@chromium.org> Date: Tue Oct 30 23:07:31 2018 Require manifest to be downloaded successfully when installing Messages This prevents the app being installed with bad metadata if something isn't quite right. Bug: 899088 Change-Id: If56c5096982a79e3172dc38f897e8a54af6857ec Reviewed-on: https://chromium-review.googlesource.com/c/1303316 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#604046} [modify] https://crrev.com/c45167b26ce8f2ee7d0b44746436f42698d0f6e7/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.cc [modify] https://crrev.com/c45167b26ce8f2ee7d0b44746436f42698d0f6e7/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl_unittest.cc
,
Nov 8
Bernie, this is one of the changes I mentioned via email. I just tested this on Canary on a Samus and seems good.
,
Nov 8
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 8
Pls apply appropriate OSs label.
,
Nov 8
,
Nov 8
,
Nov 8
Approved for ChromeOS M71
,
Nov 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd009e4d4d099e7785a63fd0725ea71566b3945a commit bd009e4d4d099e7785a63fd0725ea71566b3945a Author: Ben Wells <benwells@chromium.org> Date: Sun Nov 11 02:54:58 2018 Require manifest to be downloaded successfully when installing Messages This prevents the app being installed with bad metadata if something isn't quite right. TBR=benwells@chromium.org (cherry picked from commit c45167b26ce8f2ee7d0b44746436f42698d0f6e7) Bug: 899088 Change-Id: If56c5096982a79e3172dc38f897e8a54af6857ec Reviewed-on: https://chromium-review.googlesource.com/c/1303316 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604046} Reviewed-on: https://chromium-review.googlesource.com/c/1329807 Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#626} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/bd009e4d4d099e7785a63fd0725ea71566b3945a/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.cc [modify] https://crrev.com/bd009e4d4d099e7785a63fd0725ea71566b3945a/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl_unittest.cc
,
Nov 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd009e4d4d099e7785a63fd0725ea71566b3945a Commit: bd009e4d4d099e7785a63fd0725ea71566b3945a Author: benwells@chromium.org Commiter: benwells@chromium.org Date: 2018-11-11 02:54:58 +0000 UTC Require manifest to be downloaded successfully when installing Messages This prevents the app being installed with bad metadata if something isn't quite right. TBR=benwells@chromium.org (cherry picked from commit c45167b26ce8f2ee7d0b44746436f42698d0f6e7) Bug: 899088 Change-Id: If56c5096982a79e3172dc38f897e8a54af6857ec Reviewed-on: https://chromium-review.googlesource.com/c/1303316 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604046} Reviewed-on: https://chromium-review.googlesource.com/c/1329807 Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#626} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 11
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by benwells@chromium.org
, Oct 29Status: Started (was: Untriaged)