fix flaky IDBFactory databases wpts |
||
Issue descriptionIDBFactory databases() wpts introduced flakiness because of improper usage of async_test. Tests are to be rewritten to be promise_tests to amend this issue.
,
Nov 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de71694e94b4d1e2e97189e23c68273104e52af9 commit de71694e94b4d1e2e97189e23c68273104e52af9 Author: Andreas Butler <andreasbutler@google.com> Date: Sat Nov 03 01:57:53 2018 IndexedDB: fix minor nits in databases() WPTs Fixing minor nits with IndexedDBFactory databases() WPTs as suggested by jsbell@ over email -assert_object_equals is deprecated and shouldn't be used. Prefer to test the results explicitly, even though it's more code. -all of the test cases use 1 for the version - we should have tests for databases at other versions. -the assertion messages should have the form ".... should be ...", describing what is being asserted, rather than attempting to diagnose the problem (it's easier to verify that the assertions match the spec that way) -there are a handful of lines missing semicolons -the trailing done() should not be needed for .any.js tests Bug: 899085 Change-Id: Ie8831c26fabe0e043ccba8238925ac7f520d1d69 Reviewed-on: https://chromium-review.googlesource.com/c/1313275 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Andreas Butler <andreasbutler@google.com> Cr-Commit-Position: refs/heads/master@{#605128} [modify] https://crrev.com/de71694e94b4d1e2e97189e23c68273104e52af9/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/get-databases.any.js
,
Nov 5
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 30